Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DataSource to ChainOpts and pass to NewChain #916

Merged
merged 17 commits into from
Nov 27, 2024

Conversation

reductionista
Copy link
Contributor

@reductionista reductionista commented Nov 6, 2024

Description

Requires Dependencies

Resolves Dependencies

core ref: 7b0c8369f2ae3a9a7fdf0eb490a6ae877b5d9540

@reductionista
Copy link
Contributor Author

reductionista commented Nov 26, 2024

Hmm... says I still need 1 approving review, despite having 3 already.

It must be due to one of these two changes, since all the rest is under bix-build for CODEOWNERS:

[MB-TQH59VKW66:~/workspace/chainlink-solana> git diff origin/develop   --  .github/
diff --git a/.github/workflows/relay.yml b/.github/workflows/relay.yml
index 67921b87..164754d6 100644
--- a/.github/workflows/relay.yml
+++ b/.github/workflows/relay.yml
@@ -26,6 +26,8 @@ jobs:
         uses: actions/checkout@44c2b7a8a4ea60a981eaca3cf939b5f4305c123b # v4.1.5
       - name: Setup go
         uses: actions/setup-go@cdcb36043654635271a94b9a6d1392de5bb323a7 # v5.0.1
+        env:
+          GOTOOLCHAIN: auto
         with:
           go-version-file: "go.mod"
           check-latest: true
[MB-TQH59VKW66:~/workspace/chainlink-solana> git diff origin/develop   --  ops/monitoring
diff --git a/ops/monitoring/Dockerfile b/ops/monitoring/Dockerfile
index 825fb5e4..2b281f41 100644
--- a/ops/monitoring/Dockerfile
+++ b/ops/monitoring/Dockerfile
@@ -1,6 +1,6 @@
 # Build image

-FROM golang:1.22.6 AS build
+FROM golang:1.23.3 AS build

 # OS dependencies
 RUN apt-get update && apt-get install -y wget gcc

.github/* is rel-eng while ops/monitoring/* is realtime. I'm not sure how I've satisfied either of those requirements given the 3 approvals I've got, so I guess I'll ask both of them to look at it 🤔

(If these changes don't make sense, happy to undo them I just figured since we're setting it to 1.23.3 and GOTOOLCHAIN everywhere else we may as well here.)

@jmank88 jmank88 requested a review from chainchad November 26, 2024 13:05
@jmank88
Copy link
Contributor

jmank88 commented Nov 26, 2024

(If these changes don't make sense, happy to undo them I just figured since we're setting it to 1.23.3 and GOTOOLCHAIN everywhere else we may as well here.)

auto is the default, so it would be cleaner to only set it when necessary.

hendoxc
hendoxc previously approved these changes Nov 26, 2024
@cl-sonarqube-production
Copy link

Quality Gate failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 75%)

See analysis details on SonarQube

@aalu1418 aalu1418 merged commit 3c9282e into develop Nov 27, 2024
34 of 35 checks passed
@aalu1418 aalu1418 deleted the NONEVM-694/db-support branch November 27, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants