[NONEVM-876] Pass DataSource to Solana relay

[reductionista]

JIRA: NONEVM-876

Requires

• Add DataSource to ChainOpts and pass to NewChain chainlink-solana#916

[github-actions]

AER Report: CI Core

aer_workflow , commit , Detect Changes , Scheduled Run Frequency , Clean Go Tidy & Generate , Flakeguard Root Project / Get Tests To Run , lint , Core Tests (go_core_tests) , Core Tests (go_core_tests_integration) , Core Tests (go_core_ccip_deployment_tests) , Core Tests (go_core_race_tests) , Core Tests (go_core_fuzz) , Flakeguard Deployment Project / Get Tests To Run , Flakeguard Root Project / Run Tests (github.com/smartcontractkit/chainlink/v2/core/cmd, ubuntu-latest) , Flakeguard Deployment Project / Run Tests , Flakeguard Deployment Project / Report , Flakey Test Detection , SonarQube Scan , Flakeguard Root Project / Report

1. Confirmer is not started: already stopped:[Run Tests]

Source of Error:

logger.go:146: 2024-11-27T20:52:31.001Z	ERROR	EVM.0.Txm	txmgr/txmgr.go:453	Failed to Close Confirmer: Confirmer is not started: already stopped	{"version": "unset@unset", "err": "Confirmer is not started: already stopped"}
github.com/smartcontractkit/chainlink/v2/common/txmgr.(*Txm[...]).runLoop
	/home/runner/work/chainlink/chainlink/common/txmgr/txmgr.go:453

**Why**: The error occurs because the system attempts to close a Confirmer that is already stopped, indicating a redundant or unnecessary operation.

Suggested fix: Add a check to ensure the Confirmer is running before attempting to close it.

2. Tracker is not started: already stopped:[Run Tests]

Source of Error:

logger.go:146: 2024-11-27T20:52:31.001Z	ERROR	EVM.0.Txm	txmgr/txmgr.go:457	Failed to Close Tracker: tracker is not started: already stopped	{"version": "unset@unset", "err": "tracker is not started: already stopped"}
github.com/smartcontractkit/chainlink/v2/common/txmgr.(*Txm[...]).runLoop
	/home/runner/work/chainlink/chainlink/common/txmgr/txmgr.go:457

**Why**: The error occurs because the system attempts to close a Tracker that is already stopped, indicating a redundant or unnecessary operation.

Suggested fix: Add a check to ensure the Tracker is running before attempting to close it.

3. Failed to start CSA key does not exist:[Run Tests]

Source of Error:

logger.go:146: 2024-11-27T20:49:33.553Z	ERROR	chainlink/application.go:706	[Feeds Service] Failed to start CSA key does not exist	{"version": "unset@unset"}
github.com/smartcontractkit/chainlink/v2/core/services/chainlink.(*ChainlinkApplication).Start
	/home/runner/work/chainlink/chainlink/core/services/chainlink/application.go:706

**Why**: The error occurs because the Feeds Service attempts to start without a required CSA key, which is missing.

Suggested fix: Ensure that the CSA key is generated and available before starting the Feeds Service.

4. Broadcaster is not started: already stopped:[Run Tests]

Source of Error:

logger.go:146: 2024-11-27T20:49:34.829Z	ERROR	EVM.0.Txm	txmgr/txmgr.go:449	Failed to Close Broadcaster: Broadcaster is not started: already stopped	{"version": "unset@unset", "err": "Broadcaster is not started: already stopped"}
github.com/smartcontractkit/chainlink/v2/common/txmgr.(*Txm[...]).runLoop
	/home/runner/work/chainlink/chainlink/common/txmgr/txmgr.go:449

**Why**: The error occurs because the system attempts to close a Broadcaster that is already stopped, indicating a redundant or unnecessary operation.

Suggested fix: Add a check to ensure the Broadcaster is running before attempting to close it.

5. Mock method called over expected times:[Run Tests]

Source of Error:

mock.go:337: 
assert: mock: The method has been called over 1 times.
	Either do one more Mock.On("NonceAt").Return(...), or remove extra call.
	This call was unexpected:
		NonceAt(*context.timerCtx,common.Address,*big.Int)
		0: &context.timerCtx{cancelCtx:context.cancelCtx{Context:(*context.cancelCtx)(0xc004de01e0), mu:sync.Mutex{state:0, sema:0x0}, done:atomic.Value{v:(chan struct {})(0xc00988a070)}, children:map[context.canceler]struct {}{}, err:error(nil), cause:error(nil)}, timer:(*time.Timer)(0xc009459b90), deadline:time.Time{wall:0xc1ca00049a273fa3, ext:657864904815, loc:(*time.Location)(0xa8ed880)}}
		1: 0x92A6FBCA429AF069C44b83572f06BfF100858319
		2: <nil>
	at: [/home/runner/work/chainlink/chainlink/core/chains/evm/client/mocks/client.go:1352 /home/runner/work/chainlink/chainlink/core/chains/evm/txmgr/client.go:120 /home/runner/work/chainlink/chainlink/common/txmgr/confirmer.go:294 /home/runner/work/chainlink/chainlink/common/txmgr/confirmer.go:269 /home/runner/work/chainlink/chainlink/common/txmgr/confirmer.go:255 /home/runner/work/chainlink/chainlink/common/txmgr/confirmer.go:240 /opt/hostedtoolcache/go/1.23.3/x64/src/runtime/asm_amd64.s:1700]

**Why**: The error occurs because the mock method `NonceAt` was called more times than expected, indicating a possible issue with the test setup or logic.

Suggested fix: Adjust the mock setup to handle the expected number of calls or review the test logic to ensure the method is not called excessively.

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

[reductionista]

Looks like the failing test is due to TxRetention being added in this commit to chainlink-solana, but no corresponding commit updating the test for it in chainlink repo yet:
smartcontractkit/chainlink-solana@65ae137

@amit-momin are there plans to update chainlink unit tests for this?

[amit-momin]

Looks like the failing test is due to TxRetention being added in this commit to chainlink-solana, but no corresponding commit updating the test for it in chainlink repo yet: smartcontractkit/chainlink-solana@65ae137

@amit-momin are there plans to update chainlink unit tests for this?

Hey @reductionista, I have this PR open to update chainlink. Sorry for the inconvenience. The solana change went in late today so planning to get this reviewed and merged tomorrow.

[github-actions]

Flaky Test Detector for github.com/smartcontractkit/chainlink project has failed ❌

Ran new or updated tests between develop and a7a3913 (NONEVM-694/db-support-solana).

View Flaky Detector Details | Compare Changes

Flaky Tests

Ran 265 unique tests. Below are the tests identified as flaky, with a pass ratio lower than the 99% threshold:

TestPackage                                        TestName                                 PassRatio  RunCount   Skipped
---------                                          ---------                                ---------  ---------  ---------
github.com/smartcontractkit/chainlink/v2/core/cmd  TestShell_ListETHKeys_Error              83%        6          false
github.com/smartcontractkit/chainlink/v2/core/cmd  TestShell_ImportExportETHKey_WithChains  83%        6          false