Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Arbitrum Sepolia chain ID to ChainSpecificUtil.sol #10615

Merged
merged 6 commits into from
Sep 13, 2023

Conversation

kidambisrinivas
Copy link
Collaborator

@kidambisrinivas kidambisrinivas commented Sep 13, 2023

Motivation

  • Arbitrum is releasing a new rollup for sepolia.
  • We need to update the ChainSpecificUtil contract with this new chain ID to be able to support arbitrum there

Solution

Testing

Test a contract that uses ChainSpecificUtil contract for regression

$ forge test -vvvv --match-path test/v0.8/foundry/vrf/TrustedBlockhashStore.t.sol
...
    ├─ [1601] TrustedBlockhashStore::storeTrusted([5], [0x0000000000000000000000000000000000000000000000000000000000000005], 999, 0x00000000000000000000000000000000000000000000000000000000000003e7)
    │   └─ ← ()
    └─ ← ()

Test result: ok. 2 passed; 0 failed; 0 skipped; finished in 6.42ms

Ran 1 test suites: 2 tests passed, 0 failed, 0 skipped (2 total tests)

@github-actions
Copy link
Contributor

I see that you haven't updated any README files. Would it make sense to do so?

@github-actions
Copy link
Contributor

Go solidity wrappers are out-of-date, regenerate them via the make wrappers-all command

1 similar comment
@github-actions
Copy link
Contributor

Go solidity wrappers are out-of-date, regenerate them via the make wrappers-all command

iljapavlovs
iljapavlovs previously approved these changes Sep 13, 2023
vreff
vreff previously approved these changes Sep 13, 2023
iljapavlovs
iljapavlovs previously approved these changes Sep 13, 2023
@kidambisrinivas kidambisrinivas dismissed stale reviews from iljapavlovs and vreff via c7f3ee7 September 13, 2023 14:50
@cl-sonarqube-production
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@kidambisrinivas kidambisrinivas added this pull request to the merge queue Sep 13, 2023
Merged via the queue into develop with commit 0aeb8f5 Sep 13, 2023
122 checks passed
@kidambisrinivas kidambisrinivas deleted the VRF-605-add-arb-sepolia branch September 13, 2023 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants