Configurable Client Errors #12523
Closed
Configurable Client Errors #12523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see you updated files related to |
nickcorin
force-pushed
the
feat/configurable-error-regexes
branch
from
4259590 to
a390c18
Compare
dimriou
reviewed
Mar 21, 2024
There was a problem hiding this comment.
This is soon to be deprecated, we shouldn't add changes here unless it breaks the code.
DylanTinianov
changed the title
… into feat/configurable-error-regexes
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EVM: Add configurable client errors to toml config and propagate through error classification
I have added a new section to the EVM TOML configuration file to allow for custom regex strings to be used for error matching.
This is currently still in a
draftstatus. Work still outstanding:[ ] Add usage of
ClientErrorsinto thetxmgr.[ ] Add some unit tests to ensure the configuration is being loaded as intended.