KS-264: Capability registry internal review informational findings #13437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lity-registry-internal-review-informational-findings
cds95
requested review from
archseer,
bolekk,
patrick-dowell and
a team
as code owners
…lity-registry-internal-review-informational-findings
DeividasK
reviewed
Jun 6, 2024
| @@ -447,13 +463,10 @@ contract CapabilityRegistry is OwnerIsCreator, TypeAndVersionInterface { | |||
|
|
|||
| Node storage node = s_nodes[p2pId]; | |||
|
|
|||
| bool nodeExists = bytes32(node.signer) != bytes32(""); | |||
| if (!nodeExists) revert InvalidNodeP2PId(p2pId); | |||
| if (bytes32(node.signer) == bytes32("")) revert InvalidNodeP2PId(p2pId); | |||
There was a problem hiding this comment.
Suggested change
| if (bytes32(node.signer) == bytes32("")) revert InvalidNodeP2PId(p2pId); | |
| if (bytes32(node.signer) == bytes32("")) revert ???(p2pId); |
The error message here is misleading.
There was a problem hiding this comment.
Shouldn't this check p2pId?
There was a problem hiding this comment.
I was thinking it could be either. We are basically just checking to see if the p2pId on line 464 queried a valid node. Wdyt about changing this error message to be NodeDoesNotExist to match the other error messages when an entity does not exist?
DeividasK
reviewed
Jun 6, 2024
| bool nodeExists = s_nodes[node.p2pId].signer != bytes32(""); | ||
| if (!nodeExists) revert InvalidNodeP2PId(node.p2pId); | ||
| Node storage storedNode = s_nodes[node.p2pId]; | ||
| if (storedNode.signer == bytes32("")) revert InvalidNodeP2PId(node.p2pId); |
DeividasK
approved these changes
Jun 6, 2024
archseer
approved these changes
Jun 6, 2024
cds95
deleted the
KS-264/capability-registry-internal-review-informational-findings
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.