Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KS-264: Capability registry internal review informational findings #13437

Merged
merged 10 commits into from
Jun 6, 2024
Merged

KS-264: Capability registry internal review informational findings #13437

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
144c420
I03: index nodeOperatorId in events
cds95 Jun 3, 2024
f195d80
I08: gas optimizations
cds95 Jun 3, 2024
efca636
Merge branch 'capability-registry-internal-review' into KS-264/capabi…
cds95 Jun 4, 2024
f5aed14
I9: nitpicks
cds95 Jun 4, 2024
3fda376
I12: nits and stylings
cds95 Jun 4, 2024
a333e54
add comments
cds95 Jun 5, 2024
a3a1503
I10: Gas optimizations
cds95 Jun 5, 2024
045a940
generate wrappers
cds95 Jun 5, 2024
9affacc
Merge branch 'capability-registry-internal-review' into KS-264/capabi…
cds95 Jun 5, 2024
6595aef
add changesets
cds95 Jun 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/empty-dryers-fold.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"chainlink": patch
---

#internal capability registry informational findings
5 changes: 5 additions & 0 deletions contracts/.changeset/dull-phones-retire.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@chainlink/contracts': patch
---

capability registry informational findings
138 changes: 71 additions & 67 deletions contracts/gas-snapshots/keystone.gas-snapshot
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,84 +1,88 @@
CapabilityRegistry_AddCapabilitiesTest:test_AddCapability_NoConfigurationContract() (gas: 140145)
CapabilityRegistry_AddCapabilitiesTest:test_AddCapability_WithConfiguration() (gas: 163638)
CapabilityRegistry_AddCapabilitiesTest:test_AddCapability_NoConfigurationContract() (gas: 139938)
CapabilityRegistry_AddCapabilitiesTest:test_AddCapability_WithConfiguration() (gas: 163431)
CapabilityRegistry_AddCapabilitiesTest:test_RevertWhen_CalledByNonAdmin() (gas: 24523)
CapabilityRegistry_AddCapabilitiesTest:test_RevertWhen_CapabilityExists() (gas: 136050)
CapabilityRegistry_AddCapabilitiesTest:test_RevertWhen_ConfigurationContractDoesNotMatchInterface() (gas: 90873)
CapabilityRegistry_AddCapabilitiesTest:test_RevertWhen_ConfigurationContractNotDeployed() (gas: 89273)
CapabilityRegistry_AddDONTest:test_AddDON() (gas: 345809)
CapabilityRegistry_AddDONTest:test_RevertWhen_CalledByNonAdmin() (gas: 21183)
CapabilityRegistry_AddDONTest:test_RevertWhen_CapabilityDoesNotExist() (gas: 156379)
CapabilityRegistry_AddDONTest:test_RevertWhen_DeprecatedCapabilityAdded() (gas: 251492)
CapabilityRegistry_AddDONTest:test_RevertWhen_DuplicateCapabilityAdded() (gas: 257552)
CapabilityRegistry_AddDONTest:test_RevertWhen_DuplicateNodeAdded() (gas: 176737)
CapabilityRegistry_AddDONTest:test_RevertWhen_NodeDoesNotSupportCapability() (gas: 188103)
CapabilityRegistry_AddNodeOperatorsTest:test_AddNodeOperators() (gas: 147674)
CapabilityRegistry_AddCapabilitiesTest:test_RevertWhen_CapabilityExists() (gas: 138529)
CapabilityRegistry_AddCapabilitiesTest:test_RevertWhen_ConfigurationContractDoesNotMatchInterface() (gas: 90644)
CapabilityRegistry_AddCapabilitiesTest:test_RevertWhen_ConfigurationContractNotDeployed() (gas: 89044)
CapabilityRegistry_AddDONTest:test_AddDON() (gas: 378398)
CapabilityRegistry_AddDONTest:test_RevertWhen_CalledByNonAdmin() (gas: 21138)
CapabilityRegistry_AddDONTest:test_RevertWhen_CapabilityDoesNotExist() (gas: 159287)
CapabilityRegistry_AddDONTest:test_RevertWhen_DeprecatedCapabilityAdded() (gas: 254106)
CapabilityRegistry_AddDONTest:test_RevertWhen_DuplicateCapabilityAdded() (gas: 260460)
CapabilityRegistry_AddDONTest:test_RevertWhen_DuplicateNodeAdded() (gas: 179709)
CapabilityRegistry_AddDONTest:test_RevertWhen_NodeDoesNotSupportCapability() (gas: 191011)
CapabilityRegistry_AddNodeOperatorsTest:test_AddNodeOperators() (gas: 148169)
CapabilityRegistry_AddNodeOperatorsTest:test_RevertWhen_CalledByNonAdmin() (gas: 28654)
CapabilityRegistry_AddNodeOperatorsTest:test_RevertWhen_NodeOperatorAdminAddressZero() (gas: 29526)
CapabilityRegistry_AddNodesTest:test_AddsNodeInfo() (gas: 362187)
CapabilityRegistry_AddNodesTest:test_OwnerCanAddNodes() (gas: 362186)
CapabilityRegistry_AddNodesTest:test_RevertWhen_AddingDuplicateP2PId() (gas: 307942)
CapabilityRegistry_AddNodesTest:test_RevertWhen_AddingNodeWithInvalidCapability() (gas: 61464)
CapabilityRegistry_AddNodesTest:test_RevertWhen_AddingNodeWithoutCapabilities() (gas: 33795)
CapabilityRegistry_AddNodesTest:test_RevertWhen_CalledByNonNodeOperatorAdminAndNonOwner() (gas: 30707)
CapabilityRegistry_AddNodesTest:test_RevertWhen_P2PIDEmpty() (gas: 31440)
CapabilityRegistry_AddNodesTest:test_RevertWhen_SignerAddressEmpty() (gas: 31273)
CapabilityRegistry_AddNodesTest:test_RevertWhen_SignerAddressNotUnique() (gas: 320375)
CapabilityRegistry_DeprecateCapabilitiesTest:test_DeprecatesCapability() (gas: 90723)
CapabilityRegistry_DeprecateCapabilitiesTest:test_EmitsEvent() (gas: 90884)
CapabilityRegistry_DeprecateCapabilitiesTest:test_RevertWhen_CalledByNonAdmin() (gas: 23004)
CapabilityRegistry_DeprecateCapabilitiesTest:test_RevertWhen_CapabilityDoesNotExist() (gas: 16223)
CapabilityRegistry_DeprecateCapabilitiesTest:test_RevertWhen_CapabilityIsDeprecated() (gas: 92149)
CapabilityRegistry_GetCapabilitiesTest:test_ExcludesDeprecatedCapabilities() (gas: 112586)
CapabilityRegistry_AddNodeOperatorsTest:test_RevertWhen_NodeOperatorAdminAddressZero() (gas: 29539)
CapabilityRegistry_AddNodesTest:test_AddsNodeInfo() (gas: 361816)
CapabilityRegistry_AddNodesTest:test_OwnerCanAddNodes() (gas: 361815)
CapabilityRegistry_AddNodesTest:test_RevertWhen_AddingDuplicateP2PId() (gas: 307672)
CapabilityRegistry_AddNodesTest:test_RevertWhen_AddingNodeWithInvalidCapability() (gas: 61337)
CapabilityRegistry_AddNodesTest:test_RevertWhen_AddingNodeWithInvalidNodeOperator() (gas: 31100)
CapabilityRegistry_AddNodesTest:test_RevertWhen_AddingNodeWithoutCapabilities() (gas: 33827)
CapabilityRegistry_AddNodesTest:test_RevertWhen_CalledByNonNodeOperatorAdminAndNonOwner() (gas: 31370)
CapabilityRegistry_AddNodesTest:test_RevertWhen_P2PIDEmpty() (gas: 31472)
CapabilityRegistry_AddNodesTest:test_RevertWhen_SignerAddressEmpty() (gas: 31302)
CapabilityRegistry_AddNodesTest:test_RevertWhen_SignerAddressNotUnique() (gas: 320108)
CapabilityRegistry_DeprecateCapabilitiesTest:test_DeprecatesCapability() (gas: 90429)
CapabilityRegistry_DeprecateCapabilitiesTest:test_EmitsEvent() (gas: 90590)
CapabilityRegistry_DeprecateCapabilitiesTest:test_RevertWhen_CalledByNonAdmin() (gas: 22939)
CapabilityRegistry_DeprecateCapabilitiesTest:test_RevertWhen_CapabilityDoesNotExist() (gas: 16158)
CapabilityRegistry_DeprecateCapabilitiesTest:test_RevertWhen_CapabilityIsDeprecated() (gas: 91854)
CapabilityRegistry_GetCapabilitiesTest:test_ExcludesDeprecatedCapabilities() (gas: 112292)
CapabilityRegistry_GetCapabilitiesTest:test_ReturnsCapabilities() (gas: 43926)
CapabilityRegistry_GetDONsTest:test_CorrectlyFetchesDONs() (gas: 63740)
CapabilityRegistry_GetDONsTest:test_DoesNotIncludeRemovedDONs() (gas: 86969)
CapabilityRegistry_GetDONsTest:test_CorrectlyFetchesDONs() (gas: 63784)
CapabilityRegistry_GetDONsTest:test_DoesNotIncludeRemovedDONs() (gas: 86991)
CapabilityRegistry_GetHashedCapabilityTest:test_CorrectlyGeneratesHashedCapabilityId() (gas: 8751)
CapabilityRegistry_GetHashedCapabilityTest:test_DoesNotCauseIncorrectClashes() (gas: 9510)
CapabilityRegistry_GetNodeOperatorsTest:test_CorrectlyFetchesNodeOperators() (gas: 37814)
CapabilityRegistry_GetNodeOperatorsTest:test_DoesNotIncludeRemovedNodeOperators() (gas: 37327)
CapabilityRegistry_GetNodesTest:test_CorrectlyFetchesNodes() (gas: 67928)
CapabilityRegistry_GetNodesTest:test_DoesNotIncludeRemovedNodes() (gas: 82281)
CapabilityRegistry_RemoveDONsTest:test_RemovesDON() (gas: 57276)
CapabilityRegistry_GetNodeOperatorsTest:test_CorrectlyFetchesNodeOperators() (gas: 37880)
CapabilityRegistry_GetNodeOperatorsTest:test_DoesNotIncludeRemovedNodeOperators() (gas: 37463)
CapabilityRegistry_GetNodesTest:test_CorrectlyFetchesNodes() (gas: 67838)
CapabilityRegistry_GetNodesTest:test_DoesNotIncludeRemovedNodes() (gas: 78144)
CapabilityRegistry_RemoveDONsTest:test_RemovesDON() (gas: 60370)
CapabilityRegistry_RemoveDONsTest:test_RevertWhen_CalledByNonAdmin() (gas: 17801)
CapabilityRegistry_RemoveDONsTest:test_RevertWhen_DONDoesNotExist() (gas: 16561)
CapabilityRegistry_RemoveNodeOperatorsTest:test_RemovesNodeOperator() (gas: 37404)
CapabilityRegistry_RemoveNodeOperatorsTest:test_RemovesNodeOperator() (gas: 37762)
CapabilityRegistry_RemoveNodeOperatorsTest:test_RevertWhen_CalledByNonOwner() (gas: 17898)
CapabilityRegistry_RemoveNodesTest:test_CanAddNodeWithSameSignerAddressAfterRemoving() (gas: 89793)
CapabilityRegistry_RemoveNodesTest:test_CanRemoveWhenDONDeleted() (gas: 266586)
CapabilityRegistry_RemoveNodesTest:test_CanRemoveWhenNodeNoLongerPartOfDON() (gas: 719288)
CapabilityRegistry_RemoveNodesTest:test_OwnerCanRemoveNodes() (gas: 63376)
CapabilityRegistry_RemoveNodesTest:test_RemovesNode() (gas: 63384)
CapabilityRegistry_RemoveNodesTest:test_RevertWhen_CalledByNonNodeOperatorAdminAndNonOwner() (gas: 31489)
CapabilityRegistry_RemoveNodesTest:test_RevertWhen_NodeDoesNotExist() (gas: 20578)
CapabilityRegistry_RemoveNodesTest:test_RevertWhen_NodePartOfDON() (gas: 271277)
CapabilityRegistry_RemoveNodesTest:test_RevertWhen_P2PIDEmpty() (gas: 20590)
CapabilityRegistry_RemoveNodesTest:test_CanAddNodeWithSameSignerAddressAfterRemoving() (gas: 88440)
CapabilityRegistry_RemoveNodesTest:test_CanRemoveWhenDONDeleted() (gas: 262049)
CapabilityRegistry_RemoveNodesTest:test_CanRemoveWhenNodeNoLongerPartOfDON() (gas: 717200)
CapabilityRegistry_RemoveNodesTest:test_OwnerCanRemoveNodes() (gas: 59174)
CapabilityRegistry_RemoveNodesTest:test_RemovesNode() (gas: 61000)
CapabilityRegistry_RemoveNodesTest:test_RevertWhen_CalledByNonNodeOperatorAdminAndNonOwner() (gas: 29291)
CapabilityRegistry_RemoveNodesTest:test_RevertWhen_NodeDoesNotExist() (gas: 20569)
CapabilityRegistry_RemoveNodesTest:test_RevertWhen_NodePartOfDON() (gas: 270858)
CapabilityRegistry_RemoveNodesTest:test_RevertWhen_P2PIDEmpty() (gas: 20581)
CapabilityRegistry_TypeAndVersionTest:test_TypeAndVersion() (gas: 9712)
CapabilityRegistry_UpdateCapabilitiesTest:test_RevertWhen_CalledByNonAdmin() (gas: 32669)
CapabilityRegistry_UpdateCapabilitiesTest:test_RevertWhen_CapabilityDoesNotExists() (gas: 33956)
CapabilityRegistry_UpdateCapabilitiesTest:test_RevertWhen_ConfigurationContractDoesNotMatchInterface() (gas: 69052)
CapabilityRegistry_UpdateCapabilitiesTest:test_RevertWhen_ConfigurationContractNotDeployed() (gas: 67430)
CapabilityRegistry_UpdateCapabilitiesTest:test_UpdateCapabilities_NoConfigurationContract() (gas: 87788)
CapabilityRegistry_UpdateCapabilitiesTest:test_UpdateCapabilities_WithConfiguration() (gas: 87966)
CapabilityRegistry_UpdateCapabilitiesTest:test_UpdateCapabilities_NoConfigurationContract() (gas: 87810)
CapabilityRegistry_UpdateCapabilitiesTest:test_UpdateCapabilities_WithConfiguration() (gas: 87988)
CapabilityRegistry_UpdateDONTest:test_RevertWhen_CalledByNonAdmin() (gas: 21302)
CapabilityRegistry_UpdateDONTest:test_RevertWhen_CapabilityDoesNotExist() (gas: 141051)
CapabilityRegistry_UpdateDONTest:test_RevertWhen_CapabilityDoesNotExist() (gas: 140765)
CapabilityRegistry_UpdateDONTest:test_RevertWhen_DONDoesNotExist() (gas: 17397)
CapabilityRegistry_UpdateDONTest:test_RevertWhen_DeprecatedCapabilityAdded() (gas: 176387)
CapabilityRegistry_UpdateDONTest:test_RevertWhen_DuplicateCapabilityAdded() (gas: 182460)
CapabilityRegistry_UpdateDONTest:test_RevertWhen_DuplicateNodeAdded() (gas: 101590)
CapabilityRegistry_UpdateDONTest:test_RevertWhen_NodeDoesNotSupportCapability() (gas: 172820)
CapabilityRegistry_UpdateDONTest:test_UpdatesDON() (gas: 283909)
CapabilityRegistry_UpdateNodeOperatorTest:test_RevertWhen_CalledByNonAdminAndNonOwner() (gas: 20047)
CapabilityRegistry_UpdateNodeOperatorTest:test_RevertWhen_NodeOperatorAdminIsZeroAddress() (gas: 19982)
CapabilityRegistry_UpdateNodeOperatorTest:test_UpdatesNodeOperator() (gas: 74798)
CapabilityRegistry_UpdateNodesTest:test_CanUpdateParamsIfNodeSignerAddressNoLongerUsed() (gas: 262774)
CapabilityRegistry_UpdateNodesTest:test_OwnerCanUpdateNodes() (gas: 164222)
CapabilityRegistry_UpdateNodesTest:test_RevertWhen_AddingNodeWithInvalidCapability() (gas: 42407)
CapabilityRegistry_UpdateNodesTest:test_RevertWhen_CalledByNonNodeOperatorAdminAndNonOwner() (gas: 30762)
CapabilityRegistry_UpdateNodesTest:test_RevertWhen_NodeDoesNotExist() (gas: 31432)
CapabilityRegistry_UpdateNodesTest:test_RevertWhen_NodeSignerAlreadyAssignedToAnotherNode() (gas: 35494)
CapabilityRegistry_UpdateNodesTest:test_RevertWhen_P2PIDEmpty() (gas: 31420)
CapabilityRegistry_UpdateNodesTest:test_RevertWhen_SignerAddressEmpty() (gas: 31294)
CapabilityRegistry_UpdateNodesTest:test_RevertWhen_UpdatingNodeWithoutCapabilities() (gas: 31815)
CapabilityRegistry_UpdateNodesTest:test_UpdatesNodeInfo() (gas: 164200)
CapabilityRegistry_UpdateDONTest:test_RevertWhen_DeprecatedCapabilityAdded() (gas: 175807)
CapabilityRegistry_UpdateDONTest:test_RevertWhen_DuplicateCapabilityAdded() (gas: 182174)
CapabilityRegistry_UpdateDONTest:test_RevertWhen_DuplicateNodeAdded() (gas: 101368)
CapabilityRegistry_UpdateDONTest:test_RevertWhen_NodeDoesNotSupportCapability() (gas: 172534)
CapabilityRegistry_UpdateDONTest:test_UpdatesDON() (gas: 308133)
CapabilityRegistry_UpdateNodeOperatorTest:test_RevertWhen_CalledByNonAdminAndNonOwner() (gas: 22859)
CapabilityRegistry_UpdateNodeOperatorTest:test_RevertWhen_NodeOperatorAdminIsZeroAddress() (gas: 22173)
CapabilityRegistry_UpdateNodeOperatorTest:test_RevertWhen_NodeOperatorDoesNotExist() (gas: 21942)
CapabilityRegistry_UpdateNodeOperatorTest:test_RevertWhen_NodeOperatorIdAndParamLengthsMismatch() (gas: 17582)
CapabilityRegistry_UpdateNodeOperatorTest:test_UpdatesNodeOperator() (gas: 39111)
CapabilityRegistry_UpdateNodesTest:test_CanUpdateParamsIfNodeSignerAddressNoLongerUsed() (gas: 261220)
CapabilityRegistry_UpdateNodesTest:test_OwnerCanUpdateNodes() (gas: 163489)
CapabilityRegistry_UpdateNodesTest:test_RevertWhen_AddingNodeWithInvalidCapability() (gas: 42139)
CapabilityRegistry_UpdateNodesTest:test_RevertWhen_CalledByNonNodeOperatorAdminAndNonOwner() (gas: 31398)
CapabilityRegistry_UpdateNodesTest:test_RevertWhen_NodeDoesNotExist() (gas: 31413)
CapabilityRegistry_UpdateNodesTest:test_RevertWhen_NodeSignerAlreadyAssignedToAnotherNode() (gas: 35388)
CapabilityRegistry_UpdateNodesTest:test_RevertWhen_P2PIDEmpty() (gas: 31401)
CapabilityRegistry_UpdateNodesTest:test_RevertWhen_SignerAddressEmpty() (gas: 31275)
CapabilityRegistry_UpdateNodesTest:test_RevertWhen_UpdatingNodeWithoutCapabilities() (gas: 31709)
CapabilityRegistry_UpdateNodesTest:test_UpdatesNodeInfo() (gas: 163467)
KeystoneForwarder_ReportTest:test_Report_SuccessfulDelivery() (gas: 133714)
KeystoneForwarder_ReportTest:test_RevertWhen_AnySignatureIsInvalid() (gas: 97790)
KeystoneForwarder_ReportTest:test_RevertWhen_AnySignerIsInvalid() (gas: 110159)
Expand Down
Loading
Loading