Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check on CI whether library compiles for no_std #431

Merged
merged 26 commits into from
Nov 1, 2023

Conversation

tomaka
Copy link
Contributor

@tomaka tomaka commented Apr 17, 2023

cc #133

This PR is a revival of paritytech/smoldot#1791

It is not expected to pass CI right now, but it is a long term objective that it does.

@tomaka tomaka marked this pull request as ready for review April 17, 2023 10:34
@tomaka tomaka marked this pull request as draft April 17, 2023 10:34
@tomaka
Copy link
Contributor Author

tomaka commented Apr 24, 2023

It seems that --no-default-features gets ignored when compiling from the root of the workspace. I'm pretty sure that's a cargo bug.

EDIT: actually no, it's really unclear and weird

@tomaka
Copy link
Contributor Author

tomaka commented Apr 24, 2023

Additionally, the features of the dev-dependencies are unfortunately leaking in the --lib build.

@tomaka
Copy link
Contributor Author

tomaka commented Apr 24, 2023

Additionally, the features of the dev-dependencies are unfortunately leaking in the --lib build.

This can be solved by building smoldot-light instead of smoldot, except for the fact that env_logger isn't no-std and that dev-dependencies can't be optional 😮‍💨

@tomaka
Copy link
Contributor Author

tomaka commented Jun 3, 2023

Additionally, the features of the dev-dependencies are unfortunately leaking in the --lib build.

Should be solved by #656

@tomaka tomaka added the blocked Progress on this issue requires something beyond our control label Aug 16, 2023
@tomaka
Copy link
Contributor Author

tomaka commented Sep 12, 2023

According to CI, the poly crate fails to compile for an unknown reason.
If it turns out to be a target-specific bug, I've seen people use thumbv7m-none-eabi instead.

@tomaka
Copy link
Contributor Author

tomaka commented Oct 28, 2023

I've just pushed a commit that overwrites the version of ruzstd from crates.io to use the GitHub version instead. I've done this because I would like to see if there is any other blocker. This should obviously be reverted before merging.

@tomaka
Copy link
Contributor Author

tomaka commented Nov 1, 2023

I'm going to merge this PR for the smoldot library, and open another one for smoldot-light.

@tomaka tomaka marked this pull request as ready for review November 1, 2023 13:28
@tomaka tomaka removed the blocked Progress on this issue requires something beyond our control label Nov 1, 2023
@tomaka tomaka enabled auto-merge November 1, 2023 13:53
@tomaka tomaka added this pull request to the merge queue Nov 1, 2023
Merged via the queue into smol-dot:main with commit c5ec15d Nov 1, 2023
@tomaka tomaka deleted the check-no-std-ci branch November 1, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant