Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check on CI whether library compiles for no_std #431

Merged
merged 26 commits into from
Nov 1, 2023
Merged
Changes from all commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
236183a
Check on CI whether library compiles for no_std
tomaka Apr 17, 2023
0e1f3e9
Update checkout action
tomaka Apr 17, 2023
d229ad5
Missing -Z unstable-options
tomaka Apr 17, 2023
43c4ae6
Merge branch 'main' into check-no-std-ci
tomaka Apr 17, 2023
a050c9a
Merge branch 'main' into check-no-std-ci
tomaka Apr 24, 2023
57e2b45
Merge branch 'main' into check-no-std-ci
tomaka Jun 3, 2023
8b011b6
Merge branch 'main' into check-no-std-ci
tomaka Jul 8, 2023
fc3fa91
Merge branch 'main' into check-no-std-ci
tomaka Jul 11, 2023
81421be
Also compile smoldot-light
tomaka Jul 11, 2023
48b1b0e
Merge branch 'main' into check-no-std-ci
tomaka Jul 11, 2023
178c158
Merge branch 'main' into check-no-std-ci
tomaka Aug 2, 2023
b04e83e
Merge branch 'main' into check-no-std-ci
tomaka Sep 12, 2023
80ae573
Update action a bit
tomaka Sep 12, 2023
ab2c4bb
Merge branch 'main' into check-no-std-ci
tomaka Oct 28, 2023
f9ace15
Overwrite ruzstd to try it out
tomaka Oct 28, 2023
5a0f7a4
Forgot default-features = false
tomaka Oct 28, 2023
0509bfa
Change target
tomaka Oct 28, 2023
95497af
Use a specific nightly
tomaka Oct 28, 2023
08ae172
Merge branch 'main' into check-no-std-ci
tomaka Oct 28, 2023
1c73112
Fix toolchain name
tomaka Oct 28, 2023
1c6c0de
Fix toolchain name again
tomaka Oct 28, 2023
1975495
Merge branch 'main' into check-no-std-ci
tomaka Oct 28, 2023
7d5fb0a
Try simplify the build
tomaka Oct 29, 2023
fe8eba1
--keep-going is unstable
tomaka Oct 29, 2023
879d081
Merge branch 'main' into check-no-std-ci
tomaka Oct 31, 2023
0aad5cd
Only check the smoldot library for now
tomaka Nov 1, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,17 @@ jobs:
- run: RUSTFLAGS=-Dwarnings cargo check --target x86_64-unknown-linux-gnu --package smoldot-light --locked --no-default-features --features std --features wasmtime
- run: RUSTFLAGS=-Dwarnings cargo check --target i686-unknown-linux-gnu --package smoldot-light --locked --no-default-features --features std --features wasmtime

check-no-std:
runs-on: ubuntu-latest
container:
image: rust:1.72
steps:
- uses: actions/checkout@v4
- run: rustup target add thumbv7m-none-eabi
- uses: Swatinem/rust-cache@v2
# We use `thumbv7m-none-eabi` as this target seems to generally work fine and doesn't support `std`. Many targets unfortunately have Rust/LLVM bugs preventing compilation.
- run: RUSTFLAGS=-Dwarnings cargo build --package smoldot --locked --no-default-features --target=thumbv7m-none-eabi

fuzzing-binaries-compile:
runs-on: ubuntu-latest
container:
Expand Down Expand Up @@ -206,7 +217,7 @@ jobs:
all-ci:
# This dummy job depends on all the mandatory checks. It succeeds if and only if CI is
# considered successful.
needs: [test-64bits, test-32bits, wasm-node-check, check-features, fuzzing-binaries-compile, check-rustdoc-links, fmt, clippy, cargo-deny, cargo-spellcheck, wasm-node-versions-match]
needs: [test-64bits, test-32bits, wasm-node-check, check-features, check-no-std, fuzzing-binaries-compile, check-rustdoc-links, fmt, clippy, cargo-deny, cargo-spellcheck, wasm-node-versions-match]
runs-on: ubuntu-latest
steps:
- run: echo Success