Set default-features = false for rustls #427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rukai
force-pushed
the
rustls-default-features-false
branch
from
1d4ac1f to
337de89
Compare
rukai
force-pushed
the
rustls-default-features-false
branch
from
337de89 to
4353021
Compare
daniel-abramov
approved these changes
Jun 1, 2024
|
That's unfortunate, our project won't be able to upgrade to 0.22 as is. up to you whether to release 0.23 now or later. We can continue running off a git dependency for a while longer if needed. |
This was referenced Jun 2, 2024
|
Done! I'm also going to publish |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before releasing 0.22, I believe we should change how we depend on rustls.
Since rustls swapped to having multiple backends, we need to set
default-features = falsefor rustls so that the user of tungstenite is free to choose the rustls backend.This is particularly important since the new default backend for rustls does not build in many environments due to older version of gcc.
This PR needs to land before 0.22 since its a breaking change.
The
stdfeature is enabled since it is enabled by default and required for tungstenite's rustls feature to compile at allThere is currently a PR open against tokio-tungstenite to do the same snapview/tokio-tungstenite#332
But without this PR the tokio-tungstenite PR will have no effect.