Feat/analyser node #242
Merged
Feat/analyser node #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…example folders and format
michalsek
approved these changes
Jan 20, 2025
|
|
||
| const Canvas: React.FC<PropsWithChildren> = ({ children }) => { | ||
| const [size, setSize] = useState<Size>({ width: 0, height: 0 }); | ||
| const [canvasPan] = useState<Position>({ x: 40, y: 0 }); |
There was a problem hiding this comment.
canvasPan can be removed (unless you want to use it later). I've planned to add pan & zoom effects to the spy app, but due to the bugs in mac catlyst+reanimated i've never finished that.
apps/common-app/src/examples/AudioVisualizer/AudioVisualizer.tsx
Outdated
Show resolved
Hide resolved
packages/react-native-audio-api/common/cpp/core/AnalyserNode.cpp
Outdated
Show resolved
Hide resolved
Co-authored-by: Maciej Makowski <[email protected]>
michalsek
reviewed
Jan 23, 2025
| public set fftSize(value: number) { | ||
| if (!AnalyserNode.allowedFFTSize.includes(value)) { | ||
| throw new IndexSizeError( | ||
| `Provided value (${value}) must be a power of 2 2^5 and 2^15` |
There was a problem hiding this comment.
Suggested change
| `Provided value (${value}) must be a power of 2 2^5 and 2^15` | |
| `Provided value (${value}) must be a power of 2 between 32 and 32768` |
* feat: some changes to the audio visualizer example * Update apps/common-app/src/examples/AudioVisualizer/Charts.tsx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #168
Introduced changes
AnalyserNodeFFTFrameAudioVisualizerexample using AnalyserNode(early version)Checklist