Skip to content
This repository was archived by the owner on Jan 24, 2025. It is now read-only.

Update Durable Nonces Course #450

Merged
merged 3 commits into from
Sep 24, 2024
Merged

Update Durable Nonces Course #450

merged 3 commits into from
Sep 24, 2024

Conversation

darkvallen
Copy link
Contributor

Problem

Summary of Changes

  • Updated code snippets
  • Use Partial signing for transactions with multiple signers.
  • Use getExplorerLink from solana-helpers for easier link generation.
  • Added the calculation for the exact rent-exempt balance using connection.getMinimumBalanceForRentExemption.
  • Added screenshots of successful test runs are included in the documentation.
  • Fixed grammar and styling
  • Fixed as per guidelines

Fixes #
Unboxed PRs
Unboxed-Software/solana-lab-durable-nonces#1

@darkvallen
Update Durable Nonces Course
9bc812e 
- Fix grammatical mistakes
- Partial signing for transactions with multiple signers.
- Use `getExplorerLink` from solana-helpers for easier link generation.
- Added the calculation for the exact rent-exempt balance using `connection.getMinimumBalanceForRentExemption`.
- Added screenshots of successful test runs are included in the documentation.
mikemaccana
mikemaccana suggested changes Sep 10, 2024
View reviewed changes
Copy link
Contributor

@mikemaccana mikemaccana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, a few minor bits but it's very clear you've read the contributing guidelines. Much appreciated, let's get this merged!

@darkvallen
Addressed review feedback
8ceec5f 
- Improved explanation of signatures to avoid circular logic
- Updated the "Considerations" section to maintain a consistent perspective
- Added detailed points to educate users on mitigating risks associated with durable nonce transactions
- Cleanup unnecessary word
- Fixed terminology: changed "off-chain" to "offchain" throughout the document
- Clarified terminology: changed `nonce account` to nonce account
@darkvallen
Merge pull request #1 from darkvallen/darkvallen-patch-1-resolved-review
689677f 
Addressed review feedback
@darkvallen
Copy link
Contributor Author

Great work, a few minor bits but it's very clear you've read the contributing guidelines. Much appreciated, let's get this merged!

Updated, Could you please review the updated "Considerations" section and let me know if it addresses your concerns?

@nickfrosty nickfrosty requested review from mikemaccana and removed request for nickfrosty September 11, 2024 13:44
@mikemaccana mikemaccana mentioned this pull request Sep 12, 2024
Closed
@mikemaccana mikemaccana merged commit 6a3b562 into solana-foundation:main Sep 24, 2024
2 checks passed
@mikemaccana
Copy link
Contributor

Marked as winner, congrats!

@mikemaccana
Copy link
Contributor

mikemaccana commented Sep 24, 2024 •
edited
Loading

Also @darkvallen: for https://github.com/Unboxed-Software/solana-lab-durable-nonces can you please make your changes to the solution branch, not new-solution? Also please update starter branch if necessary.

Reply here once done.

@darkvallen
Copy link
Contributor Author

Also @darkvallen: for https://github.com/Unboxed-Software/solana-lab-durable-nonces can you please make your changes to the solution branch, not new-solution? Also please update starter branch if necessary.

Reply here once done.

Thanks @mikemaccana! A new learning experience for me.

Done Unboxed-Software/solana-lab-durable-nonces#4 here's the solution branch PR.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mikemaccana mikemaccana mikemaccana approved these changes

Assignees
No one assigned
Labels
superteam-lesson-updates superteam-winner
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@darkvallen @mikemaccana