Minor fixes #1
Open
Minor fixes #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remram44
commented
Nov 6, 2020
| @@ -38,61 +34,61 @@ def id_generator(size=15): | |||
| """Helper function to generate random div ids. This is useful for embedding | |||
| HTML into ipython notebooks.""" | |||
| chars = list(string.ascii_uppercase) | |||
| return ''.join(np.random.choice(chars, size, replace=True)) | |||
| return ''.join(random.choices(chars, k=size)) | |||
There was a problem hiding this comment.
This is the only use of numpy, so I thought I'd remove it, even though datamart-profiler depends on numpy anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had started integrating this in datamart-profiler but you said you were working on it so I'll wait.
In the meantime here are some cleanup commits I had on my branch, that have nothing to do with the integration.
In particular I found that many dependencies were no longer used, which means hopefully we won't be adding dependencies to datamart-profiler to support the interactive widget!