[chassis][voq] Fix to ignore duplicate nexthop in zebra #16275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <[email protected]>
|
@saksarav-nokia @rlhui for viz... |
|
@arlakshm did we confirm after this patch issue is not seen in regression of config reload ? |
hasan-brcm
reviewed
Aug 29, 2023
src/sonic-frr/patch/0021-zebra-remove-duplicated-nexthops-when-sending-fpm-msg.patch
Show resolved
Hide resolved
Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <[email protected]>
@abdosi, we have not seen any issue with config reload so far in the testing @saksarav-nokia, were you able to test which this change. Any issue found? |
hasan-brcm
approved these changes
Aug 30, 2023
Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <[email protected]>
gechiang
approved these changes
Aug 30, 2023
Yes. We tested the fix while ago when the FRR team suggested this patch and we didn't see the crash |
gechiang
approved these changes
Aug 31, 2023
lguohan
approved these changes
Aug 31, 2023
|
@arlakshm PR conflicts with 202205 branch |
|
@arlakshm PR conflicts with 202211 branch |
11 tasks
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Sep 3, 2023
) Why I did it Fixes sonic-net#15803 In SONiC chassis, routes have recursive nexthop resolution when the routes are learnt from remote linecard. In some cases after recursive nexthop resolution the number of nexthop for a route could reach 256. Zebra ran out of space when filling up 256 nexthops which causes zebra crash. Work item tracking Microsoft ADO (24997365): How I did it Create a patch to port FRRouting/frr#14096 which has change to ignore duplicate nexthop when filling up fpm message Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <[email protected]>
|
Cherry-pick PR to 202305: #16420 |
11 tasks
mssonicbld
added a commit
that referenced
this pull request
Sep 3, 2023
mssonicbld
added
Included in 202305 Branch
and removed
Created PR to 202305 Branch
labels
sonic-otn
pushed a commit
to sonic-otn/sonic-buildimage
that referenced
this pull request
Sep 20, 2023
) Why I did it Fixes sonic-net#15803 In SONiC chassis, routes have recursive nexthop resolution when the routes are learnt from remote linecard. In some cases after recursive nexthop resolution the number of nexthop for a route could reach 256. Zebra ran out of space when filling up 256 nexthops which causes zebra crash. Work item tracking Microsoft ADO (24997365): How I did it Create a patch to port FRRouting/frr#14096 which has change to ignore duplicate nexthop when filling up fpm message Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Fixes #15803
In SONiC chassis, routes have recursive nexthop resolution when the routes are learnt from remote linecard.
In some cases after recursive nexthop resolution the number of nexthop for a route could reach
256.Zebra ran out of space when filling up 256 nexthops which causes zebra crash.
Work item tracking
How I did it
Create a patch to port FRRouting/frr#14096 which has change to ignore duplicate nexthop when filling up fpm message
How to verify it
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)