enable test_link_down on t0 and t1 devices #13582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The committers listed above are authorized under a signed CLA. |
wenyiz2021
approved these changes
Jul 6, 2024
|
/azpw |
|
@arlakshm could you help merge this PR? |
arlakshm
approved these changes
Jul 11, 2024
wenyiz2021
added
Request for 202305 branch
Request for 202311 branch
and removed
Request for 202205 branch
labels
8 tasks
arista-hpandya
pushed a commit
to arista-hpandya/sonic-mgmt
that referenced
this pull request
Oct 2, 2024
Approach What is the motivation for this PR? Fill the test gap. How did you do it? Change the test script How did you verify/test it? I tested it on T0, T1 and T2 DUTs in Microsoft's internal testbed and the new script works fine.
apoorv-arista
added a commit
to apoorv-arista/sonic-mgmt
that referenced
this pull request
Feb 27, 2025
…ches All testcases in this module were recently enabled for non-T2 topologies in sonic-net#13582 platform_tests/test_link_down.py::test_link_down_on_sup_reboot is still meant to be run on a modular chassis which reboots supervisor and then checks the port status on all linecards. However this ends up running on all multidut topologies due to this check: https://github.com/sonic-net/sonic-mgmt/blob/202411/tests/platform_tests/test_link_down.py#L152-L153 which includes dualTor where every duthost is a standalone device as compared to being a unit in chassis. Proposed fix is to skip this test on all non-T2 topologies using conditional mark.
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue) 11671
This PR is used to enable the test_link_down script to test SONiC T0 and T1 devices. There was only one line of code change made to tests/platform_tests/test_link_down.py.
Type of change
Back port request
Approach
What is the motivation for this PR?
Fill the test gap.
How did you do it?
Change the test script
How did you verify/test it?
I tested it on T0, T1 and T2 DUTs in Microsoft's internal testbed and the new script works fine.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation