Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable test_link_down on t0 and t1 devices #13582

Merged

Conversation

BYGX-wcr
Copy link
Contributor

@BYGX-wcr BYGX-wcr commented Jul 5, 2024

Description of PR

Summary:
Fixes # (issue) 11671
This PR is used to enable the test_link_down script to test SONiC T0 and T1 devices. There was only one line of code change made to tests/platform_tests/test_link_down.py.

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 202012
  • 202205
  • 202305
  • 202311
  • 202405

Approach

What is the motivation for this PR?

Fill the test gap.

How did you do it?

Change the test script

How did you verify/test it?

I tested it on T0, T1 and T2 DUTs in Microsoft's internal testbed and the new script works fine.

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@BYGX-wcr BYGX-wcr requested a review from prgeor as a code owner July 5, 2024 20:43
Copy link

linux-foundation-easycla bot commented Jul 5, 2024

CLA Signed


The committers listed above are authorized under a signed CLA.

@BYGX-wcr BYGX-wcr requested review from wenyiz2021 and removed request for prgeor July 5, 2024 20:44
@wenyiz2021
Copy link
Contributor

/azpw

Copy link
Contributor

@wenyiz2021 wenyiz2021 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wenyiz2021 wenyiz2021 requested a review from arlakshm July 11, 2024 17:14
@wenyiz2021
Copy link
Contributor

@arlakshm could you help merge this PR?

@arlakshm arlakshm merged commit 975868d into sonic-net:master Jul 11, 2024
17 checks passed
@BYGX-wcr BYGX-wcr deleted the extend_test_link_down_to_all_topo branch July 11, 2024 17:36
arista-hpandya pushed a commit to arista-hpandya/sonic-mgmt that referenced this pull request Oct 2, 2024
Approach
What is the motivation for this PR?
Fill the test gap.

How did you do it?
Change the test script

How did you verify/test it?
I tested it on T0, T1 and T2 DUTs in Microsoft's internal testbed and the new script works fine.
@rlhui rlhui added the Test gap label Nov 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants