turf war subgamemode

[deltanedas]

About the PR

depends on:

• spray painter rework #23287
• add TryGetPrimaryDepartment to jobs system #23317
• turf war design doc docs#118

turf war subgamemode has a chance to start in nukies, tator, rev, zombie (half of thief, can combine with it )

todo:

• greeting sound if someone finds a good sound idfk
• make sure it doesnt let turf taggers get picked for tator later in the round nfi how it works now

Why / Balance

see doc

currently the doors are balanced to heavily favour civilian roundstart since every hallway and maint door will count towards them, but they are accessible to everyone so highly contested. everyone will have plenty of opportunity to take over their maints and halls so it will quickly vanish without strong opposition from the tide

Technical details

• replaced thief sub gamemode logic with actual SubGamemodes which can specify any gamerules with a chance of being added, way more flexible than before

• it happens at add time so it behaves nicely
  subgamemodes log it nicely so you can see exactly why a rule is added
  

• players are sorted by department then departments have a player randomly picked to tag turf for it

• at roundstart turf taggers get a spray painter and epic bandana

• turf taggers go doing their thing and spraying any doors they see with their own colours

• on round end checks a station's paintable airlocks for a Department thats in the turf war

• whoever has most doors sprayed wins

• objective stats are cached for 10s to prevent trolling

• added AntagPoolGrouping to control whether a rule uses normal or departmental picking of sessions

Media

on traitor preset, thief still works

crewmate bandana + spray painter

greentext

redtext engibros

objective greentext wtf

objective isnt shown in roundend since its just for players to track their progress

briefing explicitly says the department

• I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

probably no

Changelog
🆑

• add: Turf wars can now occur, where people are tasked with coloring the most doors possible into the color of their department.

[GoodWheatley]

Splatoon in ss14????? Holy hell

[deltanedas]

are you a rider (c# refe) or a tider (ss14 refenr)

[Ilya246]

also someone with a brain please come up with good cl to steal mine is bad

"turf wars can now occur, where people are tasked with coloring the most doors possible into the color of their department"

[BYONDFuckery]

Gang mode real :godo:

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[Piras314]

I'd like to note that in the design doc it's stated "Since cap and hop don’t govern individual departments, they can’t be picked.", however HoP governs over Service.

[deltanedas]

in docs comments, there is no service department its just Civilian and hop doesnt lead the tiders so it would be bad

[Piras314]

give the tiders their own department then :clueless:

[deltanedas]

wyci...

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[deltanedas]

erm what the gleep

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[tutoumi]

mmmh, it has been a while now, will this ever merge ?