FTL coordinate disk command for admins: ftldisk #28075

IProduceWidgets · 2024-05-16T14:37:18Z

About the PR

Expand NanoTrasen's dominion over all ~~time and~~ space once more.

Why / Balance

Let the admins play with shuttles across multiple maps with less micromanagement.

Technical details

Takes a list of EntIDs, checks if theyre a map, if they aren't, finds the map they are on, then makes sure the map is setup as a destination, and finally spawns a disk setup for the map.

Media

I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

:ADMIN:

add: new command "ftldisk [EntID]" to make coordinate disks for shuttles to go to other maps.

This reverts commit b6be6b6.

IProduceWidgets · 2024-05-16T14:38:12Z

Okay i cooked my master branch a bit apparently, but its fiiiiine, it'll squash.

0x6273 · 2024-05-16T14:47:49Z

IConsoleCommand is deprecated. Use toolshed for new commands.

IProduceWidgets · 2024-05-16T14:50:23Z

IConsoleCommand is deprecated. Use toolshed for new commands.

I thought this was backtracked?

moonheart08 · 2024-05-30T16:42:13Z

IConsoleCommand is deprecated. Use toolshed for new commands.

I thought this was backtracked?

Not serverside. Use toolshed for this.

TheDoctor1977 · 2024-06-08T04:03:03Z

Is this still being worked on?

metalgearsloth

Needs updating to code standards for commands.
Needs a completion helper.

IProduceWidgets · 2024-06-23T01:42:50Z

Needs a completion helper.

Needs updating to code standards for commands.

I've looked at this for a couple weeks, and I have no idea what you mean lmao.

IProduceWidgets · 2024-06-23T01:46:09Z

I swapped from "Map Id" -> "Map netId" since we have two schemas

0x6273 · 2024-06-23T02:11:50Z

Needs updating to code standards for commands.

I've looked at this for a couple weeks, and I have no idea what you mean lmao.

For new commands the standard is to use toolshed, unless there's a specific reason you need to use the old command system.

Do you need any help with porting this to toolshed?

IProduceWidgets · 2024-06-23T02:15:59Z

Needs updating to code standards for commands.

I've looked at this for a couple weeks, and I have no idea what you mean lmao.

For new commands the standard is to use toolshed, unless there's a specific reason you need to use the old command system.

Do you need any help with porting this to toolshed?

If you want to be my guest. I looked into it a bit, and it seems it will need engine stuff I do not want to do, and every time I ask about it I get conflicting direction.

Content.Server/Shuttles/Commands/FTLDiskBurnerCommand.cs

Chief-Engineer · 2024-07-01T02:08:52Z

To my knowledge, we aren't requiring new commands to be toolshed commands, even if they're entirely serverside

Chief-Engineer

I jumped between the "since my last review" and "all changes" views and github seemed to not like that, so apologies if anything ended up a bit messy

Content.Server/Shuttles/Commands/FTLDiskBurnerCommand.cs

IProduceWidgets · 2024-07-01T21:03:20Z

There are 3 issues you may encounter with the command, but they aren't issues with the command so much as they are issues with maps which haven't mattered until now.
I'm going to try to fix them in separate PRs, but I'll list them here for reference.

The FTL map can't be FTL'ed to, probably due to the FTL console/system thinking that's a dumb idea (it kinda is, but idk maybe you want to do warp speed pirates or something).
Centcom has the FTLDestinationComponent, but its not setup properly and needs to have the component's Enabled and RequireCoordinatesDisk fields set to true. Its also got a generic "Map Entity" name for the map.
-> Done at Centcom & FTLDestination cleanup #30226
Gateway Destination maps need to spawn and name an FTL point along with the gateway entity. They're surprisingly hard to get to and require a lot of fiddling with F3 or the lsmap command to tp to them to place it yourself. It does work if you do that though.

But don't worry! This just works tm for new maps you create and initialize or for your admin test area. So you could for example use this to have two stations on different maps and let the players ferry themselves between them via FTL.

outdated

SlamBamActionman

I've looked through this PR now and it seems to work as intended. Sometimes it seems like I need to add FTLdestination component to the target map or make edits to the beacons, but I feel that's something which could end up in some documentation rather than the command itself.

Don't worry about FTLing to the FTL map, as that should probably be off-limits. The parallax scrolling is caused by ships moving through it anyways, so you can't have a constant scroll just by being on the map.

Let me know once you've addressed the requested changes!

Content.Server/Shuttles/Commands/FTLDiskBurnerCommand.cs

SlamBamActionman · 2024-10-15T21:10:23Z

Content.Server/Shuttles/Commands/FTLDiskBurnerCommand.cs

+    public override CompletionResult GetCompletion(IConsoleShell shell, string[] args)
+    {
+        if (args.Length >= 1)
+            return CompletionResult.FromHintOptions(CompletionHelper.MapUids(_entManager), "Map netId");


Double-check that this completion works with the current master; it seemed to me like it stopped working after merging master into my test PR branch.

The completion works, someone just messed up the helper in engine so it returns null
space-wizards/RobustToolbox@26b0928#diff-fcc1817dc485c3ac2fc001b91638163a3c8e4b37a75ce4a474840e83028ac44eL147

Can't fix it here. Has to be fixed in engine. Doesn't stop the command from working though.

Made an engine PR to fix it, but I wouldn't hold this up on account of that. Its just a help text.
space-wizards/RobustToolbox#5495

Content.Server/Shuttles/Commands/FTLDiskBurnerCommand.cs

SlamBamActionman

Looks good to me!

SlamBamActionman

Slart pointed out that the command should have localization to the error messages, so that has to be fixed first. Testing works well though 👍

Resources/Locale/en-US/shuttles/commands.ftl

Content.Server/Shuttles/Commands/FTLDiskCommand.cs

IProduceWidgets · 2024-10-16T15:50:43Z

Localized

* Add robo control comp, also de-reinforce a lot of walls. * Revert "Add robo control comp, also de-reinforce a lot of walls." This reverts commit b6be6b6. * FTLdiskburner command to make FTL disks. * Elegant failure on mistyped ID. * even more more eleganter failures. * foo * bar * I have reached completion * prevent id confusion * I'm givin' her all she's got captain! * a bit more hug boxing for safe destinations. * comments for foo * extra thoughts. * cleanup * continuen't * Improve feedback strings * reviewer QOL * Reviewer QOL 2 * handle easy reviews * Add comments to clarify reviews * howdoicode to the rescue. * ftldisk in hand * ftl.ftl * funny disk case * loc * unusing

IProduceWidgets added 3 commits May 13, 2024 17:38

Add robo control comp, also de-reinforce a lot of walls.

b6be6b6

Revert "Add robo control comp, also de-reinforce a lot of walls."

5833521

This reverts commit b6be6b6.

FTLdiskburner command to make FTL disks.

18528f9

Elegant failure on mistyped ID.

f649ba9

even more more eleganter failures.

8fe95e2

IProduceWidgets added 3 commits May 16, 2024 10:56

foo

429d5ab

bar

4cce97f

Merge branch 'master' into FTLdiskburner

274a24f

metalgearsloth previously requested changes Jun 8, 2024

View reviewed changes

metalgearsloth added the S: Awaiting Changes Status: Changes are required before another review can happen label Jun 8, 2024

I have reached completion

b3d9570

prevent id confusion

ed843a9

IProduceWidgets requested a review from metalgearsloth June 23, 2024 11:07

github-actions bot added S: Needs Review Status: Requires additional reviews before being fully accepted and removed S: Awaiting Changes Status: Changes are required before another review can happen labels Jun 23, 2024

Chief-Engineer suggested changes Jul 1, 2024

View reviewed changes

Content.Server/Shuttles/Commands/FTLDiskBurnerCommand.cs Outdated Show resolved Hide resolved

Content.Server/Shuttles/Commands/FTLDiskBurnerCommand.cs Outdated Show resolved Hide resolved

Content.Server/Shuttles/Commands/FTLDiskBurnerCommand.cs Outdated Show resolved Hide resolved

Chief-Engineer added S: Awaiting Changes Status: Changes are required before another review can happen and removed S: Needs Review Status: Requires additional reviews before being fully accepted labels Jul 1, 2024

IProduceWidgets added 2 commits July 1, 2024 03:00

I'm givin' her all she's got captain!

0248a93

a bit more hug boxing for safe destinations.

0316bee

IProduceWidgets added 4 commits July 1, 2024 06:17

continuen't

7e42248

Improve feedback strings

526b48e

reviewer QOL

b90e0d3

Reviewer QOL 2

627de80

Chief-Engineer previously requested changes Jul 1, 2024

View reviewed changes

IProduceWidgets added 3 commits July 1, 2024 13:40

handle easy reviews

6f0805b

Add comments to clarify reviews

8faf165

howdoicode to the rescue.

84cabc2

Chief-Engineer added S: Needs Review Status: Requires additional reviews before being fully accepted and removed S: Awaiting Changes Status: Changes are required before another review can happen labels Jul 1, 2024

IProduceWidgets mentioned this pull request Jul 21, 2024

Centcom & FTLDestination cleanup #30226

Merged

1 task

SlamBamActionman requested changes Oct 15, 2024

View reviewed changes

SlamBamActionman self-assigned this Oct 15, 2024

IProduceWidgets added 3 commits October 15, 2024 23:12

ftldisk in hand

2575bda

ftl.ftl

4d13849

Merge branch 'master' into FTLdiskburner

106e7bb

IProduceWidgets changed the title ~~FTL coordinate disk command for admins: FTLdiskburner~~ FTL coordinate disk command for admins: ftldisk Oct 16, 2024

IProduceWidgets requested a review from SlamBamActionman October 16, 2024 05:10

funny disk case

277827e

SlamBamActionman approved these changes Oct 16, 2024

View reviewed changes

SlamBamActionman requested changes Oct 16, 2024

View reviewed changes

IProduceWidgets added 2 commits October 16, 2024 11:48

loc

eacfcf1

unusing

86a0d31

SlamBamActionman approved these changes Oct 16, 2024

View reviewed changes

SlamBamActionman merged commit 05ac74d into space-wizards:master Oct 16, 2024
11 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

FTL coordinate disk command for admins: ftldisk #28075

FTL coordinate disk command for admins: ftldisk #28075

IProduceWidgets commented May 16, 2024 •

edited

Loading

IProduceWidgets commented May 16, 2024

0x6273 commented May 16, 2024

IProduceWidgets commented May 16, 2024

moonheart08 commented May 30, 2024

TheDoctor1977 commented Jun 8, 2024

metalgearsloth left a comment

IProduceWidgets commented Jun 23, 2024 •

edited

Loading

IProduceWidgets commented Jun 23, 2024 •

edited

Loading

0x6273 commented Jun 23, 2024

IProduceWidgets commented Jun 23, 2024

Chief-Engineer commented Jul 1, 2024

Chief-Engineer left a comment

IProduceWidgets commented Jul 1, 2024 •

edited

Loading

SlamBamActionman left a comment

SlamBamActionman Oct 15, 2024

IProduceWidgets Oct 16, 2024 •

edited

Loading

IProduceWidgets Oct 16, 2024

SlamBamActionman left a comment

SlamBamActionman left a comment

IProduceWidgets commented Oct 16, 2024

FTL coordinate disk command for admins: ftldisk #28075

FTL coordinate disk command for admins: ftldisk #28075

Conversation

IProduceWidgets commented May 16, 2024 • edited Loading

About the PR

Why / Balance

Technical details

Media

Breaking changes

IProduceWidgets commented May 16, 2024

0x6273 commented May 16, 2024

IProduceWidgets commented May 16, 2024

moonheart08 commented May 30, 2024

TheDoctor1977 commented Jun 8, 2024

metalgearsloth left a comment

Choose a reason for hiding this comment

IProduceWidgets commented Jun 23, 2024 • edited Loading

IProduceWidgets commented Jun 23, 2024 • edited Loading

0x6273 commented Jun 23, 2024

IProduceWidgets commented Jun 23, 2024

Chief-Engineer commented Jul 1, 2024

Chief-Engineer left a comment

Choose a reason for hiding this comment

IProduceWidgets commented Jul 1, 2024 • edited Loading

SlamBamActionman left a comment

Choose a reason for hiding this comment

SlamBamActionman Oct 15, 2024

Choose a reason for hiding this comment

IProduceWidgets Oct 16, 2024 • edited Loading

Choose a reason for hiding this comment

IProduceWidgets Oct 16, 2024

Choose a reason for hiding this comment

SlamBamActionman left a comment

Choose a reason for hiding this comment

SlamBamActionman left a comment

Choose a reason for hiding this comment

IProduceWidgets commented Oct 16, 2024

IProduceWidgets commented May 16, 2024 •

edited

Loading

IProduceWidgets commented Jun 23, 2024 •

edited

Loading

IProduceWidgets commented Jun 23, 2024 •

edited

Loading

IProduceWidgets commented Jul 1, 2024 •

edited

Loading

IProduceWidgets Oct 16, 2024 •

edited

Loading