sleeper agent fake announcement #28321

icekot8 · 2024-05-27T17:11:30Z

About the PR

this PR adds a CanFalseActivate field to the GameRuleComponent, nuke the evil AlertLevelInterceptionRule by moving it to a nicer place and adds CanFalseActivate = true to the sleeping agents event

Why / Balance

fixes part of #28016
I'm tired of two agents in every round🤏.

Technical details

I tried to implement CanFalseActivate at the StationEvent level, but failed.
CanFalseActivate == a simple skip of executing game rules.
Seeing the AlertLevelInterceptionRule made me want to cry at the amount of code for 2 separate files and hardcore “green”... and it interfered with the implementation of CanFalseActivate, alas.
The AlertLevelInterceptionRule was nicely shoved into StationEvent
the sleeping agents event collapsed due to the lack of at least 1 rule there and I gave it MassHallucinationsRule , which basically shouldn't work because of duration: 0, but in any case, aggravating paracusia due to enemy communications sounds logical to me

at this moment, the event, if CanFalseActivate = true, throws the switch function, which with a 50% probability writes in the logs that the event triggered falsely, enrolling occurrences and skipping everything except StationEvent comp.

Media

I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog

🆑

tweak: Sleeper Agents can cause false announcements

Dutch-VanDerLinde · 2024-05-27T17:22:52Z

thank u

Brandon-Huu · 2024-05-27T20:39:56Z

Content.Server/GameTicking/GameTicker.GameRule.cs

+        	switch (i)
+        	{
+        	    case 1:
+        	        break;
+        	    case 2:
+        	    {
+        	        _adminLogger.Add(LogType.EventStarted, LogImpact.High, $"Event fake started: {ToPrettyString(ruleEntity)}");
+                    EndGameRule(ruleEntity, ruleData);
+        	        return false;
+        	    }
+        	}


What the fuck is this?

Cojoke-dot · 2024-05-27T21:25:35Z

Is this not already a thing? I thought the sleeper agent could roll on 0 people... (if it can't... there's an idea)

Content.Server/StationEvents/Components/StationEventComponent.cs

EmoGarbage404 · 2024-05-27T21:49:44Z

Resources/Prototypes/GameRules/events.yml

    maxOccurrences: 1 # can only happen once per round
    startAnnouncement: station-event-communication-interception
    startAudio:
      path: /Audio/Announcements/intercept.ogg
-  - type: AlertLevelInterceptionRule
+  - type: MassHallucinationsRule # essentially (I hope) does nothing because of duration 0. it's just so that the event can complete, since removing "AlertLevelInterceptionRule" caused a problem with it 


what

as has already been written, this is the solution to the problem.
If you remove it, this happens

- type: entity noSpawn: true parent: BaseTraitorRule id: SleeperAgentsRule components: - type: GameRule canFalseActivate: true - type: StationEvent earliestStart: 30 weight: 8 minimumPlayers: 15 alertLevel: blue maxOccurrences: 1 # can only happen once per round startAnnouncement: station-event-communication-interception startAudio: path: /Audio/Announcements/intercept.ogg - type: AntagSelection definitions: - prefRoles: [ Traitor ] min: 1 max: 2 playerRatio: 10 mindComponents: - type: TraitorRole prototype: Traitor

if add any rule

- type: entity noSpawn: true parent: BaseTraitorRule id: SleeperAgentsRule components: - type: GameRule canFalseActivate: true - type: StationEvent earliestStart: 30 weight: 8 minimumPlayers: 15 alertLevel: blue maxOccurrences: 1 # can only happen once per round startAnnouncement: station-event-communication-interception startAudio: path: /Audio/Announcements/intercept.ogg - type: MassHallucinationsRule # essentially (I hope) does nothing because of duration 0. it's just so that the event can complete, since removing "AlertLevelInterceptionRule" caused a problem with it minTimeBetweenIncidents: 0.1 maxTimeBetweenIncidents: 300 maxSoundDistance: 7 sounds: collection: Paracusia - type: AntagSelection definitions: - prefRoles: [ Traitor ] min: 1 max: 2 playerRatio: 10 mindComponents: - type: TraitorRole prototype: Traitor

I don't think adding null rule to solve my problem is a good idea.
MassHallucinationsRule was used since this rule will not work for the player due to the fact that the duration of SleeperAgentsRule = 0

icekot8 · 2024-05-28T06:12:46Z

yaml linter is angry but in game and console everything is fine 🤏(I don't understand what the problem is)

github-actions · 2024-06-01T20:51:58Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions · 2024-06-04T12:42:34Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions · 2024-06-30T14:04:55Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

icekot8 · 2024-07-03T14:20:58Z

I finished this.
Unfortunately, I had to resort to a system that literally just calls start for StationEventSystem.
but, uh, it works.
and I fixed the hardcoded bool.

TheShuEd

fix tests

github-actions · 2024-08-05T04:01:53Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

bruhmogus · 2024-09-23T02:01:38Z

"fuck you"
unconfirms your station threat

slarticodefast · 2024-10-09T04:25:36Z

If you are coming back to this, leave a comment and I will re-open the PR.

nuke, code and

0fe253c

icekot8 requested a review from EmoGarbage404 as a code owner May 27, 2024 17:11

github-actions bot added the S: Needs Review Status: Requires additional reviews before being fully accepted label May 27, 2024

Brandon-Huu reviewed May 27, 2024

View reviewed changes

EmoGarbage404 requested changes May 27, 2024

View reviewed changes

AJCM-git added S: Awaiting Changes Status: Changes are required before another review can happen and removed S: Needs Review Status: Requires additional reviews before being fully accepted labels May 28, 2024

friendly protoid 😍 and sweet code 🎧

858675e

icekot8 requested a review from EmoGarbage404 May 28, 2024 06:27

github-actions bot added S: Needs Review Status: Requires additional reviews before being fully accepted and removed S: Awaiting Changes Status: Changes are required before another review can happen labels May 28, 2024

VasilisThePikachu mentioned this pull request May 29, 2024

Syndicate sleeper (#27501) still needs work #28016

Open

5 tasks

github-actions bot added the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Jun 1, 2024

Merge branch 'master' into canFalseActivateGameRule

e2d3c78

github-actions bot removed the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Jun 2, 2024

Merge branch 'space-wizards:master' into canFalseActivateGameRule

19fdad4

github-actions bot added the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Jun 4, 2024

icekot8 added 4 commits June 5, 2024 09:43

🎈

641b022

maybe..

e14ebd6

finally?..

c52d0ef

i obviously needed to sleep..

437503d

github-actions bot removed the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Jun 5, 2024

icekot8 and others added 2 commits June 5, 2024 09:52

Merge branch 'space-wizards:master' into canFalseActivateGameRule

664ed7a

revert

3c7a551

github-actions bot added the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Jun 30, 2024

Merge branch 'master' into canFalseActivateGameRule

88fd24c

github-actions bot removed the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Jul 2, 2024

icekot8 marked this pull request as draft July 2, 2024 06:19

icekot8 and others added 2 commits July 3, 2024 17:12

:bomb

a416ba2

💣 2

3f6d4e7

icekot8 marked this pull request as ready for review July 3, 2024 14:21

TheShuEd requested changes Jul 16, 2024

View reviewed changes

TheShuEd added S: Awaiting Changes Status: Changes are required before another review can happen and removed S: Needs Review Status: Requires additional reviews before being fully accepted labels Jul 16, 2024

github-actions bot added the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Aug 5, 2024

slarticodefast closed this Oct 9, 2024

slarticodefast added the S: Derelict Status: Abandoned, but may contain something that can be salvaged. label Oct 9, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

sleeper agent fake announcement #28321

sleeper agent fake announcement #28321

icekot8 commented May 27, 2024

Dutch-VanDerLinde commented May 27, 2024

Brandon-Huu May 27, 2024

Cojoke-dot commented May 27, 2024

EmoGarbage404 May 27, 2024

icekot8 May 28, 2024

icekot8 commented May 28, 2024

github-actions bot commented Jun 1, 2024

github-actions bot commented Jun 4, 2024

github-actions bot commented Jun 30, 2024

icekot8 commented Jul 3, 2024

TheShuEd left a comment

github-actions bot commented Aug 5, 2024

bruhmogus commented Sep 23, 2024

slarticodefast commented Oct 9, 2024

sleeper agent fake announcement #28321

sleeper agent fake announcement #28321

Conversation

icekot8 commented May 27, 2024

About the PR

Why / Balance

Technical details

Media

Dutch-VanDerLinde commented May 27, 2024

Brandon-Huu May 27, 2024

Choose a reason for hiding this comment

Cojoke-dot commented May 27, 2024

EmoGarbage404 May 27, 2024

Choose a reason for hiding this comment

icekot8 May 28, 2024

Choose a reason for hiding this comment

icekot8 commented May 28, 2024

github-actions bot commented Jun 1, 2024

github-actions bot commented Jun 4, 2024

github-actions bot commented Jun 30, 2024

icekot8 commented Jul 3, 2024

TheShuEd left a comment

Choose a reason for hiding this comment

github-actions bot commented Aug 5, 2024

bruhmogus commented Sep 23, 2024

slarticodefast commented Oct 9, 2024