Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Slowdown to Dragging Items that Slow when Held #29364

Merged
merged 5 commits into from
Jul 1, 2024

Conversation

Cojoke-dot
Copy link
Contributor

About the PR

Adds slowdown to dragging items that slow when held.

Why / Balance

Players walking around dragging hard suits and duffles to avoid the slow feels cheaty... so poof? No more avoiding slowdown from suits and duffles basically.

Technical details

RefreshMovementSpeedModifiers when pull starts and stops, add the item being pulled to the HeldRelayedEvent

Media

2024-06-22.19-23-31.mp4
  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

🆑

  • tweak: Items that slow down a person when held now slow down when dragged too.

Copy link
Contributor

@metalgearsloth metalgearsloth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't it easily just be put into a locker instead if they wanted?

@Cojoke-dot
Copy link
Contributor Author

Cojoke-dot commented Jun 23, 2024

Couldn't it easily just be put into a locker instead if they wanted?

Locker still slow the player and are blocked by objects around the station, people just dragging around a hardsuit can quick equip them by just clicking on them

2024-06-22.18-10-27.mp4

*I have no idea if this is a bug, I found it when making the pr

@metalgearsloth metalgearsloth added the S: Awaiting Changes Status: Changes are required before another review can happen label Jun 23, 2024
@lzk228
Copy link
Contributor

lzk228 commented Jun 23, 2024

nuuh make them at least half slowdown 😭😭

…lowdown

# Conflicts:
#	Content.Shared/Hands/EntitySystems/SharedHandsSystem.Relay.cs
@github-actions github-actions bot added S: Needs Review Status: Requires additional reviews before being fully accepted and removed S: Awaiting Changes Status: Changes are required before another review can happen labels Jun 23, 2024
@Kadeo64
Copy link
Contributor

Kadeo64 commented Jun 23, 2024

lizards in shambles

@metalgearsloth metalgearsloth added S: Awaiting Changes Status: Changes are required before another review can happen and removed S: Needs Review Status: Requires additional reviews before being fully accepted labels Jun 30, 2024
@github-actions github-actions bot added S: Needs Review Status: Requires additional reviews before being fully accepted and removed S: Awaiting Changes Status: Changes are required before another review can happen labels Jun 30, 2024
@deltanedas
Copy link
Contributor

you can just throw it

@thebadman4662
Copy link

you can just throw it

Apply slowdown for 10s after throwing it. :trollface:

@metalgearsloth metalgearsloth enabled auto-merge (squash) July 1, 2024 05:33
@metalgearsloth metalgearsloth merged commit 7555952 into space-wizards:master Jul 1, 2024
12 checks passed
@Cojoke-dot Cojoke-dot deleted the PullItemSlowdown branch July 1, 2024 07:17
@ps3moira
Copy link
Contributor

ps3moira commented Jul 1, 2024

you can just throw it

future PR where it takes up stamina to throw items :trollface:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S: Needs Review Status: Requires additional reviews before being fully accepted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants