Remove bad annotation from GasMinerSystem #29641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The NotNullWhen was making Rider's linter show an error
github-actions
bot
added
the
S: Needs Review
|
Thanks for the fix. This function used to return a bool and so that is why this is there. Since the only caller already does a null check (line 31) I agree that this is safe to remove. |
Partmedia
added
the
Changes: Atmospherics Code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The NotNullWhen was making Rider's linter show an error
I don't think it was applicable because CapSpawnAmount returns a float and NotNullWhen only deals with a boolean.