Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a new glass-producing plant to botany. #29679

Closed
wants to merge 11 commits into from

Conversation

jimmy12or
Copy link
Contributor

About the PR

Adds a glass producing plant and associated reagent.

Why / Balance

For a long time I wanted to be able to grow glass for many projects and departments to use.

Technical details

The Crystalthistle is a mutation of galaxythistle and creates a new reagent called Quartzite. When heated to a high temp 10u of quartzite will become one sheet of glass similar to how plastic can be made with chems. The plant also contains Ethyloxyephedrine since Stellibinin comes from galaxythistle, I thought it would be a good fit and make sure the plant can be grown partly for medical purposes as well since there are a lot of players that enjoy using the narcoleptic trait. Quartzite, if drank also acts as a less potent version of razorium (about 1/3 as painful).

Media

Screenshot 2024-07-02 231013
Screenshot 2024-07-02 231039
![Screenshot 2024-
Screenshot 2024-07-02 231226
07-02 231106](https://g
Screenshot 2024-07-02 231429
ithub.com/space-wizards/space-station-14/assets/47635328/18091e67-0718-42f2-b9ad-cdeedcd994f5)

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

None to my knowledge.

Changelog

🆑

  • add: A Crystalthistle, A new glass producing plant, and associated reagent, Quartzite!

@github-actions github-actions bot added Changes: No C# Changes: Requires no C# knowledge to review or fix this item. Changes: Sprites Changes: Might require knowledge of spriting or visual design. labels Jul 3, 2024
Copy link
Contributor

github-actions bot commented Jul 3, 2024

RSI Diff Bot; head commit 7336189 merging into a2a3233
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Objects/Specific/Hydroponics/crystal_thistle.rsi

State Old New Status
dead Added
harvest Added
produce Added
seed Added
stage-1 Added
stage-2 Added
stage-3 Added

Edit: diff updated after 7336189

@slarticodefast
Copy link
Member

This PR already adds the same thing: #28993
Welding it to create glass is better than adding an additional reagent only for this in my opinion. That way botany can make the glass without the help of chemistry (like for steelcaps).

@jimmy12or
Copy link
Contributor Author

This PR already adds the same thing: #28993 Welding it to create glass is better than adding an additional reagent only for this in my opinion. That way botany can make the glass without the help of chemistry (like for steelcaps).

I had made this before i knew that one existed and was shocked to see that it did. I do see the practicality of it, but it requires botany to either get a welding mask as well or oculine to prevent themselves from going permanently blind. The reagent in this one can also be heated up in a microwave which botany can often get use of.

I certainly see the benefits of theirs, and I will be happy to just get a glass growing plant one way or the other. In this case, I mostly made this PR because I had already put the work into it and it's my first one. So i wanted to see what people think of it.

@beck-thompson
Copy link
Contributor

beck-thompson commented Jul 3, 2024

In this case, I mostly made this PR because I had already put the work into it and it's my first one

Just FYI your PR is failing the tests! If you get a YML Linter test fail that means you messed something up. Click on "Details" to see the issue.
image

I looked at it and it appears that you just forgot a space on line 60 (-type: -> - type:)? I'm not the best with YML so there could also be other issues.
image

@HandsomeTheEgg
Copy link

this has some interesting syngergy since its a liquid that created glas...it could be used with the industrial grinder or other machines...and yea microwave works in case there is no chemist...it has its charm compared to welding each piece of broken glas to a glas sheet...and its much more friendly to use

@Sirionaut
Copy link
Contributor

Sirionaut commented Jul 4, 2024

I think there is also a problem with capitalization, which is why IntegrationTests fails

Error when validating server prototype (EntityPrototype, FoodCrystalthistle). Errors:

  • PrototypeID Crystalythistle for type Content.Server.Botany.SeedPrototype at Line: -1, Col: -1 not found

I think that's happening because in "Resources/Prototypes/Entities/Objects/Consumable/Food/produce.yml" it's capitalized, seedId: Crystalythistle.
but since it starts with a lower case c in seeds.yml it can't find it

@jimmy12or
Copy link
Contributor Author

I think there is also a problem with capitalization, which is why IntegrationTests fails

Error when validating server prototype (EntityPrototype, FoodCrystalthistle). Errors:

  • PrototypeID Crystalythistle for type Content.Server.Botany.SeedPrototype at Line: -1, Col: -1 not found

I think that's happening because in "Resources/Prototypes/Entities/Objects/Consumable/Food/produce.yml" it's capitalized, seedId: Crystalythistle. but since it starts with a lower case c in seeds.yml it can't find it

Thanks for pointing this out on it's own. even on your snippet of it, it's misspelled. For some odd reason it says "Crystalythistle" with an extra y in there when it's intended to be crystalthistle.

@github-actions github-actions bot added the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Jul 27, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@slarticodefast
Copy link
Member

#28993
Looks like the other glass thistle PR got merged, making this one redundant.
I still like the artwork you did, so I hope to see other ideas from you in the future.

@jimmy12or jimmy12or closed this Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: No C# Changes: Requires no C# knowledge to review or fix this item. Changes: Sprites Changes: Might require knowledge of spriting or visual design. S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants