A variant of a working capsule of nuke ops #29683

BeatusCrow · 2024-07-03T10:42:40Z

About the PR

In this PR, I propose an option that will make it possible to use a capsule located at the base of nuclear operatives

Why / Balance

This will give you the opportunity to storm the station with the help of new tactics... And it will be interesting.
There are two possible outcomes when using the capsule:

If war has been declared, then the capsule will move silently
If war has not been declared, then the threat level at the station will rise to red + central command will inform you about the movement and approximate coordinates of the capsule's arrival + the movement process will take 12 seconds

Technical details

The object for teleportation is determined by two beacons that are diagonally opposite. It is enough to place 2 points on the current base of nuclear operatives for everything to start working... But I still suggest the option of creating a new capsule, which will be located on tiles of the "plating" type, because this, taking into account my code, will not make it possible to teleport any boxes outside the capsule...

Media

the principle of operation at the Dev station -> https://youtu.be/mGeuRiaVxUc
demonstration of work at a conventional station and an outpost of nuclear operatives -> https://youtu.be/jIFw_PLnZnY

Breaking changes

Content.Server\NukeOps\WarDeclaratorSystem.cs

add: Added lines that change the operating mode of the nuclear operatives capsule to "silent"

Changelog

🆑 BeatusCrow

add: A working capsule of nuclear operatives
add: The ability to use this console for other teleportations (at the discretion of the admins)

Add DropPod

03.07.24

github-actions · 2024-07-03T10:43:15Z

RSI Diff Bot; head commit d7ea5e5 merging into 1faa1b5
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Markers/droppod.rsi

State	Old	New	Status
drop_pod_lighthouse			Added
drop_pod_point			Added
drop_pod_point_brig			Added
drop_pod_point_cap			Added
drop_pod_point_cargo			Added
drop_pod_point_eng			Added
drop_pod_point_med			Added
drop_pod_point_rd			Added
drop_pod_point_sal			Added

Resources/Textures/Objects/Specific/Syndicate/droppodconsole.rsi

State	Old	New	Status
console			Added
icon			Added

Edit: diff updated after d7ea5e5

Djungelskog2 · 2024-07-03T11:45:40Z

I think there needs to be a marker that appears to dictate where its landing so you dont get squashed
Also an explosion would be nice instead of a silent blip

Hrosts · 2024-07-03T11:56:49Z

Are there cuts in the videos? It looks like the teleportation is happening instantly (as opposed to the claimed 12 seconds) when you close the console window.

metalgearsloth

This shouldn't require manually mapping points and please read the conventions guide as a lot of this is out of date.

Hrosts · 2024-07-03T11:46:25Z

Content.Server/DropPod/DropPodLighthouseComponent.cs

+namespace Content.Server.DropPod
+{
+    [RegisterComponent]
+    public sealed partial class DropPodLighthouseComponent : Component


A lighthouse is a маяк which stands by the sea, you need beacon

Thanks for explaining. I fixed it.

Hrosts · 2024-07-03T11:48:46Z

Resources/Locale/en-US/droppod/dropod.ftl

@@ -0,0 +1,3 @@
+droppod-console-ui-window = DropPod Console
+droppod-console-ui-refresh-points = Update the list of landing points
+droppod-console-ui-start-landing = Start disembarking


Should be "Launch" or "Start launch sequence" or something similar. "Disembarking" is used for people, not objects.

I fixed it.

Hrosts · 2024-07-03T11:53:43Z

Content.Server/DropPod/DropPodConsoleComponent.cs

+        public bool Announcement = true;
+
+        [DataField("text")]
+        public string Text = "Attention! A hostile corporation is trying to move an object to your station... The travel time is 12 seconds. The approximate coordinates of the movement are as follows: ";


These kinds of announcements (e.g. Space Dragon rifts) now use the approximate location, as coordinates don't tell much to most players. Also I think such things usually go into ftl files, but I'm a dilettante in this.

So in this ad there will be an approximate location, because the exact coordinates will be determined later by adding a scatter radius

Yeah, this should use a LocId string.

Also, the time shouldn't be written into the string. It should be passed as a variable that can be placed in the string by the localization system.

BeatusCrow · 2024-07-03T12:21:29Z

Are there cuts in the videos? It looks like the teleportation is happening instantly (as opposed to the claimed 12 seconds) when you close the console window.

Look at the code. There, the time depends on the console component. The admin console has teleportation for only 1 second

BeatusCrow · 2024-07-03T12:34:58Z

I think there needs to be a marker that appears to dictate where its landing so you dont get squashed Also an explosion would be nice instead of a silent blip

So the situation with the crushed captain is more interesting... no?

Djungelskog2 · 2024-07-03T12:42:01Z

I think there needs to be a marker that appears to dictate where its landing so you dont get squashed Also an explosion would be nice instead of a silent blip

So the situation with the crushed captain is more interesting... no?

I just dont imagine it being fun for anyone aside from the nukies or ghosts at the very least, infuriating at most

BeatusCrow · 2024-07-03T13:10:30Z

I think there needs to be a marker that appears to dictate where its landing so you dont get squashed Also an explosion would be nice instead of a silent blip

So the situation with the crushed captain is more interesting... no?

I just dont imagine it being fun for anyone aside from the nukies or ghosts at the very least, infuriating at most

You're probably right. I'll add this

Hrosts · 2024-07-03T13:19:19Z

Look at the code. There, the time depends on the console component. The admin console has teleportation for only 1 second

Okay. I think the launch button should become permanently green/grey at launch, for better user feedback.

…of-Nuke-Ops Update dropod.ftl

Lighthouse -> Beacon

ps3moira · 2024-07-03T20:47:24Z

I love this, will there be a FTL phase and sound effects added to it in the future?

BeatusCrow · 2024-07-03T21:20:14Z

I love this, will there be a FTL phase and sound effects added to it in the future?

Actually, I wanted to add.

Catdere · 2024-07-09T15:55:00Z

Uh i dont know if this is still being worked on. But i think it would be a better idea to have its launch points be based on station beacons because they should be mapped onto every station and they make it very clear where youre going to land.

BeatusCrow · 2024-07-10T17:33:12Z

Uh i dont know if this is still being worked on. But i think it would be a better idea to have its launch points be based on station beacons because they should be mapped onto every station and they make it very clear where youre going to land.

I'm rewriting everything now and changing the way it works a little bit.

AverageNotDoingAnythingEnjoyer · 2024-11-01T20:04:41Z

So, uh, how's it going?

TheShuEd

Everything here uses extremely outdated code formats, and root system of DropPod's movement is extremely sus, and has no right to be merged into the master without a complete rewrite from scratch.

TheShuEd · 2024-12-23T12:29:30Z

Content.Server/DropPod/DropPodBeaconComponent.cs

+using Robust.Shared.Serialization.TypeSerializers.Implementations.Custom;
+using Robust.Shared.Serialization.TypeSerializers.Implementations.Custom.Prototype;
+
+namespace Content.Server.DropPod


outdated namespace format

TheShuEd · 2024-12-23T12:29:44Z

Content.Server/DropPod/DropPodBeaconComponent.cs

@@ -0,0 +1,12 @@
+using Robust.Shared.Prototypes;
+using Robust.Shared.Serialization.TypeSerializers.Implementations.Custom;


They would do imports before building as these are the sourcegenned ones, I would bet.

TheShuEd · 2024-12-23T12:29:49Z

Content.Server/DropPod/DropPodBeaconComponent.cs

@@ -0,0 +1,12 @@
+using Robust.Shared.Prototypes;
+using Robust.Shared.Serialization.TypeSerializers.Implementations.Custom;
+using Robust.Shared.Serialization.TypeSerializers.Implementations.Custom.Prototype;


TheShuEd · 2024-12-23T12:30:01Z

Content.Server/DropPod/DropPodConsoleComponent.cs

@@ -0,0 +1,28 @@
+using Robust.Shared.Prototypes;
+using Robust.Shared.Serialization.TypeSerializers.Implementations.Custom;


outdated, remove

TheShuEd · 2024-12-23T12:30:07Z

Content.Server/DropPod/DropPodConsoleComponent.cs

@@ -0,0 +1,28 @@
+using Robust.Shared.Prototypes;
+using Robust.Shared.Serialization.TypeSerializers.Implementations.Custom;
+using Robust.Shared.Serialization.TypeSerializers.Implementations.Custom.Prototype;


TheShuEd · 2024-12-23T12:40:49Z

Content.Server/DropPod/LandingPointComponent.cs

@@ -0,0 +1,17 @@
+using Robust.Shared.Prototypes;
+using Robust.Shared.Serialization.TypeSerializers.Implementations.Custom;
+using Robust.Shared.Serialization.TypeSerializers.Implementations.Custom.Prototype;


TheShuEd · 2024-12-23T12:40:57Z

Content.Server/DropPod/LandingPointComponent.cs

+using Robust.Shared.Serialization.TypeSerializers.Implementations.Custom;
+using Robust.Shared.Serialization.TypeSerializers.Implementations.Custom.Prototype;
+
+namespace Content.Server.DropPod


namespace sus

TheShuEd · 2024-12-23T12:41:19Z

Content.Server/DropPod/LandingPointComponent.cs

+        public string NameLandingPoint = "unknow"; // The name of the point that the player will see when activating the DropPod console
+
+        [DataField("uin")]
+        public int UIN = 1; // The unique identification number of the point (each must have its own unique one!)


use EntityUid for it

TheShuEd · 2024-12-23T12:42:28Z

Resources/Prototypes/Entities/Markers/drop_pod_markers.yml

@@ -0,0 +1,71 @@
+- type: entity
+  name: DropPod Beacon


Don't add tokens that players can't interact with. We have Beacons that store the name of locations and are mapped to all stations, use them.

TheShuEd · 2024-12-23T12:43:33Z

Resources/Textures/Markers/droppod.rsi/drop_pod_lighthouse.png

The green cross sprite is a separate sprite that is layered over all other markers. Fix the sprites, see how they are made in other markers.

BeatusCrow and others added 8 commits July 3, 2024 11:38

03.07.24

076338b

Add DropPod

Merge pull request #1 from space-wizards/master

22c0f6a

03.07.24

Update DropPodSystem.cs

58258a6

Update DropPodSystem.cs

8175257

03.07.24

40783a2

Merge branch 'master' of https://github.com/BeatusCrow/space-station-14

6a9cd28

03.07.24

6e5db00

Update DropPodSystem.cs

345be53

github-actions bot added Changes: UI Changes: Might require knowledge of UI design or code. Changes: Sprites Changes: Might require knowledge of spriting or visual design. labels Jul 3, 2024

This comment was marked as spam.

Sign in to view

metalgearsloth requested changes Jul 3, 2024

View reviewed changes

metalgearsloth added the S: Awaiting Changes Status: Changes are required before another review can happen label Jul 3, 2024

Hrosts reviewed Jul 3, 2024

View reviewed changes

Update dropod.ftl

f60b8db

BeatusCrow and others added 3 commits July 3, 2024 17:34

Merge pull request #3 from BeatusCrow/A-variant-of-a-working-capsule-…

340e916

…of-Nuke-Ops Update dropod.ftl

03.07.24

dee8a77

Merge pull request #4 from BeatusCrow/master

d7ea5e5

Lighthouse -> Beacon

This comment was marked as spam.

Sign in to view

SlamBamActionman added the S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. label Nov 14, 2024

TheShuEd added the S: Undergoing Maintainer Discussion Status: Currently going through an extended discussion amongst maintainers, as per procedure. label Dec 20, 2024

TheShuEd requested changes Dec 23, 2024

View reviewed changes

TheShuEd added the S: DO NOT MERGE Status: Open item that should NOT be merged. DNM. Allows test to run unlike draft. label Dec 23, 2024

		@@ -0,0 +1,12 @@
		using Robust.Shared.Prototypes;
		using Robust.Shared.Serialization.TypeSerializers.Implementations.Custom;

		@@ -0,0 +1,28 @@
		using Robust.Shared.Prototypes;
		using Robust.Shared.Serialization.TypeSerializers.Implementations.Custom;

A variant of a working capsule of nuke ops #29683

Are you sure you want to change the base?

A variant of a working capsule of nuke ops #29683

Conversation

BeatusCrow commented Jul 3, 2024 • edited Loading

About the PR

Why / Balance

Technical details

Media

Breaking changes

github-actions bot commented Jul 3, 2024 • edited Loading

This comment was marked as spam.

Djungelskog2 commented Jul 3, 2024

Hrosts commented Jul 3, 2024

metalgearsloth left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

BeatusCrow commented Jul 3, 2024

BeatusCrow commented Jul 3, 2024

Djungelskog2 commented Jul 3, 2024

BeatusCrow commented Jul 3, 2024

Hrosts commented Jul 3, 2024

ps3moira commented Jul 3, 2024

BeatusCrow commented Jul 3, 2024

Catdere commented Jul 9, 2024

BeatusCrow commented Jul 10, 2024 • edited Loading

This comment was marked as spam.

AverageNotDoingAnythingEnjoyer commented Nov 1, 2024

TheShuEd left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

BeatusCrow commented Jul 3, 2024 •

edited

Loading

github-actions bot commented Jul 3, 2024 •

edited

Loading

BeatusCrow commented Jul 10, 2024 •

edited

Loading