Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grey mantle in winterdrobe #29774

Merged
merged 5 commits into from
Aug 13, 2024
Merged

Conversation

Sadie-silly
Copy link
Contributor

About the PR

Adds a grey mantle, meant for everyone on the station. I like mantles, and I wanted to be able to have one without being command

Media

image
image
image

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog

🆑

  • add: Added non command mantle into the winterdrobe

@github-actions github-actions bot added Changes: No C# Changes: Requires no C# knowledge to review or fix this item. Changes: Sprites Changes: Might require knowledge of spriting or visual design. labels Jul 6, 2024
Copy link
Contributor

github-actions bot commented Jul 6, 2024

RSI Diff Bot; head commit 3fe2288 merging into 0c1cfe8
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Clothing/Neck/mantles/mantle.rsi

State Old New Status
equipped-NECK Added
icon Added

Edit: diff updated after 3fe2288

@UltimateJester
Copy link
Contributor

Oh these look awesome, a lot of people would definitely love to have these

@SpaceLizardSky
Copy link
Contributor

SpaceLizardSky commented Jul 8, 2024

head of tiders.. (also could it be possible for it to be in loadouts?)

@Aisu9
Copy link

Aisu9 commented Jul 8, 2024

next step, allowing custom colouration of grey-scale items

@Plykiya
Copy link

Plykiya commented Jul 8, 2024

next step, allowing custom colouration of grey-scale items

this is the next step, along with removing all the color options from the vendors to stop the item bloat

@Sadie-silly
Copy link
Contributor Author

head of tiders.. (also could it be possible for it to be in loadouts?)

was planning on doing this after this gets (hopefully) merged because i'm laazyyy

@timurjavid
Copy link
Contributor

next step, allowing custom colouration of grey-scale items

this is the next step, along with removing all the color options from the vendors to stop the item bloat

Don't want to get off-topic too much, but is there an issue open for this? I'd be interested in looking it

@IProduceWidgets
Copy link
Contributor

next step, allowing custom colouration of grey-scale items

this is the next step, along with removing all the color options from the vendors to stop the item bloat

Don't want to get off-topic too much, but is there an issue open for this? I'd be interested in looking it

I think someone has washing machines that can recolor greyscale items in the works, I would ask on Discord, dunno if its pred yet.

@UbaserB
Copy link
Member

UbaserB commented Jul 25, 2024

It might be better for it to be a rare maints loot tbh

Copy link
Member

@SlamBamActionman SlamBamActionman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While Command mantles are a sign of status and thus need to be restricted in number and availability, we also have plenty of capes that don't signify role. I think this works just fine in the winterdrobe as an addition to the "winter passenger" clothing line.

Copy link
Member

@UbaserB UbaserB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be a passenger loadout unlock instead of in the winterdrobe and printable.

@UbaserB UbaserB added the S: Awaiting Changes Status: Changes are required before another review can happen label Aug 12, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Aug 12, 2024
@Pumkin69
Copy link

i prefer it as a 60 hours passenger unlock because i like status symbols.

@github-actions github-actions bot removed the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Aug 12, 2024
@Sadie-silly
Copy link
Contributor Author

Alright, I removed it from the lathes, and the winterdrobe, then added it into the passenger loadout with a 20 hour timer.

image

@Sadie-silly Sadie-silly requested a review from UbaserB August 12, 2024 18:09
@github-actions github-actions bot added S: Needs Review Status: Requires additional reviews before being fully accepted and removed S: Awaiting Changes Status: Changes are required before another review can happen labels Aug 12, 2024
@UbaserB UbaserB merged commit 329a0a8 into space-wizards:master Aug 13, 2024
14 checks passed
formlessnameless pushed a commit to formlessnameless/imp-station-14 that referenced this pull request Aug 14, 2024
* add the mantle

* fix a few things

* fix merge conflict stuff, remove from winterdrobe and lathe.

* Add mantle to loadouts (20 hour requirement)
@Sadie-silly Sadie-silly deleted the grey-mantle branch January 21, 2025 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: No C# Changes: Requires no C# knowledge to review or fix this item. Changes: Sprites Changes: Might require knowledge of spriting or visual design. S: Needs Review Status: Requires additional reviews before being fully accepted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants