Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Long human ears #29985

Closed
wants to merge 1 commit into from
Closed

Conversation

Sarahon
Copy link
Contributor

@Sarahon Sarahon commented Jul 13, 2024

About the PR

Added long ears for humans

Why / Balance

I wanted long ears. But the original setup also made it that humans couldn't have 'Headtop' overlays because of the cat ears existing.

Technical details

Originally the "Headtop" category for humans was completely disabled, even if you added an overlay, it wouldn't show. I just added the same line other species have.

Decided to add a completely new category to keep the original meme alive, but also unlock the ability now to add more head overlays to the human characters.

Media

image
image
Content Client_IjYq05rmPA

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog
Now able to add "Headtop" markings to human characters while the cat people continue to want.

@Sarahon Sarahon requested a review from DrSmugleaf as a code owner July 13, 2024 04:14
@github-actions github-actions bot added S: Needs Review Status: Requires additional reviews before being fully accepted Changes: Sprites Changes: Might require knowledge of spriting or visual design. labels Jul 13, 2024
Copy link
Contributor

RSI Diff Bot; head commit 81d8638 merging into 3388c0d
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Mobs/Customization/ears.rsi

State Old New Status
long_ears Added

@SlamBamActionman
Copy link
Member

Looks a lot more like elf ears than long human ears. 🤔

@Sarahon
Copy link
Contributor Author

Sarahon commented Jul 17, 2024

Looks a lot more like elf ears than long human ears. 🤔

They're long ears. More than elves can have long ears. And I call them long human ears because they only apply to the human model (which includes dwarfs)

@Sarahon Sarahon closed this Jul 30, 2024
@SlamBamActionman SlamBamActionman mentioned this pull request Jul 30, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Sprites Changes: Might require knowledge of spriting or visual design. S: Needs Review Status: Requires additional reviews before being fully accepted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants