Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the softspoken accent #30656

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

Plykiya
Copy link

@Plykiya Plykiya commented Aug 4, 2024

About the PR

Softspoken forces you to whisper and ends your sentences with ellipses...

Why / Balance

I tend to whisper at all times as my Librarian, because as a Librarian I enjoy being quiet, and security thinks that anyone whispering is a fucking syndicate and I'm tired of it, so I'm hoping it becomes a bit more common to see people whispering with this trait.

Technical details

  • Updated chat code so that speaking is capable of being used for radio channels
  • Added a new TransformSpeechType event that is thrown and caught by the new Softspoken accents to change the user's chat type from Local -> Whisper or Whisper -> Local
  • Pretty straightforward and short implementation of the two accents with comments to go along with it
  • The punctuation (.../!) is only added if the user does not add any punctuation to their messages.

Media

Softspoken:

2024-08-04.16-46-06.mp4

Requirements

  • I have read and I am following the Pull Request Guidelines. I understand that not doing so may get my pr closed at maintainer’s discretion
  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

🆑

  • add: Adds the softspoken trait. This forces your character to whisper...

@Plykiya
Copy link
Author

Plykiya commented Aug 5, 2024

It's kind of meta-gameable because of the forced punctuation. I don't mind removing that part.

@bruhmogus
Copy link

this seems cool, but does loudspoken also add the exclamation mark if the sentence already ends with an exclamation mark? and does the elipses on softspoken get added if there's already puncuation like elipses?

@Plykiya
Copy link
Author

Plykiya commented Aug 6, 2024

this seems cool, but does loudspoken also add the exclamation mark if the sentence already ends with an exclamation mark? and does the elipses on softspoken get added if there's already puncuation like elipses?

Bullet point #4:
"The punctuation (.../!) is only added if the user does not add any punctuation to their messages."

@bruhmogus
Copy link

this seems cool, but does loudspoken also add the exclamation mark if the sentence already ends with an exclamation mark? and does the elipses on softspoken get added if there's already puncuation like elipses?

Bullet point #4: "The punctuation (.../!) is only added if the user does not add any punctuation to their messages."

mb im fucken stupid

@github-actions github-actions bot added the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Aug 16, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Aug 16, 2024
@UbaserB UbaserB added the S: Undergoing Maintainer Discussion Status: Currently going through an extended discussion amongst maintainers, as per procedure. label Aug 26, 2024
Copy link
Member

@UbaserB UbaserB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After internal discussion, it's been decided that only the softspoken accent should be added to the game as the loudmouth accent may come off as annoying or encourage failrp.

@UbaserB UbaserB added the S: Awaiting Changes Status: Changes are required before another review can happen label Aug 29, 2024
@Plykiya Plykiya changed the title Add the softspoken and loudmouth accents Add the softspoken accent Aug 31, 2024
@lzk228
Copy link
Contributor

lzk228 commented Aug 31, 2024

what if you write !! at the end of the sentence? (hello!!)
it makes message bold and sets verb to screams

@Plykiya Plykiya requested a review from UbaserB September 1, 2024 00:40
@github-actions github-actions bot added S: Needs Review Status: Requires additional reviews before being fully accepted S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted and removed S: Awaiting Changes Status: Changes are required before another review can happen labels Sep 1, 2024
Copy link
Contributor

github-actions bot commented Sep 1, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Sep 2, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Sep 15, 2024
@github-actions github-actions bot removed the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Sep 16, 2024
@Plykiya
Copy link
Author

Plykiya commented Sep 19, 2024

what if you write !! at the end of the sentence? (hello!!) it makes message bold and sets verb to screams

still whispers

@SlamBamActionman SlamBamActionman added the S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. label Nov 14, 2024
@eoineoineoin eoineoineoin added P3: Standard Priority: Default priority for repository items. T: New Feature Type: New feature or content, or extending existing content D3: Low Difficulty: Some codebase knowledge required. A: Character/Species Area: Player characters and species features and content. A: Roleplay/Lore Area: Roleplay aspects or content that primarily target the game's lore, rather than mechanics and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Nov 18, 2024
@Plykiya
Copy link
Author

Plykiya commented Dec 18, 2024

Seems like this PR will likely have to wait until the chat refactor.

@Boaz1111
Copy link
Contributor

Seems like this PR will likely have to wait until the chat refactor.

why's that?

@github-actions github-actions bot added the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Jan 27, 2025
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added size/M Denotes a PR that changes 100-999 lines. and removed S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted labels Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: Character/Species Area: Player characters and species features and content. A: Roleplay/Lore Area: Roleplay aspects or content that primarily target the game's lore, rather than mechanics D3: Low Difficulty: Some codebase knowledge required. P3: Standard Priority: Default priority for repository items. S: Needs Review Status: Requires additional reviews before being fully accepted S: Undergoing Maintainer Discussion Status: Currently going through an extended discussion amongst maintainers, as per procedure. size/M Denotes a PR that changes 100-999 lines. T: New Feature Type: New feature or content, or extending existing content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants