Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Ian hats!+ #33737

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Support for Ian hats!+ #33737

wants to merge 13 commits into from

Conversation

ASTRALIXIX
Copy link

@ASTRALIXIX ASTRALIXIX commented Dec 5, 2024

About the PR

Adds full support for hats, masks, scarves and glasses for Ian (So far only the regular and old versions)!
It is an updated version of this PR #33701

Why / Balance

SS13 has it! And this customization of Ian is even better than there!

Technical details

Added a new displacement map for Corgi.
Added a new Inventory Template for corgi (This is an opportunity for future more subtle customization).
All hats supported by hamster_inventory_template + additionally specified can now be worn on the regular and old version of Ian.

Media

That's not all...
image

ian3

Requirements

Breaking changes

None

Changelog
🆑

  • add: Added full support for hats, masks, scarves and glasses for Ian!

@github-actions github-actions bot added S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. Changes: Sprites Changes: Might require knowledge of spriting or visual design. size/L Denotes a PR that changes 1000-4999 lines. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Dec 5, 2024
Copy link
Contributor

github-actions bot commented Dec 5, 2024

RSI Diff Bot; head commit f834b77 merging into 1110397
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Clothing/Head/Hats/santahat.rsi

State Old New Status
equipped-HELMET-dog Added

Resources/Textures/Clothing/Head/Misc/bunny.rsi

State Old New Status
equipped-HELMET-dog Added

Resources/Textures/Mobs/Pets/corgi/corgi_displacement.rsi

State Old New Status
eyes Added
head Added
mask Added
neck Added

Edit: diff updated after f834b77

@beck-thompson beck-thompson added P3: Standard Priority: Default priority for repository items. T: New Feature Type: New feature or content, or extending existing content D3: Low Difficulty: Some codebase knowledge required. S: Needs Review Status: Requires additional reviews before being fully accepted A: Art Area: Art with no implications for other areas. T: Visual Change Type: Deals with changes to art, sprites or other visuals in the game. labels Dec 7, 2024
@ASTRALIXIX ASTRALIXIX changed the title Ian hats! Take 2 Ian hats!+ Dec 15, 2024
@ASTRALIXIX ASTRALIXIX changed the title Ian hats!+ Support for Ian hats!+ Dec 21, 2024
@github-actions github-actions bot added size/M Denotes a PR that changes 100-999 lines. and removed size/L Denotes a PR that changes 1000-4999 lines. labels Dec 23, 2024
@Velken
Copy link
Contributor

Velken commented Jan 30, 2025

I would change "displacement.rsi" to "ian_displamcent.rsi" or "corgi_displacement.rsi" to follow with the existing Smiles naming and be example for future displacements to be named "thing_displacement.rsi"

Velken added a commit to Velken/space-station-14 that referenced this pull request Jan 30, 2025
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Jan 31, 2025
@ASTRALIXIX
Copy link
Author

I would change "displacement.rsi" to "ian_displamcent.rsi" or "corgi_displacement.rsi" to follow with the existing Smiles naming and be example for future displacements to be named "thing_displacement.rsi"

It makes sense.

@github-actions github-actions bot removed the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: Art Area: Art with no implications for other areas. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. Changes: Sprites Changes: Might require knowledge of spriting or visual design. D3: Low Difficulty: Some codebase knowledge required. P3: Standard Priority: Default priority for repository items. S: Needs Review Status: Requires additional reviews before being fully accepted size/M Denotes a PR that changes 100-999 lines. T: New Feature Type: New feature or content, or extending existing content T: Visual Change Type: Deals with changes to art, sprites or other visuals in the game.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants