-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Hotfix] Add [MRP] tag to the hostname for Salamander. #33904
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JIPDawg
requested review from
metalgearsloth,
Partmedia,
DrSmugleaf,
Emisse and
EmoGarbage404
as code owners
December 17, 2024 05:01
github-actions
bot
added
S: Needs Review
Status: Requires additional reviews before being fully accepted
size/XL
Denotes a PR that changes 5000+ lines.
Branch: Stable
Intended to be merged into Stable.
Changes: UI
Changes: Might require knowledge of UI design or code.
Changes: Map
Changes: Might require knowledge of mapping.
Changes: Sprites
Changes: Might require knowledge of spriting or visual design.
S: Merge Conflict
Status: Needs to resolve merge conflicts before it can be accepted
labels
Dec 17, 2024
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
added
the
S: Untriaged
Status: Indicates an item has not been triaged and doesn't have appropriate labels.
label
Dec 17, 2024
RSI Diff Bot; head commit 30341e0 merging into a3fc690 Resources/Textures/Clothing/Head/Hats/beret_warden.rsi
Resources/Textures/Clothing/Head/Hats/safarihat.rsi
Resources/Textures/Clothing/Head/Hats/warden.rsi
Resources/Textures/Objects/Consumable/Drinks/zombiecocktail.rsi
Resources/Textures/Objects/Fun/toys.rsi
Resources/Textures/Objects/Materials/Scrap/generator.rsi
Resources/Textures/Structures/Specific/Anomalies/Cores/santa_core.rsi
Resources/Textures/Structures/Specific/Anomalies/inner_anom_layer.rsi
Resources/Textures/Structures/Specific/Anomalies/santa_anom.rsi
|
hmm 280 changes. I don't think this was the right way to PR this. BACK TO MASTER IT GOES. THE MAINTS CAN FIGURE IT OUT :) |
JIPDawg
added
P3: Standard
Priority: Default priority for repository items.
Changes: No C#
Changes: Requires no C# knowledge to review or fix this item.
and removed
Changes: UI
Changes: Might require knowledge of UI design or code.
Changes: Map
Changes: Might require knowledge of mapping.
Changes: Sprites
Changes: Might require knowledge of spriting or visual design.
S: Merge Conflict
Status: Needs to resolve merge conflicts before it can be accepted
S: Untriaged
Status: Indicates an item has not been triaged and doesn't have appropriate labels.
Branch: Stable
Intended to be merged into Stable.
size/XL
Denotes a PR that changes 5000+ lines.
labels
Dec 17, 2024
JIPDawg
added
A: Accessibility
Area: Accessibility settings and features.
T: Of Admin Interest
Type: Affects administration work a lot, and might require admins to weigh in on
size/XS
Denotes a PR that changes 0-9 lines.
labels
Dec 17, 2024
I remade the PR to properly target stable #33909 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A: Accessibility
Area: Accessibility settings and features.
Changes: No C#
Changes: Requires no C# knowledge to review or fix this item.
P3: Standard
Priority: Default priority for repository items.
S: Needs Review
Status: Requires additional reviews before being fully accepted
size/XS
Denotes a PR that changes 0-9 lines.
T: Of Admin Interest
Type: Affects administration work a lot, and might require admins to weigh in on
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
I changed the Hostname to include the [MRP] tag so users can see at a glance it is using the MRP ruleset.
Why / Balance
Currently the only way to confirm Salamander is the MRP server is by reading the description. Literally EVERY other MRP server has MRP as a tag. I'm requesting this be a hotfix as we routinely get people that EORG or just forget what server they are on / know which server is the MRP server. Don't see any [MRP] tag and just assume. The only other indication is at the VERY END and it's just "RP".
Technical details
It's a web edit, sue me.
Media
Requirements
Breaking changes
Changelog
no cl