Fake mindshield componentry and Implanter #34079

poklj · 2024-12-26T22:30:21Z

About the PR

Added a a Component and Implanter that injects a Togglable fake Mindshield into someone, allowing them to deceive anyone with the ability to see mindshielded status.

This functionality is also later required for Changelings "Mindshield" ability at a later date.

As well due to how Implanting works, the Check for if a implant is already implanted has been moved to AFTER the DoAfter to prevent sufficiently Metagaming Secoffs from instantly identifying if a particular individual is faking their Implant.

Why / Balance

At the moment any attempt to Disguise or impersonate a Command or Security staff is foiled by a lack of Mindshield, and while an antag CAN acquire them via duplicitious means via the ATS, that is a higher bar to cross and further means they might otherwise be unable to shed their disguise to blend back into the crowd.

A Togglable fake is therefor able to Allow an antag with sufficient speech skills to impersonate Command or Security staff and further blend back into the crowd, however such a method is still not foolproof and would require the individual to pick their moment.

Technical details

Moved the SameImplant check into the shared system and into the Implant method, as before it would check at the action of trying to implant. it won't use up the implant but gives some breathing room to the implantee to act (and further make it obvious if someone is attempting to metagame), this can probably also be made to Harm the Implanter a-la #32136 to further punish attempted metagaming.

Added a check inside of ShowMindShieldIconsSystem to check for enabled Fake mindshields.

Media

2024-12-26.18-25-20.mp4

Requirements

I have read and am following the Pull Request and Changelog Guidelines.
I have added media to this PR or it does not require an ingame showcase.

Breaking changes

Moved CheckSameImplant from Content.Server.Implants.ImplanterSystem to Content.Shared.Implants.SharedImplanterSystem
Changelog

🆑 Kickguy223

add: A new Syndicate and Thief togglable implant is available capable of Impersonating a Mindshield
tweak: All implants will now inform you if an implant is already present after the attempt instead of before

- Add FakeMindshield System and Component - Add FakeMindsheildImplantSystem and Component - modify ShowMindShieldIconsSystem to check for FakeMindshields - add all supporting yaml for the Implants, action and uplink - add loc file stuff - add unfinished sprites

- Move Implant sameness check to AFTER the implant DoAfter to prevent instant identification of Deception Implants - cleanup the systems and components - add the fake mindshield to the Thief toolbox

github-actions · 2024-12-26T22:30:53Z

RSI Diff Bot; head commit 2bf7bd1 merging into 52d39aa
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Interface/Actions/actions_fakemindshield.rsi

State	Old	New	Status
icon-on			Added
icon			Added

Edit: diff updated after 2bf7bd1

beck-thompson

Looks great! Just a few minor issues

Content.Shared/Mindshield/FakeMindShield/SharedFakeMindshieldSystem.cs

Content.Shared/Mindshield/FakeMindShield/SharedFakeMindShieldImplantSystem.cs

Content.Shared/Mindshield/Components/FakeMindshieldComponent.cs

Content.Shared/Implants/SharedImplanterSystem.cs

Content.Server/Mindshield/FakeMindShield/FakeMindShieldImplantSystem.cs

Content.Shared/Mindshield/FakeMindShield/SharedFakeMindshieldSystem.cs

Cojoke-dot · 2024-12-27T01:34:35Z

Ok, so in order to impersonate a mindshielded person properly with only syndicate equipment you would need:

This implant - 4tc
Cham set - 4tc
Agent ID - 3tc
Voice Mask - 2tc

~ 13tc not including how you deal with the person you're imitating or any discounts.

The uplink price feels good I think, leaves you with 7 tc which is not enough to get northstars or eswords but it's still enough to deal with a secoff or head if you get the jump on them(webvest with viper and extra mag or a cobra).

My only issue with the item is about revs with thief, it could be a cool dynamic but if a headrev gets one of these then there would be no way to stop them, at least till the rework that just got approved is implemented lol.

Pumkin69 · 2024-12-27T08:01:10Z

sick sprite :godo:

- Moved ImplantCheck and eventsubscription into Shared - Remove Client/Server extensions of FakeMindshieldImplantSystem and FakeMindShieldSystem and make shared Sealed - make OnToggleMindshield Private, use the event!

SlamBamActionman

I think I like this implant conceptually, though it is hard to say how it will impact how suspicious Sec/Command will be of each other. Probably good to have though, and is a bit nicer than just adding a regular mindshield to the uplink.

Resources/Prototypes/Catalog/uplink_catalog.yml

Content.Shared/Mindshield/FakeMindShield/SharedFakeMindshieldSystem.cs

Content.Server/Implants/ImplanterSystem.cs

Content.Shared/Implants/SharedImplanterSystem.cs

Content.Shared/Mindshield/FakeMindShield/SharedFakeMindShieldImplantSystem.cs

- cleaned up extra liens in ImplanterSystem and SharedFakeMindshieldSystem from when i was developing - Uplink catalog no longer lists the implant in 2 spots, only implants now, also uses the On state action icon - added a comment about why it's reraising the action event rather than directly interacting with the FakeMindshield Component

OnsenCapy · 2025-01-06T07:52:05Z

This is rough because if an antag gets hold off a mindshield, they usually get to wipe out the whole sec team without them even realizing why they are being shot by "their own teammate". All it takes is warden opening armory for you to get an antag with free unlimited guns. Most of the time cadets wont even question if you kill someone else as a secoff if you have the mindshield. I do think this is a good PR and skill to have, I just wonder how it will affect SS14 as a whole beyond the scope of this little PR

IProduceWidgets · 2025-01-14T23:34:43Z

I think Id rather we just revert the mindshield UI, and instead make it show in the station records who has one.

Aisu9 · 2025-01-27T04:08:14Z

is this pr going anywhere beck?

beck-thompson · 2025-01-27T05:01:42Z

is this pr going anywhere beck?

I don't see why it shouldn't!

beck-thompson

Really minor nitpicky style issues but besides this it looks good!

Resources/Prototypes/Catalog/uplink_catalog.yml

Content.Shared/Mindshield/FakeMindShield/SharedFakeMindShieldImplantSystem.cs

Content.Shared/Mindshield/Components/FakeMindshieldComponent.cs

- Added a comment about IsEnabled - moved OnFakeMindShieldToggle to Entity<> from Uid, Comp - fixed some formatting in uplink_catalog

beck-thompson

Tested and everything seems to work! 🫡

* Fake Mindshield (With some bad sprites) - Add FakeMindshield System and Component - Add FakeMindsheildImplantSystem and Component - modify ShowMindShieldIconsSystem to check for FakeMindshields - add all supporting yaml for the Implants, action and uplink - add loc file stuff - add unfinished sprites * Cleanup, add to thief toolbox, remove metagame - Move Implant sameness check to AFTER the implant DoAfter to prevent instant identification of Deception Implants - cleanup the systems and components - add the fake mindshield to the Thief toolbox * part 1 of fixing the folder problem * Make the fakemindshield sprite folder lowercase * CR - Move ImplantCheck into shared, cleanup - Moved ImplantCheck and eventsubscription into Shared - Remove Client/Server extensions of FakeMindshieldImplantSystem and FakeMindShieldSystem and make shared Sealed - make OnToggleMindshield Private, use the event! * CR - Cleanup extra lines, fix some Prototype - cleaned up extra liens in ImplanterSystem and SharedFakeMindshieldSystem from when i was developing - Uplink catalog no longer lists the implant in 2 spots, only implants now, also uses the On state action icon - added a comment about why it's reraising the action event rather than directly interacting with the FakeMindshield Component * Fake Mindshield CR: - Added a comment about IsEnabled - moved OnFakeMindShieldToggle to Entity<> from Uid, Comp - fixed some formatting in uplink_catalog * CR - Add a bit more comment

poklj added 4 commits December 25, 2024 05:25

Cleanup, add to thief toolbox, remove metagame

eeea480

- Move Implant sameness check to AFTER the implant DoAfter to prevent instant identification of Deception Implants - cleanup the systems and components - add the fake mindshield to the Thief toolbox

part 1 of fixing the folder problem

55e220f

Make the fakemindshield sprite folder lowercase

a72da06

beck-thompson reviewed Dec 27, 2024

View reviewed changes

CR - Move ImplantCheck into shared, cleanup

e7a95d9

- Moved ImplantCheck and eventsubscription into Shared - Remove Client/Server extensions of FakeMindshieldImplantSystem and FakeMindShieldSystem and make shared Sealed - make OnToggleMindshield Private, use the event!

github-actions bot added the size/M Denotes a PR that changes 100-999 lines. label Dec 28, 2024

SlamBamActionman requested changes Jan 4, 2025

View reviewed changes

SlamBamActionman approved these changes Jan 6, 2025

View reviewed changes

SlamBamActionman added the S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. label Jan 6, 2025

beck-thompson requested changes Jan 27, 2025

View reviewed changes

poklj added 2 commits January 27, 2025 16:22

Fake Mindshield CR:

640b7ec

- Added a comment about IsEnabled - moved OnFakeMindShieldToggle to Entity<> from Uid, Comp - fixed some formatting in uplink_catalog

CR - Add a bit more comment

2bf7bd1

beck-thompson approved these changes Jan 28, 2025

View reviewed changes

beck-thompson merged commit c504588 into space-wizards:master Jan 28, 2025
14 checks passed

poklj mentioned this pull request Jan 28, 2025

Fake Mindshield Implant cleans itself up on draw #34718

Open

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fake mindshield componentry and Implanter #34079

Fake mindshield componentry and Implanter #34079

poklj commented Dec 26, 2024

github-actions bot commented Dec 26, 2024 •

edited

Loading

beck-thompson left a comment

Cojoke-dot commented Dec 27, 2024 •

edited

Loading

Pumkin69 commented Dec 27, 2024

SlamBamActionman left a comment

OnsenCapy commented Jan 6, 2025

IProduceWidgets commented Jan 14, 2025

Aisu9 commented Jan 27, 2025

beck-thompson commented Jan 27, 2025 •

edited

Loading

beck-thompson left a comment

beck-thompson left a comment

Fake mindshield componentry and Implanter #34079

Fake mindshield componentry and Implanter #34079

Conversation

poklj commented Dec 26, 2024

About the PR

Why / Balance

Technical details

Media

Requirements

Breaking changes

github-actions bot commented Dec 26, 2024 • edited Loading

beck-thompson left a comment

Choose a reason for hiding this comment

Cojoke-dot commented Dec 27, 2024 • edited Loading

Pumkin69 commented Dec 27, 2024

SlamBamActionman left a comment

Choose a reason for hiding this comment

OnsenCapy commented Jan 6, 2025

IProduceWidgets commented Jan 14, 2025

Aisu9 commented Jan 27, 2025

beck-thompson commented Jan 27, 2025 • edited Loading

beck-thompson left a comment

Choose a reason for hiding this comment

beck-thompson left a comment

Choose a reason for hiding this comment

github-actions bot commented Dec 26, 2024 •

edited

Loading

Cojoke-dot commented Dec 27, 2024 •

edited

Loading

beck-thompson commented Jan 27, 2025 •

edited

Loading