Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inserted container visuals for Cryopod and grinder #34183

Open
wants to merge 19 commits into
base: master
Choose a base branch
from

Conversation

insoPL
Copy link
Contributor

@insoPL insoPL commented Jan 2, 2025

About the PR

Added visuals to grinder and cryopod.
Grinders show how much liquid holds inserted beaker
Cryopod now has external meter that shows how much liquid is inside inserted beaker.
Additionally it changes color of cryoliquid to that of a inserted liquid and changes color of emitted light.
Cryopod now visually turns off when it runs out of cryo liquid.

I'm not a professional pixel artist, just someone with GIMP installed. If anyone wants to change those textures and improve them, please feel free to do so!

Why / Balance

Visual cue for player about why grinder or cryopod don't work.
Me like colors.
Should not affect game mechanics.

Technical details

InsertedItemSlotID was added to SolutionContainerVisuals. In the future someone can use same system to improve other machines.
I also moved some textures around and did some name swaps. For example grinder was sometimes called juicer, cryopod was sometimes cryogenics.

Media

image
https://youtu.be/xgVjofX7u4U

Requirements

Breaking changes

Changelog

@github-actions github-actions bot added S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. Changes: Sprites Changes: Might require knowledge of spriting or visual design. size/M Denotes a PR that changes 100-999 lines. labels Jan 2, 2025
Copy link
Contributor

github-actions bot commented Jan 2, 2025

RSI Diff Bot; head commit f9cefda merging into 20f5cbf
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Structures/Machines/cryogenics.rsi

State Old New Status
cover-on Removed
pod-off Removed
pod-on Removed
pod-open Removed

Resources/Textures/Structures/Machines/Medical/cryopod.rsi

State Old New Status
beakerSlot1 Added
beakerSlot2 Added
beakerSlot3 Added
beakerSlot4 Added
cover-on Added
pod-off Added
pod-on Added
pod-open Added

Resources/Textures/Structures/Machines/grinder.rsi

State Old New Status
beakerSlot1 Added
beakerSlot2 Added
beakerSlot3 Added
beakerSlot4 Added

Edit: diff updated after f9cefda

@insoPL insoPL marked this pull request as ready for review January 2, 2025 19:33
@insoPL insoPL requested a review from Jezithyr as a code owner January 2, 2025 19:33
@github-actions github-actions bot added the S: Needs Review Status: Requires additional reviews before being fully accepted label Jan 2, 2025
@ScarKy0
Copy link
Contributor

ScarKy0 commented Jan 2, 2025

It looks so cool it better convince people to start doing cryo

@lzk228
Copy link
Contributor

lzk228 commented Jan 2, 2025

i think it's better to split pr into two parts: for cryopod and for grinder, that will make review faster

@insoPL
Copy link
Contributor Author

insoPL commented Jan 2, 2025

i think it's better to split pr into two parts: for cryopod and for grinder, that will make review faster

Well technically it should be split in four:
-refactor
-adding system that handles this in SolutionContainerVisuals
-implementing that system in cryo
-implementing that system in grinders
I am not sure, how i should do it so i will just leave it to maintainers to decide and split it in a way they want it. I mean do we really need 4 more PR to review?

@insoPL
Copy link
Contributor Author

insoPL commented Jan 2, 2025

It looks so cool it better convince people to start doing cryo

Yeah, cryo is fun. I will try to make a shot at making UI for cryo when this is merged.

@beck-thompson
Copy link
Contributor

I will finally convince people to use cryo now!

@beck-thompson beck-thompson added P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention. T: New Feature Type: New feature or content, or extending existing content D2: Medium Difficulty: A good amount of codebase knowledge required. A: Art Area: Art with no implications for other areas. A: Medical Area: Medical department, including Chemistry and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Jan 4, 2025
@insoPL
Copy link
Contributor Author

insoPL commented Feb 7, 2025

#34842
I extracted cleanup part to this PR. So this will get somewhat smaller and easier to review after it is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: Art Area: Art with no implications for other areas. A: Medical Area: Medical department, including Chemistry Changes: Sprites Changes: Might require knowledge of spriting or visual design. D2: Medium Difficulty: A good amount of codebase knowledge required. P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention. S: Needs Review Status: Requires additional reviews before being fully accepted size/M Denotes a PR that changes 100-999 lines. T: New Feature Type: New feature or content, or extending existing content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants