-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Grenade resprites part 1, stinger sound change, projectile grenade animation fix #34421
base: master
Are you sure you want to change the base?
Conversation
RSI Diff Bot; head commit 3e9df19 merging into 2bebaa7 Resources/Textures/Objects/Weapons/Grenades/empgrenade.rsi
Resources/Textures/Objects/Weapons/Grenades/flashbang.rsi
Resources/Textures/Objects/Weapons/Grenades/smoke.rsi
Resources/Textures/Objects/Weapons/Grenades/stingergrenade.rsi
Resources/Textures/Objects/Weapons/Grenades/tear_gas.rsi
|
i like it as long as they still flash when armed. |
Looks good but the stinger should be way more spherical if you wanna replicate the shape of a real stinger grenade (as in, rubber ball grenades) |
I was considering that, but I'm currently reserving the 'oval' look for all projectile grenades (stingers, incendiary, shrapnel, etc.), and doing a ball shape for explosives |
Yeah they do that, I just can't show it as well with still images |
Is it possible to add movement to gas grenades? |
Out of scope and unsure what this would be for |
About the PR
Why / Balance
Grenades were resprited for the following reasons:
Rather than creating a new shape or style altogether, I opted to 'remix' the original r4407 grenades and their derivatives, which should make them consistent and easier to identify.
I will be adding more grenades in separate PRs as I am still working on them and their attributions.
Projectile grenades such as stingers grenades or shrapnel grenades should now play their animations, which improves player experience and helps point out primed grenades.
Stinger grenades played two different overlapping sounds, so I've removed one and kept the flashbang sound; their sound cue should be associated with security.
Technical details
image, json, yml changes
Resources/Prototypes/Entities/Objects/Weapons/Throwable/projectile_grenades.yml
(removed one of two stinger beeping sounds, added animations for all projectile grenades)Media
Requirements
Breaking changes
N/A
Changelog
🆑