Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moth-pockets #34517

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Moth-pockets #34517

wants to merge 8 commits into from
+74 −1

Conversation

kosticia
Copy link
Contributor

@kosticia kosticia commented Jan 19, 2025 •
edited
Loading

About the PR

Added moth-pockets, donk-pockets for moths

Why / Balance

We didn't have analog of donk-pockets for moths. Thats sad.

Technical details

Only .yml changes. Added some codersprites.

Media

Безымян6ный
Box sprite outdated

Requirements

Changelog
🆑

  • add: Added analog of donk-pockets for moth - moth-pockets

@github-actions github-actions bot added Changes: No C# Changes: Requires no C# knowledge to review or fix this item. Changes: Sprites Changes: Might require knowledge of spriting or visual design. size/S Denotes a PR that changes 10-99 lines. S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Jan 19, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 19, 2025 •
edited
Loading

RSI Diff Bot; head commit 4962afe merging into d531a9d
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Objects/Consumable/Food/Baked/donkpocket.rsi

State Old New Status
moth-box Added
moth Added

Edit: diff updated after 4962afe

@ScarKy0 ScarKy0 added P3: Standard Priority: Default priority for repository items. T: New Feature Type: New feature or content, or extending existing content D3: Low Difficulty: Some codebase knowledge required. S: Needs Review Status: Requires additional reviews before being fully accepted A: Service Area: Service department, including cooking, botany, etc and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Jan 19, 2025
@deltanedas
Copy link
Contributor

moth-flavoured donk pockets 😋

beck-thompson
beck-thompson requested changes Jan 19, 2025
View reviewed changes
Copy link
Contributor

@beck-thompson beck-thompson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense! 👍

Resources/Textures/Objects/Consumable/Food/Baked/donkpocket.rsi/meta.json Outdated Show resolved Hide resolved
@beck-thompson beck-thompson added the S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. label Jan 19, 2025
@TiniestShark
Copy link
Contributor

I like the idea of a cloth donk pocket filled with just like, really loose fuzz or something. Perfect moff snack.

@github-actions github-actions bot added the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Feb 4, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 4, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@FairlySadPanda
Copy link
Contributor

Missed opportunity for them to be moth-balls

@github-actions github-actions bot removed the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beck-thompson beck-thompson beck-thompson approved these changes

Assignees
No one assigned
Labels
A: Service Area: Service department, including cooking, botany, etc Changes: No C# Changes: Requires no C# knowledge to review or fix this item. Changes: Sprites Changes: Might require knowledge of spriting or visual design. D3: Low Difficulty: Some codebase knowledge required. P3: Standard Priority: Default priority for repository items. S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. S: Needs Review Status: Requires additional reviews before being fully accepted size/S Denotes a PR that changes 10-99 lines. T: New Feature Type: New feature or content, or extending existing content
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kosticia @deltanedas @TiniestShark @FairlySadPanda @beck-thompson @ScarKy0