Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add binoculars #34687

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add binoculars #34687

wants to merge 4 commits into from
+56 −0

Conversation

slarticodefast
Copy link
Member

@slarticodefast slarticodefast commented Jan 28, 2025 •
edited
Loading

About the PR

Added binoculars. They use the new camera offset feature from #31626
For now they can only be found as rare maints loot and in the warden's locker.
The sprites are from tg, but might need some improvement.

Why / Balance

Fun item and they exist in SS13.

Technical details

Yaml and sprites only.

Media

binoculars.mp4

Requirements

Breaking changes

none

Changelog
🆑

  • add: Added binoculars. You can find them in maints loot and the warden's locker.

@github-actions github-actions bot added S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. Changes: Sprites Changes: Might require knowledge of spriting or visual design. size/S Denotes a PR that changes 10-99 lines. labels Jan 28, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 28, 2025 •
edited
Loading

RSI Diff Bot; head commit b09f03e merging into 3d3b95a
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Objects/Tools/binoculars.rsi

State Old New Status
icon Added
inhand-left Added
inhand-right Added
wielded-inhand-left Added
wielded-inhand-right Added

Edit: diff updated after b09f03e

@slarticodefast slarticodefast added the S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. label Jan 28, 2025
@K-Dynamic
Copy link
Contributor

I think it would be worth giving them to security, salvage and nukies

@LevitatingTree
Copy link
Contributor

would be very handy for sec, specially the warden

@HerCoyote23
Copy link
Contributor

HerCoyote23 commented Jan 28, 2025 •
edited
Loading

Honestly feel like they could offset more, as shown in the video they don't seem particularly effective, particularly since they don't zoom you out or anything.

@ArtisticRoomba ArtisticRoomba added P3: Standard Priority: Default priority for repository items. T: New Feature Type: New feature or content, or extending existing content D3: Low Difficulty: Some codebase knowledge required. A: General Interactions Area: General in-game interactions that don't relate to another area. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Jan 28, 2025
@NoElkaTheGod
Copy link
Contributor

I agree, the effect is kinda weak. Could use a bit of a buff, considering the fact you have to weild it anyways (which is weird, but i assume it's for balance, so let's just say that these binoculars are very large and heavy).

@slarticodefast
Copy link
Member Author

would be very handy for sec, specially the warden

Sure, why not. I added one to the wardens locker.

Honestly feel like they could offset more, as shown in the video they don't seem particularly effective, particularly since they don't zoom you out or anything.

I buffed the offset from 3 to 5 tiles.

Screenshot (355)

SlamBamActionman
SlamBamActionman approved these changes Jan 28, 2025
View reviewed changes
Copy link
Member

@SlamBamActionman SlamBamActionman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and concept looks good to me

@Pixeltheaertist
Copy link

Does this mean stuff like the hristov can finally have scopes?

@slarticodefast
Copy link
Member Author

Does this mean stuff like the hristov can finally have scopes?

It now does! that's where the component I'm using comes from :)
#31626

@NULL882
Copy link
Contributor

NULL882 commented Jan 29, 2025

Ability to hang in the neck slot would be useful.

@LevitatingTree
Copy link
Contributor

LevitatingTree commented Jan 29, 2025 •
edited
Loading

yeah, like the whistle

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@metalgearsloth metalgearsloth metalgearsloth left review comments

@SlamBamActionman SlamBamActionman SlamBamActionman approved these changes

Assignees
No one assigned
Labels
A: General Interactions Area: General in-game interactions that don't relate to another area. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. Changes: Sprites Changes: Might require knowledge of spriting or visual design. D3: Low Difficulty: Some codebase knowledge required. P3: Standard Priority: Default priority for repository items. S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. size/S Denotes a PR that changes 10-99 lines. T: New Feature Type: New feature or content, or extending existing content
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@slarticodefast @K-Dynamic @LevitatingTree @HerCoyote23 @NoElkaTheGod @Pixeltheaertist @NULL882 @metalgearsloth @SlamBamActionman @ArtisticRoomba