Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some SMG magazines fitting 35 rounds #34782

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix some SMG magazines fitting 35 rounds #34782

wants to merge 2 commits into from
+1 −2

Conversation

Nox38
Copy link
Contributor

@Nox38 Nox38 commented Jan 31, 2025

About the PR

All SMG magazines now correctly hold 30 rounds of .35. Before this, only the prefilled magazine containing standard ammo was 30 round, while the empty magazine and other prefilled magazines were 35 round.

Why / Balance

This shouldn't effect balance in any meaningful way. The drozd could technically get 11 bursts out of a magazine before if you crafted empty mags and manually filled it, but now you cant.

Technical details

Reduced BaseMagazinePistolSubMachineGun's capacity to 30 from 35.

Requirements

Changelog

@Nox38 Nox38 marked this pull request as ready for review January 31, 2025 07:27
@github-actions github-actions bot added size/XS Denotes a PR that changes 0-9 lines. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Jan 31, 2025
@ArtisticRoomba ArtisticRoomba added T: Bugfix Type: Bugs and/or bugfixes P3: Standard Priority: Default priority for repository items. S: Needs Review Status: Requires additional reviews before being fully accepted T: Balance Change Type: Balance changes through direct value changes, or changes to mechanics that affect it DB: Beginner Friendly Difficulty: Great for beginners. Unambiguous in scope, and explains how to achieve the result. A: Combat Area: Combat features and changes, balancing, feel and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Feb 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A: Combat Area: Combat features and changes, balancing, feel Changes: No C# Changes: Requires no C# knowledge to review or fix this item. DB: Beginner Friendly Difficulty: Great for beginners. Unambiguous in scope, and explains how to achieve the result. P3: Standard Priority: Default priority for repository items. S: Needs Review Status: Requires additional reviews before being fully accepted size/XS Denotes a PR that changes 0-9 lines. T: Balance Change Type: Balance changes through direct value changes, or changes to mechanics that affect it T: Bugfix Type: Bugs and/or bugfixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nox38 @ArtisticRoomba