Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix screens not being dismantlable #34804

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

Fix screens not being dismantlable #34804

wants to merge 17 commits into from
+171 −2

Conversation

VerinSenpai
Copy link

@VerinSenpai VerinSenpai commented Feb 1, 2025 •
edited
Loading

About the PR

Added construction steps specific to screens to allow them to be built from scratch and deconstructed completely (fixes #33224) Also added some sprites for the various build steps of the screen (inspiration taken from the existing station map sprites)

Why / Balance

Currently, screens cannot be deconstructed completely. Once they are deconned to the timer, you are unable to proceed. This makes renovations a touch annoying since you are unable to move the screen. I've been holding a grudge against this fact for a few weeks now.

Technical details

All changes are yaml. Only a few sprites were added. I followed the station map yaml as an example to get me to a working setup so there may be some optimization to be had here. I also wanted to have screen boards be printable in a lathe but I've run into a roadblock with getting it to appear in the lathe. I was also curious if there is any concerns with screens generating lag on the server. Not sure if thats even an issue to be worried about but worst case the screen board can be left hidden from the lathe. I did observe what seemed to be some inconsistencies with the yaml for station maps. Those inconsistencies are present here because I wasn't sure if they were intentional or not. (referring to how in one file door_electronics is used and in the next airalarm_electronics is used.) I can of course change this if so desired.

Media

screen_frame0
screen_frame1
screen_frame2

Requirements

Breaking changes

Shouldn't be... I hope?

Changelog

🆑

  • new: Screens can now be built from scratch and deconstructed in their entirety.

@github-actions github-actions bot added Changes: No C# Changes: Requires no C# knowledge to review or fix this item. Changes: Sprites Changes: Might require knowledge of spriting or visual design. S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. size/M Denotes a PR that changes 100-999 lines. labels Feb 1, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 1, 2025 •
edited
Loading

RSI Diff Bot; head commit 99560ab merging into 1f5fab5
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Structures/Wallmounts/screen.rsi

State Old New Status
screen_frame0 Added
screen_frame1 Added
screen_frame2 Added

Edit: diff updated after 99560ab

@ArtisticRoomba ArtisticRoomba added P3: Standard Priority: Default priority for repository items. T: New Feature Type: New feature or content, or extending existing content S: Needs Review Status: Requires additional reviews before being fully accepted DB: Beginner Friendly Difficulty: Great for beginners. Unambiguous in scope, and explains how to achieve the result. A: General Interactions Area: General in-game interactions that don't relate to another area. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Feb 2, 2025
ArtisticRoomba
ArtisticRoomba approved these changes Feb 2, 2025
View reviewed changes
Copy link
Contributor

@ArtisticRoomba ArtisticRoomba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@VerinSenpai
Copy link
Author

I appear to have an issue where screen boards aren't showing up in the lathes. you wouldn't happen to know why this is @ArtisticRoomba ?

@ArtisticRoomba
Copy link
Contributor

If you want it added to the lathe, you have to create a recipe for the board and then add that recipe to the static lathe recipes to the lathe you want to add it to.

@ArtisticRoomba
Copy link
Contributor

You can see an example of this in this PR: #31996

@VerinSenpai
removed the space after the end.
47ade45
@VerinSenpai
add an indent.
33069d2 
pretty sure this isn't needed but the other one had the space so consistency.
@VerinSenpai
add screen electronics to lathe
d8bcf66
@VerinSenpai
Copy link
Author

Righty o. I was most the way there, just didn't update lathe.yml. Should I make a sprite for screen electronics or are they good to just use the door electronics sprite?

@ArtisticRoomba
Copy link
Contributor

You're good to use the same sprite state.

@VerinSenpai
Copy link
Author

VerinSenpai commented Feb 2, 2025 •
edited
Loading

Todo: maybe put a bit more effort into the last build stage sprite.

@VerinSenpai
Copy link
Author

bit more happy with that one. hopefully ya'll agree because I'm not exactly known for my sprite work >.>

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 7, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Feb 7, 2025
@github-actions github-actions bot removed the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Feb 7, 2025
@VerinSenpai
Copy link
Author

wait... what did... I can't tell if I did that right. will have to review when I get home. Laptop screens and sunlight don't mix well.

@VerinSenpai
Copy link
Author

alright, I definitely probably just inadvertently revered #33095 in the astronomically unlikely event someone decides to review and merge this today: don't.

@VerinSenpai
Copy link
Author

fixed, good to review.

@VerinSenpai
Copy link
Author

bro, how did I misspell reverted twice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArtisticRoomba ArtisticRoomba ArtisticRoomba approved these changes

Assignees
No one assigned
Labels
A: General Interactions Area: General in-game interactions that don't relate to another area. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. Changes: Sprites Changes: Might require knowledge of spriting or visual design. DB: Beginner Friendly Difficulty: Great for beginners. Unambiguous in scope, and explains how to achieve the result. P3: Standard Priority: Default priority for repository items. S: Needs Review Status: Requires additional reviews before being fully accepted size/M Denotes a PR that changes 100-999 lines. T: New Feature Type: New feature or content, or extending existing content
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Timer Frames from the Display Screens are impossible to deconstruct
2 participants
@VerinSenpai @ArtisticRoomba