Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Gold and Coal Rock Anomalies #34809

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Firewars763
Copy link

About the PR

Adds two new rock anomaly types, one that generates gold ore and another that generates coal ore. Both of these anomalies have respective ore crab variants as well as new crystal colors and light tubes.

Why / Balance

I found it strange that we had rock anomalies for silver ore but not gold, so I decided to add it myself. On another point, added the coal anomaly because of the following issue: #33890

This could potentially allow Science to get access to gold easier, however it will still require the use of an Ore Processor.

Technical details

I simply cloned the existing Silver Rock anomaly and swapped out the ore and creature spawns for new ones. The art is just recolored versions of the Silver and Iron Ore Crab.
I did the same thing with the crystals and lights.

Media

image

Requirements

Breaking changes

Changelog

🆑

  • add: Added gold and coal rock anomalies and ore crab enemies.
  • add: Added yellow and black crystals, crystal shards, and light tubes.

@github-actions github-actions bot added S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. Changes: Sprites Changes: Might require knowledge of spriting or visual design. size/M Denotes a PR that changes 100-999 lines. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Feb 1, 2025
Copy link
Contributor

github-actions bot commented Feb 1, 2025

RSI Diff Bot; head commit 86d13d1 merging into 6beb8e4
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Effects/mobspawn.rsi

State Old New Status
crab_coal Added
crab_gold Added

Resources/Textures/Mobs/Elemental/orecrab.rsi

State Old New Status
coal_crab Added
gold_crab Added

Edit: diff updated after 86d13d1

@Firewars763
Copy link
Author

Also this is my first ever PR on here so let me know if I screwed anything up.

@beck-thompson beck-thompson self-assigned this Feb 1, 2025
@beck-thompson beck-thompson added T: New Feature Type: New feature or content, or extending existing content D3: Low Difficulty: Some codebase knowledge required. S: Needs Review Status: Requires additional reviews before being fully accepted A: Science Area: Science department, not including Silicons. labels Feb 1, 2025
@SoulFN
Copy link
Contributor

SoulFN commented Feb 2, 2025

Black light tubes is real

@Anno-Midi
Copy link

Only issue with this I see is that it makes getting a rock anom significantly more likely then the others

@slarticodefast
Copy link
Member

slarticodefast commented Feb 2, 2025

Only issue with this I see is that it makes getting a rock anom significantly more likely then the other

The RandomRockAnomalySpawner should already handle that so that all rock anomalies have the same cumulative weight as the other types.

Copy link
Contributor

@beck-thompson beck-thompson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! The only weird thing is the odd light values for black light tubes and crystals but it seems to work fine. Its kind of weird and I like it!

@beck-thompson beck-thompson added the S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. label Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: Science Area: Science department, not including Silicons. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. Changes: Sprites Changes: Might require knowledge of spriting or visual design. D3: Low Difficulty: Some codebase knowledge required. S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. S: Needs Review Status: Requires additional reviews before being fully accepted size/M Denotes a PR that changes 100-999 lines. T: New Feature Type: New feature or content, or extending existing content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants