Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tool Box Resprite #34871

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from
Draft

Conversation

ps3moira
Copy link
Contributor

@ps3moira ps3moira commented Feb 4, 2025

About the PR

Resprited the toolbox sprite

Why / Balance

The art direction for objects that are supposed to look 3D will be in a cabinet-perspective and makes the art style more consistent with Cabinet PR.

Media

image

Changelog
🆑
no fun

@github-actions github-actions bot added S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. Changes: Sprites Changes: Might require knowledge of spriting or visual design. size/S Denotes a PR that changes 10-99 lines. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Feb 4, 2025
Copy link
Contributor

github-actions bot commented Feb 4, 2025

RSI Diff Bot; head commit 27beff7 merging into 1d5b011
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Objects/Tools/Toolboxes/toolbox_blue.rsi

State Old New Status
icon-open Modified
icon Modified
inhand-left Modified
inhand-right Modified

Resources/Textures/Objects/Tools/Toolboxes/toolbox_gold.rsi

State Old New Status
icon-open Modified
icon Modified
inhand-left Modified
inhand-right Modified

Resources/Textures/Objects/Tools/Toolboxes/toolbox_green.rsi

State Old New Status
icon-open Modified
icon Modified
inhand-left Modified
inhand-right Modified

Resources/Textures/Objects/Tools/Toolboxes/toolbox_red.rsi

State Old New Status
icon-open Modified
icon Modified
inhand-left Modified
inhand-right Modified

Resources/Textures/Objects/Tools/Toolboxes/toolbox_syn.rsi

State Old New Status
icon-open Modified
icon Modified
inhand-left Modified
inhand-right Modified

Resources/Textures/Objects/Tools/Toolboxes/toolbox_thief.rsi

State Old New Status
icon Modified
inhand-left Modified
inhand-right Modified

Resources/Textures/Objects/Tools/Toolboxes/toolbox_yellow.rsi

State Old New Status
icon-open Modified
icon Modified
inhand-left Modified
inhand-right Modified

Edit: diff updated after 27beff7

@ps3moira ps3moira marked this pull request as ready for review February 4, 2025 06:44
@Emisse
Copy link
Contributor

Emisse commented Feb 4, 2025

needs open/close states

@Djungelskog2
Copy link

My issue here isnt the cabinet perspective but how the sprites make the toolbox look uneven, sloped on the front and lop-sided in shape. im not quite sure on the size since they look a bit big in the screenshots, but the actual sprites/shape of the sprites are triggering me

@UbaserB
Copy link
Member

UbaserB commented Feb 4, 2025

My issue here isnt the cabinet perspective but how the sprites make the toolbox look uneven, sloped on the front and lop-sided in shape. im not quite sure on the size since they look a bit big in the screenshots, but the actual sprites/shape of the sprites are triggering me

Agreed. Fix the sprite so it doesn't look like this. The side view is the problem here.

image

@SlimmSlamm
Copy link
Contributor

these are really ugly sprites. the tool box is fine right now and has a good sprite i dont know why it needs to be changed

@slarticodefast
Copy link
Member

slarticodefast commented Feb 4, 2025

I understand the plan for cabinettification to make sprites more consistent, but this one feels a little flat with the weaker shading (I liked what the old one did there) and the perspective feels a little warped. Also the handle sticking out on top should maybe be a pixel lower so it feels more three dimensional.
Quick, amateurish mockup of what direction I would go in, which is closer to the old sprite.
grafik
alternative with the top left side shaped differently and the right side slightly darker for shading
grafik
old for comparison:
grafik
and yours so you can see them side by side
grafik

I also prefer the old, less saturated colors, which makes it seem less like a toy and more like a real toolbox.

@UbaserB
Copy link
Member

UbaserB commented Feb 4, 2025

oh also the sus toolbox should look grimier, and the golden one should look shinier

@Pumkin69
Copy link

Pumkin69 commented Feb 5, 2025

slarticodefast's sprites are what i would do instead imo they look a lot better.

@ArtisticRoomba ArtisticRoomba added P3: Standard Priority: Default priority for repository items. S: Needs Review Status: Requires additional reviews before being fully accepted DB: Beginner Friendly Difficulty: Great for beginners. Unambiguous in scope, and explains how to achieve the result. A: Art Area: Art with no implications for other areas. T: Visual Change Type: Deals with changes to art, sprites or other visuals in the game. labels Feb 5, 2025
@ps3moira ps3moira marked this pull request as draft February 6, 2025 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: Art Area: Art with no implications for other areas. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. Changes: Sprites Changes: Might require knowledge of spriting or visual design. DB: Beginner Friendly Difficulty: Great for beginners. Unambiguous in scope, and explains how to achieve the result. P3: Standard Priority: Default priority for repository items. S: Needs Review Status: Requires additional reviews before being fully accepted size/S Denotes a PR that changes 10-99 lines. T: Visual Change Type: Deals with changes to art, sprites or other visuals in the game.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants