Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aegi #34875

Closed
wants to merge 5 commits into from
Closed

Aegi #34875

wants to merge 5 commits into from

Conversation

Farrellka-dev
Copy link
Contributor

About the PR

I've added a new race to counteract the dwarves. Elf-like tall creatures with a stronger body, for survival in the unfriendly environment of space!

Why / Balance

I thought so, if there are small dwarves, then, logically, why not add elves? How would they be worse than the goofy and funny dwarves? And I'm thinking!
They have weaknesses and strengths, however, criticism about balance and ideas are welcome!

Technical details

I decided not to change anything in C#, in case something else doesn't suit my shit code. Just everything you need for a functioning race and a little bit of shit.

Media

image
image
image

Requirements

Breaking changes

Changelog

@github-actions github-actions bot added S: Needs Review Status: Requires additional reviews before being fully accepted S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. Changes: Sprites Changes: Might require knowledge of spriting or visual design. size/L Denotes a PR that changes 1000-4999 lines. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Feb 4, 2025
Copy link
Contributor

github-actions bot commented Feb 4, 2025

RSI Diff Bot; head commit ae4f884 merging into d531a9d
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Mobs/Customization/ears.rsi

State Old New Status
long_ears Removed
long_ears_small Added
long_ears_standard Added
long_ears_tall Added
long_ears_thin Added
long_ears_upwards Added
long_ears_wide Added

Resources/Textures/Mobs/Species/Aegi/organs.rsi

State Old New Status
appendix-inflamed Added
appendix Added
brain-inhand-left Added
brain-inhand-right Added
brain Added
ears Added
eyeball-l Added
eyeball-r Added
eyeballs-inhand-left Added
eyeballs-inhand-right Added
heart-inhand-left Added
heart-inhand-right Added
heart-off Added
heart-on Added
kidney-l Added
kidney-r Added
kidneys-inhand-left Added
kidneys-inhand-right Added
liver-inhand-left Added
liver-inhand-right Added
liver Added
lung-l Added
lung-r Added
lungs-inhand-left Added
lungs-inhand-right Added
muscle Added
nerve Added
stomach-inhand-left Added
stomach-inhand-right Added
stomach Added
tongue Added
vessel Added

Resources/Textures/Mobs/Species/Aegi/parts.rsi

State Old New Status
full Added
head_f Added
head_m Added
l_arm Added
l_foot Added
l_hand Added
l_leg Added
r_arm Added
r_foot Added
r_hand Added
r_leg Added
torso_f Added
torso_m Added

Edit: diff updated after ae4f884

@lzk228
Copy link
Contributor

lzk228 commented Feb 4, 2025

you have to make a design documentation and wait until it's reviewed and merged, before someone will review the code pr

https://github.com/space-wizards/docs

@Kadeo64
Copy link
Contributor

Kadeo64 commented Feb 4, 2025

So... humans. with long ears. and stamina resistance.

I'll destroy you if you start saying that these are just human with long ears. Look at the dwarves and think again.

dwarves at least are short (very visually different) and don't have extra stun resist (to my knowledge). I don't see anything that this species does really uniquely aside from stamina resist powergaming. Humans already have elf ears as a marking and you can roleplay playing as an elf, there doesn't need to be a species around it.

@MozarteanChaos
Copy link

MozarteanChaos commented Feb 4, 2025

why use the aegi specifically for this, instead of making an original species? all it'd take is naming it something different and cutting the elithian alliance out of its guidebook section.

@lzk228 lzk228 added P3: Standard Priority: Default priority for repository items. T: New Feature Type: New feature or content, or extending existing content D3: Low Difficulty: Some codebase knowledge required. A: Character/Species Area: Player characters and species features and content. labels Feb 4, 2025
@Farrellka-dev
Copy link
Contributor Author

you have to make a design documentation and wait until it's reviewed and merged, before someone will review the code pr

https://github.com/space-wizards/docs

Лазик, документацию на что говоришь надо? А то чутка не вдупляю.

@Farrellka-dev
Copy link
Contributor Author

So... humans. with long ears. and stamina resistance.

I'll destroy you if you start saying that these are just human with long ears. Look at the dwarves and think again.

dwarves at least are short (very visually different) and don't have extra stun resist (to my knowledge). I don't see anything that this species does really uniquely aside from stamina resist powergaming. Humans already have elf ears as a marking and you can roleplay playing as an elf, there doesn't need to be a species around it.

Yes, but we also have an interesting oxygen thing.
You say people have ears, but look at them, they're shit...
then let's add the option to choose a Dwarven accent and remove the dwarves.

@Farrellka-dev
Copy link
Contributor Author

why use the aegi specifically for this, instead of making an original species? all it'd take is naming it something different and cutting the elithian alliance out of its guidebook section.

However, it is possible not to call them an elf? Aegi sounds quite concise. Why not?

@lzk228
Copy link
Contributor

lzk228 commented Feb 4, 2025

you have to make a design documentation and wait until it's reviewed and merged, before someone will review the code pr
https://github.com/space-wizards/docs

Лазик, документацию на что говоришь надо? А то чутка не вдупляю.

a design doc for a new species, then maintainer will review it and ask for corrections if needed, so firstly you have correct all design and only after that you can apply all suggested changes to code

@FairlySadPanda
Copy link
Contributor

Hi, roundstart species are flat frozen on Wizden at the moment. You can find the PR freeze categories here:

#8524

Specificially:

Roundstart / player species such as lizards / humans - There is currently no maintainer consensus on what the "minimum" requirements for a round start species is. As such, we decided to freeze them until the species workgroup has been designed.

As such no new species at the moment. I think this also means no removal of species, which is why dwarfs are still in the game?

@Kadeo64
Copy link
Contributor

Kadeo64 commented Feb 4, 2025

Yes, but we also have an interesting oxygen thing.

I don't really think that justifies a whole new species (especially when we have other species with different breathing gimmicks already that are much more distinct)

You say people have ears, but look at them, they're shit...

you can PR new ear markings

then let's add the option to choose a Dwarven accent and remove the dwarves.

i'm all for adding scottish accent and removing dwarves provided there's some kind of height system to replace them, short species are funny

@kosticia
Copy link
Contributor

kosticia commented Feb 4, 2025

Biggest part of changes in Resources/Prototypes/Body/Organs/aegi.yml actually useless, look how its done in Resources/Prototypes/Body/Organs/dwarf.yml. Also... 5% resist? Its even sounds like joke. Also I don't think that elves deserves entire race, marking is enough.

@Farrellka-dev
Copy link
Contributor Author

Yes, but we also have an interesting oxygen thing.

I don't really think that justifies a whole new species (especially when we have other species with different breathing gimmicks already that are much more distinct)

Haha, I already am, but even the Wizdens don't care.
#33572

@beck-thompson
Copy link
Contributor

Hey! Unfortunately I do have to close this PR. As others have stated, new species are currently frozen and for new species to be added, they have to have some unique mechanics that make them stand out against the species currently in the game.

How would they be worse than the goofy and funny dwarves? And I'm thinking!

This is a very good point! However, the only reason dwarves are currently in the game is because they were added before this requirement became a thing. If someone were to PR dwarves now, they would also be denied. In the future, we are hoping to roll dwarves and humans into one roundstart species but there needs to be work on displacement maps for smaller species first.

I'll take a look at #33572 as well!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: Character/Species Area: Player characters and species features and content. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. Changes: Sprites Changes: Might require knowledge of spriting or visual design. D3: Low Difficulty: Some codebase knowledge required. P3: Standard Priority: Default priority for repository items. S: Needs Review Status: Requires additional reviews before being fully accepted size/L Denotes a PR that changes 1000-4999 lines. T: New Feature Type: New feature or content, or extending existing content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants