-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Aegi #34875
Aegi #34875
Conversation
RSI Diff Bot; head commit ae4f884 merging into d531a9d Resources/Textures/Mobs/Customization/ears.rsi
Resources/Textures/Mobs/Species/Aegi/organs.rsi
Resources/Textures/Mobs/Species/Aegi/parts.rsi
|
you have to make a design documentation and wait until it's reviewed and merged, before someone will review the code pr |
So... humans. with long ears. and stamina resistance.
dwarves at least are short (very visually different) and don't have extra stun resist (to my knowledge). I don't see anything that this species does really uniquely aside from stamina resist powergaming. Humans already have elf ears as a marking and you can roleplay playing as an elf, there doesn't need to be a species around it. |
why use the aegi specifically for this, instead of making an original species? all it'd take is naming it something different and cutting the elithian alliance out of its guidebook section. |
Лазик, документацию на что говоришь надо? А то чутка не вдупляю. |
Yes, but we also have an interesting oxygen thing. |
However, it is possible not to call them an elf? Aegi sounds quite concise. Why not? |
a design doc for a new species, then maintainer will review it and ask for corrections if needed, so firstly you have correct all design and only after that you can apply all suggested changes to code |
Hi, roundstart species are flat frozen on Wizden at the moment. You can find the PR freeze categories here: Specificially:
As such no new species at the moment. I think this also means no removal of species, which is why dwarfs are still in the game? |
I don't really think that justifies a whole new species (especially when we have other species with different breathing gimmicks already that are much more distinct)
you can PR new ear markings
i'm all for adding scottish accent and removing dwarves provided there's some kind of height system to replace them, short species are funny |
Biggest part of changes in Resources/Prototypes/Body/Organs/aegi.yml actually useless, look how its done in Resources/Prototypes/Body/Organs/dwarf.yml. Also... 5% resist? Its even sounds like joke. Also I don't think that elves deserves entire race, marking is enough. |
Haha, I already am, but even the Wizdens don't care. |
Hey! Unfortunately I do have to close this PR. As others have stated, new species are currently frozen and for new species to be added, they have to have some unique mechanics that make them stand out against the species currently in the game.
This is a very good point! However, the only reason dwarves are currently in the game is because they were added before this requirement became a thing. If someone were to PR dwarves now, they would also be denied. In the future, we are hoping to roll dwarves and humans into one roundstart species but there needs to be work on displacement maps for smaller species first. I'll take a look at #33572 as well! |
About the PR
I've added a new race to counteract the dwarves. Elf-like tall creatures with a stronger body, for survival in the unfriendly environment of space!
Why / Balance
I thought so, if there are small dwarves, then, logically, why not add elves? How would they be worse than the goofy and funny dwarves? And I'm thinking!
They have weaknesses and strengths, however, criticism about balance and ideas are welcome!
Technical details
I decided not to change anything in C#, in case something else doesn't suit my shit code. Just everything you need for a functioning race and a little bit of shit.
Media
Requirements
Breaking changes
Changelog