Meat Patty #34896
Open
Meat Patty #34896
+90
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
S: Untriaged
ArtisticRoomba
suggested changes
Feb 5, 2025
Comment on lines
330
to
332
|
|
||
|
|
||
| # patty |
There was a problem hiding this comment.
remove this if you decided to move the graph to its own file
Comment on lines
177
to
192
| # meat patty "steak" | ||
| - type: constructionGraph | ||
| id: CookedPatty | ||
| start: start | ||
| graph: | ||
| - node: start | ||
| edges: | ||
| - to: cooked meat patty | ||
| completed: | ||
| - !type:PlaySound | ||
| sound: /Audio/Effects/sizzle.ogg | ||
| steps: | ||
| - minTemperature: 335 | ||
| - node: cooked meat patty | ||
| entity: FoodMeatPattyCooked | ||
|
|
There was a problem hiding this comment.
I would just have this in the patty yml for clarity. But that's my opinion.
ArtisticRoomba
added
P3: Standard
ArtisticRoomba
suggested changes
Feb 5, 2025
| @@ -1,7 +1,7 @@ | |||
| { | |||
| "version": 1, | |||
| "license": "CC-BY-SA-3.0", | |||
| "copyright": "Taken from tgstation and modified by Swept, potato1234x and deltanedas at https://github.com/tgstation/tgstation/commit/40d75cc340c63582fb66ce15bf75a36115f6bdaa, snail by IproduceWidgets (github) and Kezu (discord), anomalymeat/cooked by august-sun", | |||
| "copyright": "Taken from tgstation and modified by Swept, potato1234x and deltanedas at https://github.com/tgstation/tgstation/commit/40d75cc340c63582fb66ce15bf75a36115f6bdaa, snail by IproduceWidgets (github) and Kezu (discord), anomalymeat/cooked by august-sun, raw and cooked patty taken from tgstation at https://github.com/tgstation/tgstation/blob/465f654548bc123c1f5846f135a0ed4897c5f6f0/icons/obj/food/meat.dmi", | |||
There was a problem hiding this comment.
You'll want to reference the exact commit you took it from, not a blob.
Emisse
approved these changes
Feb 9, 2025
|
art approval |
ArtisticRoomba
approved these changes
Feb 9, 2025
There was a problem hiding this comment.
Everything looks good and works as intended in-game.
A maint might have more comments as to where you should put the construction graphs, they might be best slotted in a similar file instead of having their own file (sorry I told you to do this earlier) but alas.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Why / Balance
First step in a longer process to potentially revamp cooking in SS14 in line with how it's done in /tg/ or fulpstation for added cooking complexity and gameplay. Will look into using it for hamburger recipes next.
Technical details
Media
Requirements
Changelog
🆑