Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emisse told me I can name it the grinch #34905

Merged
merged 4 commits into from
Feb 5, 2025

Conversation

Errant-4
Copy link
Member

@Errant-4 Errant-4 commented Feb 5, 2025

About the PR

Revert the engine submodule to 240.1.2

Revert the following PRs:
Storage sidebar fix (#34680)
Storage UI V2 (#33045)
Update ScalingViewport for Engine PR (#28786)

@github-actions github-actions bot added Branch: Staging Intended to be merged into Staging. S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. Changes: UI Changes: Might require knowledge of UI design or code. size/L Denotes a PR that changes 1000-4999 lines. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Feb 5, 2025
@VasilisThePikachu VasilisThePikachu merged commit 6824ab4 into space-wizards:staging Feb 5, 2025
15 of 16 checks passed
@Errant-4 Errant-4 deleted the staging-test branch February 6, 2025 00:40
@dffdff2423
Copy link
Contributor

Are the PRs linked here going to be permanently reverted? Or is this just a temporary thing?

@VasilisThePikachu
Copy link
Member

Are the PRs linked here going to be permanently reverted? Or is this just a temporary thing?

Temporary so that we could push out publish (we had already delayed it 2 days then usual)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Branch: Staging Intended to be merged into Staging. Changes: UI Changes: Might require knowledge of UI design or code. size/L Denotes a PR that changes 1000-4999 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants