Add new freezer atmos devices and fix freezer fixgridatmos marker #34991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
S: Needs Review
ArtisticRoomba
added
T: Bugfix
…he freezer in Atmospherics.cs
Partmedia
approved these changes
Feb 11, 2025
Partmedia
reviewed
Feb 11, 2025
Comment on lines
+120
to
+123
| upperBound: !type:AlarmThresholdSetting | ||
| threshold: 335.15 # T-38.15C (235) + 100 | ||
| lowerBound: !type:AlarmThresholdSetting | ||
| threshold: 135.15 # T-38.15C (235) - 100 |
There was a problem hiding this comment.
These bounds are quite wide, but in line with the current bounds further up in this file. Someone else can eventually adjust this later.
There was a problem hiding this comment.
They are, and they'll have to be manually adjusted if the freezer temp is changed.
My plan is to remove the directional fans in freezers when I give every map's freezer a proper atmos setup. Might be nice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Adds new Freezer atmos devices for mapping. These devices have their sensors tuned to the roundstart environment of a freezer, with auto mode off. The solution is similar to that employed by custom Vox alarms that are no longer used.
Fixes the Freezer FixGridAtmos marker to properly pressurize freezer rooms. Previously they were only at 80 kPa due to their molar amounts not being adjusted to a colder environment. Freezers now start at 101.325 kPa at their desired temp.
Maps will need to have FixGridAtmos reran in order for the changes to take effect when this PR is merged.
Why / Balance
Commonly mappers map atmospheric devices into freezers with a connected air alarm. This air alarm will commonly scream at you over the atmospheric alerts computer, because the freezer is not within a safe temperature.
Technical details
Added new threshold, freezerTemperature.
Added new freezer.yml file for holding all of our custom atmos devices with their changed sensor values.
Added new float, FreezerTemp.
Added new float, MolesCellFreezer for determining how many moles we need for a colder room (we'll need more than standard because the room is colder).
Added new floats, OxygenMolesFreezer and NitrogenMolsFreezer, for usage in FixGridAtmos.
Adjusted mixtures[6].AdjustMoles to include new OxygenMolsFreezer and NitrogenMolsFreezer.
Media
Requirements
Changelog
This unfortunately can't get a CL right now because the player-facing changes haven't been made yet.