Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to Hydroponic sprites (added tomatoes, adjustments to previous sprites) #35004

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

Chaoticaa
Copy link

@Chaoticaa Chaoticaa commented Feb 9, 2025

About the PR

Updated some sprites for a few plants in botany. I plan to hopefully be able to contribute changes to some more of them in the future.

Why / Balance

I feel that the sprites for some plants/fruit needed to be updated to some degree.

Technical details

Media

MEATWHEATAPPLEDISPLAY

Requirements

Breaking changes

Changelog

@github-actions github-actions bot added S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. Changes: Sprites Changes: Might require knowledge of spriting or visual design. size/XS Denotes a PR that changes 0-9 lines. labels Feb 9, 2025
Copy link
Contributor

github-actions bot commented Feb 9, 2025

RSI Diff Bot; head commit a5524b5 merging into 082b1f8
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Objects/Specific/Hydroponics/aloe.rsi

State Old New Status
dead Modified
harvest Modified
produce Modified
stage-1 Modified
stage-2 Modified
stage-3 Modified
stage-4 Modified
stage-5 Modified

Resources/Textures/Objects/Specific/Hydroponics/apple.rsi

State Old New Status
dead Modified
harvest Modified
produce Modified
stage-1 Modified
stage-2 Modified
stage-3 Modified
stage-4 Modified
stage-5 Modified
stage-6 Modified

Resources/Textures/Objects/Specific/Hydroponics/banana.rsi

State Old New Status
produce Modified

Resources/Textures/Objects/Specific/Hydroponics/cherry.rsi

State Old New Status
produce Modified

Resources/Textures/Objects/Specific/Hydroponics/corn.rsi

State Old New Status
produce Modified

Resources/Textures/Objects/Specific/Hydroponics/meatwheat.rsi

State Old New Status
dead Modified
harvest Modified
produce Modified
stage-1 Modified
stage-2 Modified
stage-3 Modified
stage-4 Modified
stage-5 Modified
stage-6 Modified

Resources/Textures/Objects/Specific/Hydroponics/pineapple.rsi

State Old New Status
produce Modified

Resources/Textures/Objects/Specific/Hydroponics/sugarcane.rsi

State Old New Status
dead Modified
harvest Modified
produce Modified
stage-1 Modified
stage-2 Modified
stage-3 Modified

Resources/Textures/Objects/Specific/Hydroponics/tomato.rsi

State Old New Status
dead Modified
harvest Modified
produce Modified
stage-1 Modified
stage-2 Modified
stage-3 Modified
stage-4 Modified
stage-5 Modified
stage-6 Modified

Resources/Textures/Objects/Specific/Hydroponics/watermelon.rsi

State Old New Status
harvest Modified
produce Modified
slice Modified

Resources/Textures/Objects/Specific/Hydroponics/wheat.rsi

State Old New Status
dead Modified
harvest Modified
produce Modified
stage-1 Modified
stage-2 Modified
stage-3 Modified
stage-4 Modified
stage-5 Modified
stage-6 Modified

Edit: diff updated after a5524b5

@slarticodefast
Copy link
Member

You might want to adjust the meatwheat sprite as well since it is the same as for normal wheat, but in red.

@ArtisticRoomba ArtisticRoomba added P3: Standard Priority: Default priority for repository items. S: Needs Review Status: Requires additional reviews before being fully accepted DB: Beginner Friendly Difficulty: Great for beginners. Unambiguous in scope, and explains how to achieve the result. A: Art Area: Art with no implications for other areas. T: Visual Change Type: Deals with changes to art, sprites or other visuals in the game. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Feb 9, 2025
@Warpzoned
Copy link

that pineapple looks MOUTH-WATERING, I do have some critiques though:

  • the corn cob is way too small considering the others' sizes, should at least be as big/long as the banana IMHO!
  • the apples feel a bit too "artificial"? unsure how to put it but I think the issue has to do with how big the contrast is between the outlines and the inner colours, try making it a bit more subtle
  • the aloe looks like a pea pod, doesn't really do its in-hydroponics sprite much justice, maybe try making it more "leaf-like"?
  • remove the wheat's strap (and consequentially straighten it a bit more?), this one is more of a nitpick though (and also because chances are someone would say the same thing, since its a bit silly for freshly harvested wheat to have straps on them)

regardless I think its fair to say these sprites in general are much better, good job!

@Chaoticaa
Copy link
Author

that pineapple looks MOUTH-WATERING, I do have some critiques though:

* the corn cob is _way_ too small considering the others' sizes, should at least be as big/long as the banana IMHO!

* the apples feel a bit too "artificial"? unsure how to put it but I think the issue has to do with how big the contrast is between the outlines and the inner colours, try making it a bit more subtle

* the aloe looks like a pea pod, doesn't really do its in-hydroponics sprite much justice, maybe try making it more "leaf-like"?

* remove the wheat's strap (and consequentially straighten it a bit more?), this one is more of a nitpick though (and also because chances are someone would say the same thing, since its a bit silly for freshly harvested wheat to have straps on them)

regardless I think its fair to say these sprites in general are much better, good job!

Thank you for the feed back!

@Chaoticaa Chaoticaa changed the title changes to some hydroponics plant sprites Updates to Hydroponic sprites (added tomatoes, adjustments to previous sprites) Feb 10, 2025
@Chaoticaa
Copy link
Author

that pineapple looks MOUTH-WATERING, I do have some critiques though:

* the corn cob is _way_ too small considering the others' sizes, should at least be as big/long as the banana IMHO!

* the apples feel a bit too "artificial"? unsure how to put it but I think the issue has to do with how big the contrast is between the outlines and the inner colours, try making it a bit more subtle

* the aloe looks like a pea pod, doesn't really do its in-hydroponics sprite much justice, maybe try making it more "leaf-like"?

* remove the wheat's strap (and consequentially straighten it a bit more?), this one is more of a nitpick though (and also because chances are someone would say the same thing, since its a bit silly for freshly harvested wheat to have straps on them)

regardless I think its fair to say these sprites in general are much better, good job!

Made the adjustments to aloe, apple, corn and wheat. You were right about the apple lol, the colour was nuts. Let me know how you like the differences

@slarticodefast
Copy link
Member

The meatwheat plant stages should be adjusted as well, they are a simple recoloring of the old ones for the wheat plant.

@Chaoticaa
Copy link
Author

The meatwheat plant stages should be adjusted as well, they are a simple recoloring of the old ones for the wheat plant.

Will do, plan to do more changes after work

@rokudara-sen
Copy link
Contributor

Those sprites look amazing, great work.

@Chaoticaa
Copy link
Author

Thank you :)

@Warpzoned
Copy link

Warpzoned commented Feb 10, 2025

Made the adjustments to aloe, apple, corn and wheat. You were right about the apple lol, the colour was nuts. Let me know how you like the differences

I love them! the apple's colours definitely look like a step up, and the aloe looks SO much better, some last comments however:

  • now that aloe's silhouette is on-point, I think it could get a lighter palette too! (similarly to how it did before) as it can get confusing between that and ambrosias vulgaris (unless you plan to also re-sprite the aforementioned?), would also require an in-hydroponics tray re-colouring

  • both wheats' "bottom" parts feel... soggy? the shift in colouration makes it feel like so, at least, I think said shift being slightly less drastic to be the better way to go (nitpick, I like the sprites a lot regardless, thanks for removing the strap as well!)

  • Q: what do you think of adding "dirty bits" (similarly to how they're done on the banana) to the other fruits? I examined them a bit more closely and compared them to real-life equivalents and I think the "artificial" feel the previous apple gave was also partially due to this, as it felt too "perfect" (cherries suffer from the same problem, albeit at a much smaller scale as the actual fruit's sprites are pretty small)

  • Q: are you planning on going over all botany harvestables? I dig your style a lot and think it'd be awesome if the others also had an art renewal! if not, however, I'd recommend still spriting for blue tomatoes and blood tomatoes, as you've cemented your tomato sprites

once more, awesome work! hope to see this merged

@Chaoticaa
Copy link
Author

Chaoticaa commented Feb 11, 2025

Made the adjustments to aloe, apple, corn and wheat. You were right about the apple lol, the colour was nuts. Let me know how you like the differences

I love them! the apple's colours definitely look like a step up, and the aloe looks SO much better, some last comments however:

* now that aloe's silhouette is on-point, I think it could get a lighter palette too! (similarly to how it did before) as it _can_ get confusing between that and ambrosias vulgaris (unless you plan to also re-sprite the aforementioned?), would also require an in-hydroponics tray re-colouring

* both wheats' "bottom" parts feel... _soggy_? the shift in colouration makes it feel like so, at least, I think said shift being slightly less drastic to be the better way to go (nitpick, I like the sprites a lot regardless, thanks for removing the strap as well!)

* Q: what do you think of adding "dirty bits" (similarly to how they're done on the banana) to the other fruits? I examined them a bit more closely and compared them to real-life equivalents and I think the "artificial" feel the previous apple gave was also partially due to this, as it felt too "perfect" (cherries suffer from the same problem, albeit at a much smaller scale as the actual fruit's sprites are pretty small)

* Q: are you planning on going over _all_ botany harvestables? I dig your style a lot and think it'd be awesome if the others also had an art renewal! if not, however, I'd recommend still spriting for blue tomatoes and blood tomatoes, as you've cemented your tomato sprites

once more, awesome work! hope to see this merged

  • Flaws on some other fruit/veg are a bit more difficult, for instance, a green apple is mostly flawless in real life, but they do have little white spots, or a brown ring where the stem sits, but I probably won't add a bruise to it. I can add a sunspot to the watermelon, some green patches onto the pumpkin, etc.
    For a cherry though, all I could really do is darken the colour to make it a bit more realistic.

  • I can adjust the wheat, definitely. I was starting the feel the same way. The longer I look at some of these, the more things start to bug me and I want to constantly adjust them. I think I'm just going to do most things in bulk now and push less often.

  • I don't plan to do all of them as of yet. I'm not going to touch Deus' mutation, or Deus/Ambrosia in general because I don't know if players would appreciate that if this does get merged. Everyone is used to the way it looks. I also think the Deus mutation harvestable looks quite pretty as is.

I appreciate all your input so far, getting the feedback has been great

Did some of the changes + watermelon and watermelon harvest :)
I think the apple looks a lot better now, no longer radioactive and as realistic as it can be for a sprite! Let me know what you think.
update

@Warpzoned
Copy link

Warpzoned commented Feb 11, 2025

  • now that aloe's silhouette is on-point, I think it could get a lighter palette too! (similarly to how it did before) as it can get confusing between that and ambrosias vulgaris (unless you plan to also re-sprite the aforementioned?), would also require an in-hydroponics tray re-colouring

could you address this one ⬆️ as well? even if you were to be against its recolouring I wanted to know your thoughts on it 👍

  • Flaws on some other fruit/veg are a bit more difficult, for instance, a green apple is mostly flawless in real life, but they do have little white spots, or a brown ring where the stem sits, but I probably won't add a bruise to it. I can add a sunspot to the watermelon, some green patches onto the pumpkin, etc.
    For a cherry though, all I could really do is darken the colour to make it a bit more realistic.

I see, they do look much better though! no issues here 👍

  • I can adjust the wheat, definitely. I was starting the feel the same way. The longer I look at some of these, the more things start to bug me and I want to constantly adjust them. I think I'm just going to do most things in bulk now and push less often.

alas the terrors of spriting, one night it looks great and the very next morning you have to redo something entirely, we're our own greatest critics, regardless it looks much better now! I have however been thinking and I think the part that "holds" them both together could be made slightly lower than in the middle, let me know what you think

  • I don't plan to do all of them as of yet. I'm not going to touch Deus' mutation, or Deus/Ambrosia in general because I don't know if players would appreciate that if this does get merged. Everyone is used to the way it looks. I also think the Deus mutation harvestable looks quite pretty as is.

I see, makes sense as I wouldn't call the ambrosia's sprites faulty in any way either, though it could prove to be in an inconsistent style if this were to be merged, but it should be a non-issue

I appreciate all your input so far, getting the feedback has been great

glad to know! :)

Did some of the changes + watermelon and watermelon harvest :) I think the apple looks a lot better now, no longer radioactive and as realistic as it can be for a sprite! Let me know what you think.

the watermelon looks great! but I think its cut sprite and full sprite are a bit unrelated, either of the two could be or smaller (to accommodate for the cut variant) or bigger (to accommodate for the full variant), personally I would do the latter, as I think it'd make sense to have the watermelon be bigger in its sprite than most other plants! (I also think it needs some more darkening, since at the moment it looks very "gem-like", a nitpick, though)

put some stuff down, awesome work you've done, kudos!

@Chaoticaa
Copy link
Author

  • now that aloe's silhouette is on-point, I think it could get a lighter palette too! (similarly to how it did before) as it can get confusing between that and ambrosias vulgaris (unless you plan to also re-sprite the aforementioned?), would also require an in-hydroponics tray re-colouring

could you address this one ⬆️ as well? even if you were to be against its recolouring I wanted to know your thoughts on it 👍

For the aloe, I think I may adjust all of that later on down the track but I don't want to go too light with it. I do however think it looks closer to the tobacco leaf more than the ambrosia leaf, so I will eventually lighten it up a bit.

  • Flaws on some other fruit/veg are a bit more difficult, for instance, a green apple is mostly flawless in real life, but they do have little white spots, or a brown ring where the stem sits, but I probably won't add a bruise to it. I can add a sunspot to the watermelon, some green patches onto the pumpkin, etc.
    For a cherry though, all I could really do is darken the colour to make it a bit more realistic.

I see, they do look much better though! no issues here 👍

  • I can adjust the wheat, definitely. I was starting the feel the same way. The longer I look at some of these, the more things start to bug me and I want to constantly adjust them. I think I'm just going to do most things in bulk now and push less often.

alas the terrors of spriting, one night it looks great and the very next morning you have to redo something entirely, we're our own greatest critics, regardless it looks much better now! I have however been thinking and I think the part that "holds" them both together could be made slightly lower than in the middle, let me know what you think

Exactly!
Good point on the wheat, I think it's because I didn't bother to adjust it after removing the strap. Although I just don't want the wheat to be too wide ingame, for some reason that bothers me. But I'll adjust.

  • I don't plan to do all of them as of yet. I'm not going to touch Deus' mutation, or Deus/Ambrosia in general because I don't know if players would appreciate that if this does get merged. Everyone is used to the way it looks. I also think the Deus mutation harvestable looks quite pretty as is.

I see, makes sense as I wouldn't call the ambrosia's sprites faulty in any way either, though it could prove to be in an inconsistent style if this were to be merged, but it should be a non-issue

I appreciate all your input so far, getting the feedback has been great

glad to know! :)

Did some of the changes + watermelon and watermelon harvest :) I think the apple looks a lot better now, no longer radioactive and as realistic as it can be for a sprite! Let me know what you think.

the watermelon looks great! but I think its cut sprite and full sprite are a bit unrelated, either of the two could be or smaller (to accommodate for the cut variant) or bigger (to accommodate for the full variant), personally I would do the latter, as I think it'd make sense to have the watermelon be bigger in its sprite than most other plants! (I also think it needs some more darkening, since at the moment it looks very "gem-like", a nitpick, though)

I get what you're saying, I actually just recoloured the slice sprite that already existed instead of making a new one. Immediately after pushing the watermelon, I wanted to shorten it to some degree.

For the slice sprite though, are you also referring to the angle of the slice? Technically the full watermelon sprite is facing towards you, but the slice is on a bit of an angle. I think that's what you might be referring to as well as the size? Like you want the slice to be facing straight on?

put some stuff down, awesome work you've done, kudos!

@Warpzoned
Copy link

For the aloe, I think I may adjust all of that later on down the track but I don't want to go too light with it. I do however think it looks closer to the tobacco leaf more than the ambrosia leaf, so I will eventually lighten it up a bit.

good point, feel free to do this at your own discretion!

Exactly! Good point on the wheat, I think it's because I didn't bother to adjust it after removing the strap. Although I just don't want the wheat to be too wide ingame, for some reason that bothers me. But I'll adjust.

👍

I get what you're saying, I actually just recoloured the slice sprite that already existed instead of making a new one. Immediately after pushing the watermelon, I wanted to shorten it to some degree.

For the slice sprite though, are you also referring to the angle of the slice? Technically the full watermelon sprite is facing towards you, but the slice is on a bit of an angle. I think that's what you might be referring to as well as the size? Like you want the slice to be facing straight on?

I think so, yes? I was thinking that the slice looked a bit unproportionate when the watermelon is that big, does that mean that the current sprite is cut from somewhere that isnt top-down 🤔? I was thinking that it would make more sense if the slice's total length was the same as the uncut's as to simulate it being cut "vertically" (think of it as if the watermelon was standing up) like this

@Chaoticaa
Copy link
Author

Chaoticaa commented Feb 11, 2025

For the aloe, I think I may adjust all of that later on down the track but I don't want to go too light with it. I do however think it looks closer to the tobacco leaf more than the ambrosia leaf, so I will eventually lighten it up a bit.

good point, feel free to do this at your own discretion!

Exactly! Good point on the wheat, I think it's because I didn't bother to adjust it after removing the strap. Although I just don't want the wheat to be too wide ingame, for some reason that bothers me. But I'll adjust.

👍

I get what you're saying, I actually just recoloured the slice sprite that already existed instead of making a new one. Immediately after pushing the watermelon, I wanted to shorten it to some degree.
For the slice sprite though, are you also referring to the angle of the slice? Technically the full watermelon sprite is facing towards you, but the slice is on a bit of an angle. I think that's what you might be referring to as well as the size? Like you want the slice to be facing straight on?

I think so, yes? I was thinking that the slice looked a bit unproportionate when the watermelon is that big, does that mean that the current sprite is cut from somewhere that isnt top-down 🤔? I was thinking that it would make more sense if the slice's total length was the same as the uncut's as to simulate it being cut "vertically" (think of it as if the watermelon was standing up) like this

Ah yes, I get what you mean :D
It's not that the current one isn't cut from top down, it's just that it's not facing straight ahead.
It's angled sort of like this.
watermelon-slice-all-white-photorealism-260nw-2478305379

But yeah, I can just that pretty easily.

@Warpzoned
Copy link

Ah yes, I get what you mean :D It's not that the current one isn't cut from top down, it's just that it's not facing straight ahead. It's angled sort of like this. watermelon-slice-all-white-photorealism-260nw-2478305379

But yeah, I can just that pretty easily.

oh I see! I do think that'd probably be better as a slice of a slice 😆, its probably out of scope for this PR, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: Art Area: Art with no implications for other areas. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. Changes: Sprites Changes: Might require knowledge of spriting or visual design. DB: Beginner Friendly Difficulty: Great for beginners. Unambiguous in scope, and explains how to achieve the result. P3: Standard Priority: Default priority for repository items. S: Needs Review Status: Requires additional reviews before being fully accepted size/XS Denotes a PR that changes 0-9 lines. T: Visual Change Type: Deals with changes to art, sprites or other visuals in the game.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants