Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Centcomm carapace, moved armour from vests.yml to armor.yml #35301

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Centcomm carapace, moved armour from vests.yml to armor.yml #35301

wants to merge 3 commits into from
+153 −104

Conversation

K-Dynamic
Copy link
Contributor

About the PR

  • Added centcomm carapace
  • CC officials now start with centcom carapaces
  • Moved armoured vests from vests.yml to armor.yml

Why / Balance

Items like the captain's carapace are more than likely to be regularly issued to NT staff, and thus they shouldn't be wearing regular Type I armour vests.

Unlike the station crew, CC officials are routinely equipped with the finest gear.

Reorganised vests.yml to only feature cosmetic or utility vests, with all armour moved to armor.yml. Within armor.yml are two sections; one section for chest armour, the other section for body armour (extending to limbs).

Technical details

yml and rsi changes

Media

image

Requirements

Breaking changes

N/A

Changelog

admin 🆑

  • add: CC officials now wear a centcomm carapace for body armour, which have identical stats to the command carapace.

@github-actions github-actions bot added size/M Denotes a PR that changes 100-999 lines. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. Changes: Sprites Changes: Might require knowledge of spriting or visual design. S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Feb 19, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 19, 2025 •
edited
Loading

RSI Diff Bot; head commit 962f620 merging into 2a124ad
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Clothing/OuterClothing/Armor/centcomm_carapace.rsi

State Old New Status
equipped-OUTERCLOTHING-vox Added
equipped-OUTERCLOTHING Added
icon Added
inhand-left Added
inhand-right Added

Edit: diff updated after 962f620

@ArtisticRoomba
Copy link
Contributor

it looks good but i would suggest atomizing the cleanup and new feature parts into separate PRs

@ArtisticRoomba ArtisticRoomba added T: New Feature Type: New feature or content, or extending existing content T: Cleanup Type: Code clean-up, without being a full refactor or feature S: Needs Review Status: Requires additional reviews before being fully accepted DB: Beginner Friendly Difficulty: Great for beginners. Unambiguous in scope, and explains how to achieve the result. A: Command Area: Command department, where it isn't applicable to other departments. P3: Standard Priority: Default priority for repository items. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Feb 19, 2025
@K-Dynamic
Copy link
Contributor Author

Test fail unrelated

SolsticeOfTheWinter added a commit to SolsticeOfTheWinter/Goob-Station that referenced this pull request Feb 19, 2025
@SolsticeOfTheWinter
Ported Centcomm Carapce from space-wizards/space-station-14#35301
c66cbec
@SolsticeOfTheWinter SolsticeOfTheWinter mentioned this pull request Feb 19, 2025
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArtisticRoomba ArtisticRoomba ArtisticRoomba requested changes

Assignees
No one assigned
Labels
A: Command Area: Command department, where it isn't applicable to other departments. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. Changes: Sprites Changes: Might require knowledge of spriting or visual design. DB: Beginner Friendly Difficulty: Great for beginners. Unambiguous in scope, and explains how to achieve the result. P3: Standard Priority: Default priority for repository items. S: Needs Review Status: Requires additional reviews before being fully accepted size/M Denotes a PR that changes 100-999 lines. T: Cleanup Type: Code clean-up, without being a full refactor or feature T: New Feature Type: New feature or content, or extending existing content
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@K-Dynamic @ArtisticRoomba