Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Returns Explosive Technology recipes to Protolathes #35303

Merged
merged 1 commit into from
Feb 19, 2025
Merged

Returns Explosive Technology recipes to Protolathes #35303

merged 1 commit into from
Feb 19, 2025

Conversation

K-Dynamic
Copy link
Contributor

About the PR

  • Returns Explosive Technology recipes to the Protolathe

Why / Balance

Fixes #35300

PR that removed the recipes didn't document their removal or reasoning for doing so.

Technical details

yml change only

Media

image
image

Requirements

Breaking changes

Changelog

🆑

  • fix: Returned Explosive Technology recipes (triggers, payloads, signaller) back to the Protolathe following undocumented removal.

@github-actions github-actions bot added S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. size/XS Denotes a PR that changes 0-9 lines. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. and removed size/XS Denotes a PR that changes 0-9 lines. labels Feb 19, 2025
@K-Dynamic
Copy link
Contributor Author

test fail unrelated (it's affecting every PR atm)

@ArtisticRoomba ArtisticRoomba added T: Bugfix Type: Bugs and/or bugfixes P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention. S: Needs Review Status: Requires additional reviews before being fully accepted DB: Beginner Friendly Difficulty: Great for beginners. Unambiguous in scope, and explains how to achieve the result. A: General Interactions Area: General in-game interactions that don't relate to another area. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Feb 19, 2025
@ArtisticRoomba
Copy link
Contributor

yep this was unintended

@slarticodefast slarticodefast added S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. and removed S: Needs Review Status: Requires additional reviews before being fully accepted labels Feb 19, 2025
@slarticodefast slarticodefast self-assigned this Feb 19, 2025
@Tayrtahn Tayrtahn merged commit 5f41726 into space-wizards:master Feb 19, 2025
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tayrtahn Tayrtahn Tayrtahn approved these changes

@slarticodefast slarticodefast slarticodefast approved these changes

Assignees

@slarticodefast slarticodefast

Labels
A: General Interactions Area: General in-game interactions that don't relate to another area. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. DB: Beginner Friendly Difficulty: Great for beginners. Unambiguous in scope, and explains how to achieve the result. P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention. S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. T: Bugfix Type: Bugs and/or bugfixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ScienceExplosives lathe recipe pack is not used
4 participants
@K-Dynamic @ArtisticRoomba @Tayrtahn @slarticodefast