Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add enable_well_known_secret_masking field #553

Merged

Conversation

ilya-hontarau
Copy link
Contributor

@ilya-hontarau ilya-hontarau commented May 16, 2024

Description of the change

Description here

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (non-breaking change that adds documentation)

Related issues

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development
  • Examples for new resources and data sources have been added
  • Default values have been documented in the description (e.g., "Dummy: (Boolean) Blah blah. Defaults to false.)
  • If the action fails that checks the documentation: Run go generate to make sure the docs are up to date

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • Pull Request is no longer marked as "draft"
  • Reviewers have been assigned
  • Changes have been reviewed by at least one other engineer

@ilya-hontarau ilya-hontarau requested a review from peterdeme May 16, 2024 12:31
@ilya-hontarau ilya-hontarau marked this pull request as ready for review May 16, 2024 12:34
Copy link
Contributor

@peterdeme peterdeme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, nice job

@ilya-hontarau ilya-hontarau requested a review from a team May 16, 2024 12:36
@ilya-hontarau ilya-hontarau merged commit 7bc5ffe into main May 16, 2024
7 checks passed
@ilya-hontarau ilya-hontarau deleted the feature/add-enable_well_known_secret_masking-to-stack branch May 16, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants