Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test cases list creation #49

Merged
merged 8 commits into from
Aug 14, 2024
Merged

Test cases list creation #49

merged 8 commits into from
Aug 14, 2024

Conversation

monikasmolarek
Copy link
Collaborator

I created a doc covering the test cases that should be covered while testing the lite wallet manually.
It aims to help remember what and how to tests, but also to track the results.

For now only 3 main processes starting from the main page.
The wallet screen and all the components, options, and settings will be added soon.

@monikasmolarek monikasmolarek added the documentation Improvements or additions to documentation label Jul 24, 2024
@monikasmolarek monikasmolarek self-assigned this Jul 24, 2024
Copy link

You can preview the changes at : https://0dc5601f.smapp-lite-prod.pages.dev

Copy link

You can preview the changes at : https://642caa60.smapp-lite-prod.pages.dev

Copy link

You can preview the changes at : https://2747eea3.smapp-lite-prod.pages.dev

Copy link

github-actions bot commented Aug 1, 2024

You can preview the changes at : https://b12d59ae.smapp-lite-prod.pages.dev

TestCases.md Outdated

# Log in / Log out

1. Verify that navigating to `https://wallet.spacemesh.io/` redirects instantly to `https://wallet.spacemesh.io/unlock`.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One of the last commits changed it. Also it should redirect only after reload page, not all the time.
Like https://wallet.spacemesh.io/#/ shall redirect to https://wallet.spacemesh.io/#/wallet

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is specifically about the log in functionality, very narrow. Not about the page reloads and redirects in general. It's only about whether the app behaves correctly when we want to log in to the wallet, so the moment that we have our wallet set up and we open the browser and want to log in. So if someone goes to /#/ or /#/wallet, he should be redirected to login.
I will reformulate it as follows:

Suggested change
1. Verify that navigating to `https://wallet.spacemesh.io/` redirects instantly to `https://wallet.spacemesh.io/unlock`.
1. With a wallet correctly set up, and logged out, verify that navigating to any valid link`https://wallet.spacemesh.io/#/[any-existing-path]` redirects instantly to `https://wallet.spacemesh.io/#/unlock`.

Copy link

github-actions bot commented Aug 5, 2024

You can preview the changes at : https://df6f6885.smapp-lite-prod.pages.dev

@monikasmolarek monikasmolarek requested a review from dioexul August 13, 2024 08:56
@monikasmolarek
Copy link
Collaborator Author

@brusherru I will let myself to merge this doc. You can of course move, remove It, do whatever you want. But It would probably make it easier to review the next pull request, as Yulia has already reviewed these ones.
This list is not crucial, but might make it easier to document wallet and test it. I think of using it as a basis to write automatic integration/end-to-end tests in the future. It doesn’t break anything in the code, so merging for now here. I will reorganize it better when it's more robust.

@monikasmolarek monikasmolarek merged commit 1933d9a into main Aug 14, 2024
1 check passed
@monikasmolarek monikasmolarek deleted the test-cases branch August 14, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants