Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test cases list creation #49
Test cases list creation #49
Changes from 7 commits
4dda28a
ca9e321
9420fdd
801b323
edfd4cc
9a7e842
3e6e031
35d75fe
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One of the last commits changed it. Also it should redirect only after reload page, not all the time.
Like https://wallet.spacemesh.io/#/ shall redirect to https://wallet.spacemesh.io/#/wallet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is specifically about the log in functionality, very narrow. Not about the page reloads and redirects in general. It's only about whether the app behaves correctly when we want to log in to the wallet, so the moment that we have our wallet set up and we open the browser and want to log in. So if someone goes to /#/ or /#/wallet, he should be redirected to login.
I will reformulate it as follows: