fix(assets/dfn-panel.css): remove on save #2846
Conversation
This comment has been minimized.
This comment has been minimized.
sidvishnoi
force-pushed
the
hotfix/css-variable-validation
branch
from
deec8b9
to
fcc0c9a
Compare
sidvishnoi
changed the title
| @@ -10,7 +10,7 @@ export const name = "core/dfn-panel"; | |||
| export async function run() { | |||
| const css = await loadStyle(); | |||
| document.head.insertBefore( | |||
| hyperHTML`<style>${css}</style>`, | |||
| hyperHTML`<style class="removeOnSave">${css}</style>`, | |||
There was a problem hiding this comment.
We want to enable dfn panel on saved documents, no?
There was a problem hiding this comment.
yes, we want to. but not yet. gotta fix echidna breakage first. will add it back with the fix in https://github.com/w3c/respec/pull/2820
There was a problem hiding this comment.
Did you get a change to see other two attempts?
w3c@86e8f5a is good if we want a workaround on css-validator, but way too hacky. I don't see any updates on css-validator fix, so that hack might stay in for a long time.
w3c@fcc0c9a is good practice, but I don't like adding markup for decorative changes.
This reverts commit db890c3.
Will need to send another PR for builds/ then. Because release script no longer generates w3c-common. What do you prefer - here or a new PR? |
Updating w3c-common here sounds fine. |
This reverts commit 6a6f750.
Fixes https://github.com/w3c/respec/issues/2845
Outdated
**Revert this PR as soon as validator is fixed.**w3c/css-validator doesn't support custom properties yet (w3c/css-validator#111), so echidna failed to publish.
Setting position of panel via
panel.style.leftis straightforward, but settingleftfor.dfn-panel::before(the caret/triangle), JS won't allow. We would have to change the markup otherwise- which is something I'm not sure I want to do.God forgive me, for this hack 🙏Update: Hack removed, changed markup instead.