Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fixes on Delta and Meta #1722

Merged
merged 2 commits into from
Jan 9, 2025
Merged

Conversation

lesTYP
Copy link

@lesTYP lesTYP commented Jan 2, 2025

Что этот PR делает

Исправляет некоторые части мусоропровода дельты:

  1. Исправление положения трубы в отбытии
  2. Добавление фильтра в гидропонику
  3. Добавление фильтра в бар

Добавляет на мостик командный мультитул, и в химию меда бак с маслом.

На Цереброне поправлено отображение зеркала в коморке бармена

Почему это хорошо для игры

Мусоропровод должен работать как надо. Командный мультитул должен быть на своем месте, а бак с маслом по просьбе химиков

Изображения изменений

image
image

Тестирование

Локалка

Changelog

🆑
tweak: На мостик Кербероса был закинут внеплановый мультитул
tweak: В химию медотдела Кербероса был доставлен бесплатный бак с маслом
fix: Мусоропровод Кербероса стал чуть эффективнее
/:cl:

Summary by Sourcery

Fix Delta station's disposal system and add missing items on MetaStation.

Bug Fixes:

  • Fixed disposal pipe routing on Delta.
  • Added filters to hydroponics and bar on Delta.

Enhancements:

  • Added a command multitool to the bridge on MetaStation.
  • Added an oil tank to medbay chemistry on MetaStation.
  • Replaced a broken disposal unit with a glass table and cleaner near the paramedic area on MetaStation.
  • Fixed mirror display in the bartender's room on Cerebron.

Copy link

sourcery-ai bot commented Jan 2, 2025

Reviewer's Guide by Sourcery

This pull request implements minor fixes on Delta and Meta stations. It includes fixes for the Delta station's disposal pipe positioning, the addition of filters to hydroponics and the bar, and the placement of a command multitool on the bridge. A medical oil tank was added to the chemistry lab, a broken trash can was replaced, and a mirror display was corrected on Cerebron.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Fixes for Delta Station
  • Fixed disposal pipe positioning in departures.
  • Added a filter to hydroponics.
  • Added a filter to the bar.
_maps/map_files220/stations/deltastation.dmm
Changes on MetaStation
  • Added a command multitool to the bridge.
  • Added a medical oil tank to the chemistry lab.
  • Replaced a broken trash can with a glass table and cleaner.
  • Corrected a mirror display in the bartender's compartment on Cerebron.
_maps/map_files220/stations/metastation.dmm

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@github-actions github-actions bot added Керберос Этот ПР изменил что-то на Керберосе (DeltaStation) Цереброн Этот ПР изменил что-то на Цереброне (MetaStation) labels Jan 2, 2025
@ss220app ss220app bot added the 📜 CL валиден Этот чейнджлог будет успешно опубликован label Jan 2, 2025
@lesTYP lesTYP changed the title Minor fixes om Delta and Meta Minor fixes on Delta and Meta Jan 2, 2025
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @lesTYP - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Please provide more detailed testing information, particularly confirming that you've tested the disposal system routing end-to-end on Delta station.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@AyIong
Copy link
Collaborator

AyIong commented Jan 2, 2025

Ты это точно тестил? Я насколько помню, оно его просто развернёт обратно
image

@lesTYP
Copy link
Author

lesTYP commented Jan 2, 2025

Ты это точно тестил? Я насколько помню, оно его просто развернёт обратно image

Как ни странно, но так построено и в химии меда, и в генетику, и оно работает. Но как именно это работает я не понял
image
image

@m-dzianishchyts
Copy link
Collaborator

m-dzianishchyts commented Jan 2, 2025

Поменяй add: на tweak: в чейнджлоге

@m-dzianishchyts m-dzianishchyts requested a review from AyIong January 9, 2025 07:49
@github-actions github-actions bot added the Merge Conflict Ну блять... label Jan 9, 2025
@github-actions github-actions bot removed the Merge Conflict Ну блять... label Jan 9, 2025
@m-dzianishchyts m-dzianishchyts merged commit a08c9f9 into ss220club:master Jan 9, 2025
12 of 21 checks passed
@lesTYP lesTYP deleted the Delta branch January 12, 2025 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📜 CL валиден Этот чейнджлог будет успешно опубликован Керберос Этот ПР изменил что-то на Керберосе (DeltaStation) Цереброн Этот ПР изменил что-то на Цереброне (MetaStation)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants