forked from ParadiseSS13/Paradise
-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix unit tests #1727
Merged
m-dzianishchyts
merged 10 commits into
ss220club:master
from
m-dzianishchyts:cult-dagger-test-fix
Jan 11, 2025
Merged
Fix unit tests #1727
m-dzianishchyts
merged 10 commits into
ss220club:master
from
m-dzianishchyts:cult-dagger-test-fix
Jan 11, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-dzianishchyts
added
the
📜 CL не требуется
Эти изменения не влияют на игровой процесс или игроки по какой-то причине не должны о них знать
label
Jan 4, 2025
Reviewer's Guide by SourceryThis PR fixes failing tests by updating the spawn location of test puppets. The puppets were spawning in space due to a different centcomm level being used in the tests. The spawn location has been corrected to be within the admin testing area. Sequence diagram for updated throwing object cleanupsequenceDiagram
participant T as Thrownthing
participant SS as SSthrowing Subsystem
T->>+SS: Destroy()
SS->>SS: Remove from processing list
alt currentrun exists
SS->>SS: Remove from currentrun list
end
SS-->>-T: Clear throwing references
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
github-actions
bot
added
🔧 Фикс
Переписываем ошибку так, чтобы она проявлялась в других обстоятельствах
НЕ МОДУЛЬНО
Ну это ваще пиздец. Либо засовывай в модуль, либо заливай на апстрим.
labels
Jan 4, 2025
github-actions
bot
added
Частичная модульность
Не всегда получается всё впихнуть в модуль, увы.
and removed
НЕ МОДУЛЬНО
Ну это ваще пиздец. Либо засовывай в модуль, либо заливай на апстрим.
labels
Jan 4, 2025
m-dzianishchyts
changed the title
Fix cult dagger attack chain test?
Fix cult dagger attack chain test
Jan 11, 2025
Gaxeer
approved these changes
Jan 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Частичная модульность
Не всегда получается всё впихнуть в модуль, увы.
📜 CL не требуется
Эти изменения не влияют на игровой процесс или игроки по какой-то причине не должны о них знать
🔧 Фикс
Переписываем ошибку так, чтобы она проявлялась в других обстоятельствах
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Что этот PR делает
Чинит падающие тесты.
Тестовые куклы спавнились в космосе из-за того, что у нас другой уровень ЦК. Теперь все на своих местах.
Summary by Sourcery
Tests:
Summary by Sourcery
Update the coordinates of the spawn point for test puppets in the admin area to match the updated centcomm map.
Bug Fixes:
Tests: