Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove changelog length limit #1738

Merged
merged 1 commit into from
Jan 11, 2025

Conversation

m-dzianishchyts
Copy link
Collaborator

@m-dzianishchyts m-dzianishchyts commented Jan 11, 2025

Что этот PR делает

Убирает ограничение длины чейнджлога в 4096 символов. Этот случай будет обрабатываться ботом путем отправки чейнджлога в несколько последовательных сообщений.

Тестирование

Бот протестирован.

Summary by Sourcery

Enhancements:

  • Handle long changelogs by sending them in multiple consecutive messages.

@m-dzianishchyts m-dzianishchyts added the 📜 CL не требуется Эти изменения не влияют на игровой процесс или игроки по какой-то причине не должны о них знать label Jan 11, 2025
Copy link

sourcery-ai bot commented Jan 11, 2025

Reviewer's Guide by Sourcery

This PR removes the 4096 character limit for changelog entries. Instead of truncating the changelog, the bot will now send the changelog in multiple messages if it exceeds the limit.

Sequence diagram for changelog validation and sending process

sequenceDiagram
    participant PR as Pull Request
    participant Bot as Changelog Bot
    participant Discord as Discord Channel

    PR->>Bot: Submit changelog
    activate Bot
    Note over Bot: Validate changelog
    alt Changelog is valid
        Bot->>Discord: Send first part of changelog
        loop If more content remains
            Bot->>Discord: Send next part of changelog
        end
    else Changelog is invalid
        Bot-->>PR: Return validation error
    end
    deactivate Bot
Loading

File-Level Changes

Change Details Files
Removed the changelog length limit.
  • Removed the DISCORD_EMBED_DESCRIPTION_LIMIT constant.
  • Removed the logic that raises an exception if the changelog exceeds the limit.
  • Removed the logic that joins change messages before checking the length limit.
tools/changelog/changelog_utils.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@github-actions github-actions bot added :shipit: Улучшение Наконец-то это сделали удобнее и лучше... 🎸 Инструменты Мы выдаем себя за реальное сообщество разработчиков. labels Jan 11, 2025
Copy link
Collaborator

@AyIong AyIong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Все тесты упали нахуй, думаю можно лить

@AyIong AyIong merged commit 78463fe into ss220club:master Jan 11, 2025
14 of 23 checks passed
@m-dzianishchyts m-dzianishchyts deleted the cl-length-tweak branch January 11, 2025 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎸 Инструменты Мы выдаем себя за реальное сообщество разработчиков. 📜 CL не требуется Эти изменения не влияют на игровой процесс или игроки по какой-то причине не должны о них знать :shipit: Улучшение Наконец-то это сделали удобнее и лучше...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants