Merge Upstream 15.01.2025

[ss220app]

This pull request merges upstream/master. Resolve possible conflicts manually and make sure all the changes are applied correctly.

Note

Requires Wiki Update:
www.github.com/ParadiseSS13/Paradise/pull/27857
www.github.com/ParadiseSS13/Paradise/pull/27927
www.github.com/ParadiseSS13/Paradise/pull/27897

Changelog

🆑 ParadiseSS13
tweak: Администраторы теперь могут выдавать специальные законы ИИ и боргам при вызове Отряда смерти.
add: Камеры улучшены и теперь отображают освещение и тени на изображениях.
fix: Трава больше не отображается на фотографиях как парящая, показывая темноту под ней.
imageadd: Изменён спрайт ящика с рудой.
add: Добавлены подтяжки в ассортимент Autodrobe.
imageadd: Обновлён спрайт ветра, теперь он больше напоминает частицы пыли.
tweak: Командам ERT уровня Amber/Red добавлен Crew Pinpointer, команда Gamma получает NAD Pinpointer.
tweak: РЦД боргов теперь используют картриджи, РЦД боргов Синдиката изменения не затронули.
fix: Исправлены звуки взлома сейфов при ношении стетоскопа на шее.
add: Цели заданий теперь отображаются при появлении в раунде (в данный момент это касается Директора исследований, Робототехников, Учёных и Вирусолога).
fix: Перчатки для синтеза теперь корректно активируются.
fix: "His Grace" теперь навсегда получает свойство "nodrop" после Вознесения.
add: Добавлены хирургические подносы (зелёная коробка для инструментов) в рецепты из титана; для создания требуется один лист титана.
tweak: Хирургические подносы (перемещаемые зелёные столики) теперь называются "surgical instrument table".
tweak: Стоимость крафта столика хирургических инструментов увеличена с двух до трёх листов титана.
tweak: Обновлены спрайты Зеркала и Волшебного зеркала авторства atpengineer.
add: Ржавчина еретиков добавлена для Ревенантов.
add: Ржавчину теперь можно удалять с помощью сварочного аппарата.
add: На ржавых тайлах больше нельзя класть плитку или использовать РЦД.
fix: Исправлены отображения абстрактных предметов при осмотре моба.
tweak: Склад Синдиката получил несколько новых товаров для снабжения агентов в секторе.
tweak: Автохирурги на складе Синдиката стали слишком дорогими, поэтому теперь импланты требуют хирургической установки.
fix: Сообщение для администраторов при появлении SIT обновлено, учитывая инфляцию TC в 2023 году. Теперь вероятность выдачи слишком малого количества TC снижается. Упс.
fix: Больше нельзя блокировать огонь или голографические лучи.
imagedel: Дионы больше не имеют человеческих глаз поверх своих собственных.
tweak: Удалено неработающее меню выбора цвета глаз у слаймолюдей.
add: Добавлены новые эффекты галлюцинации в меданализаор и химсканер.
fix: Исправлены сообщения о времени взлома шкафа, которые отображали некорректную продолжительность.
/:cl:

Summary by Sourcery

Update cameras to display lighting and shadows, add suspenders to Autodrobe, update wind sprite to resemble dust particles, add surgical trays to titanium recipes, and resprite mirrors. Update job objectives display on spawn, fix various bugs related to safe cracking sounds, toilet labels, fusion gauntlets, and "His Grace" item. Introduce new rust sprites and mechanics, including removal with a welder and building restrictions on rusted tiles. Enhance medical and chemical scanners with hallucination effects, and fix breakout message times for lockers.

New Features:

• New rust sprites and mechanics have been added. Rust can be removed with a welder, and you can no longer build on rusted tiles.
• Medical and chemical scanners now have hallucination effects.
• Admins can now choose whether to give AI and cyborgs Terminator laws when calling a Death Squad.
• Cameras now display lighting and shadows in images.
• Suspenders have been added to the Autodrobe.
• The wind sprite has been updated to look more like dust particles.
• Surgical trays have been added to the titanium recipes.
• Mirrors have been resprited.
• Job objectives are now displayed on spawn for Research Director, Roboticists, Scientists, and Virologist.

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request merges the upstream/master branch, resolving conflicts and applying all changes. It includes a variety of tweaks, additions, and fixes across various game systems.

Sequence diagram for medical scanner hallucination effects

sequenceDiagram
    participant User as User
    participant Scanner as Medical Scanner
    participant Target as Scan Target
    participant Hallucination as Hallucination System

    User->>Scanner: Use scanner
    alt User is hallucinating
        Scanner->>Hallucination: Check for hallucination effects
        Hallucination->>Scanner: Apply random effects
        Scanner-->>User: Show altered scan results
        Note over Scanner,User: May show:
        Note over Scanner,User: - Wrong reagent amounts
        Note over Scanner,User: - Fake overdoses
        Note over Scanner,User: - Incorrect health values
    else Normal operation
        Scanner->>Target: Scan health status
        Target-->>Scanner: Return actual values
        Scanner-->>User: Show accurate results
    end

Loading

Class diagram for rust element system

classDiagram
    class datum_element_rust {
        +rust_overlay: image
        +Attach(atom/target)
        +Detach(atom/source)
        +handle_examine()
        +apply_rust_overlay()
        +welder_tool_act()
        +handle_tool_use()
        +on_interaction()
    }

    class datum_element_rust_heretic {
        +on_entered()
        +on_exited()
    }

    class obj_effect_glowing_rune {
        +Initialize()
    }

    datum_element_rust <|-- datum_element_rust_heretic
    datum_element_rust_heretic --> obj_effect_glowing_rune

    note for datum_element_rust "Base rust element that handles
rust overlays and interactions"
    note for datum_element_rust_heretic "Extended rust element with
special effects for heretics"

Loading

State diagram for camera flash system

stateDiagram-v2
    [*] --> FlashOff: Initialize
    FlashOff --> FlashOn: Toggle Flash
    FlashOn --> FlashOff: Toggle Flash

    state FlashOn {
        [*] --> Active
        Active: Light enabled
        Active: Full lighting in photos
    }

    state FlashOff {
        [*] --> Inactive
        Inactive: Light disabled
        Inactive: Ambient lighting in photos
    }

Loading

File-Level Changes

Change	Details	Files
Admins can now specify AI and cyborg laws when calling a Death Squad.	Added a prompt for admins to set AI and cyborg laws to Terminator when spawning a Death Squad.	code/modules/admin/verbs/deathsquad.dm
Cameras now render lighting and shadows, and grass no longer appears floating in photos.	Cameras now include lighting objects in photos. Fixed grass appearing as floating in photographs.	code/modules/paperwork/photography.dm
Added new rust sprites and mechanics.	Added new rust sprites. Rust can now be removed with a welder. Rusted tiles prevent tile and RCD usage. Added rust effects to walls and floors. Added a rust status effect. Updated mapping helpers for rust.	code/game/turfs/simulated/walls.dm code/game/turfs/simulated/floor/misc_floor.dm code/datums/status_effects/debuffs.dm code/game/turfs/turf.dm code/modules/mapping/mapping_helpers.dm rust/src/milla/api.rs code/datums/elements/rust_element.dm
Updated medical and chemscanners to display hallucination effects.	Medical and chemscanners now display hallucination effects.	code/game/objects/items/devices/scanners.dm
Updated Syndicate Depot items and prices.	Added new items to the Syndicate Depot. Adjusted prices of existing items.	code/game/objects/effects/spawners/depot_spawners.dm
Updated RCD interaction to use new attack chain.	Updated RCD interaction to use the new attack chain.	code/game/objects/items/weapons/RCD.dm
Updated various item interactions and descriptions.	Fixed safe cracking sounds with stethoscope on neck. His Grace now permanently has nodrop when ascended. Fixed abstract items showing on mob examine. Added surgical trays to titanium recipes. Surgical trays are now called surgical instrument tables.	code/game/objects/structures/safe.dm code/game/objects/items/his_grace.dm code/modules/mob/living/carbon/examine.dm code/game/objects/items/stacks/sheets/mineral.dm code/game/objects/structures/tables_racks.dm
Updated job objectives display.	Job objectives are now displayed when spawning. Updated description of the "Construct Additional Cyborgs" objective.	code/controllers/subsystem/SSjobs.dm code/game/jobs/job_objectives/science.dm
Miscellaneous tweaks and fixes.	Added suspenders to Autodrobe. Fixed pyro claws deployment with items in hands. Fixed breakout messages for lockers. Updated TC suggestion for infiltrator team. Removed non-functional eye color menu for slimepeople. Updated Diona eye color. Added new hallucination effects.	code/game/machinery/vendors/generic_vendors.dm code/game/objects/items/weapons/twohanded.dm code/game/objects/structures/crates_lockers/closets.dm code/game/objects/structures/crates_lockers/closets/secure/secure_closets.dm code/game/turfs/simulated/floor/plating.dm code/modules/admin/verbs/infiltratorteam_syndicate.dm code/modules/client/preference/preferences.dm code/modules/mob/living/carbon/carbon_emote.dm code/modules/paperwork/silicon_photography.dm code/modules/hallucinations/hallucinations.dm code/modules/mob/living/carbon/human/species/diona_species.dm

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time. You can also use
  this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

We have skipped reviewing this pull request. It seems to have been created by a bot (hey, ss220app[bot]!). We assume it knows what it's doing!

[AyIong]

!build_rust

[AyIong]

!build_rust

[AyIong]

!build_rust